From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from out2-smtp.messagingengine.com (out2-smtp.messagingengine.com [66.111.4.26]) by dpdk.org (Postfix) with ESMTP id 3BE951BB47 for ; Sun, 13 May 2018 18:47:17 +0200 (CEST) Received: from compute1.internal (compute1.nyi.internal [10.202.2.41]) by mailout.nyi.internal (Postfix) with ESMTP id 434242483B; Sun, 13 May 2018 12:47:17 -0400 (EDT) Received: from mailfrontend1 ([10.202.2.162]) by compute1.internal (MEProxy); Sun, 13 May 2018 12:47:17 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to:x-me-sender :x-me-sender:x-sasl-enc; s=mesmtp; bh=EUTyaLO+XDOcxgk3aU8ZjeWnza mVlTYHYPyScAqDk/w=; b=FR+9XEUyYgFM0MEYdZxCdwNEQ+Z7jTWctis6JfyANU HECKIqBl0fQvIf0z1AZRiIaoyncCFovwOGKfOeDue4bBLwwKmYuFkAHWXl3szxuX 2gycwG7vEfEYx9gh74Ryp9FVzoh+eM6uc2jfW9vNL2ZgxNzb0WVZGQcMpF9Z1jHi s= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-transfer-encoding:content-type :date:from:in-reply-to:message-id:mime-version:references :subject:to:x-me-sender:x-me-sender:x-sasl-enc; s=fm2; bh=EUTyaL O+XDOcxgk3aU8ZjeWnzamVlTYHYPyScAqDk/w=; b=SlrNNMW7vXZT9beNPxElgp 91MlyS3Ssup0FMrv5pU7tXaMFaLEJ6Ejfpkrrba6ZagoPHM2bxJ5L+hnKlD+mvhT t8q5GAP+Y04ksrFDEnXEzn9hUwBx9wDdhbzkOKGgzC0rIvpYLkpvfJkIjH54BIzm 5excI8bw0fuRZtg6pHeTmhCYO3ET9RFHceOZuHCE6QPe4ZIwIubcElzZ1IFnrLlx aakKoVDwUyAB4Z8pq333nndrl3EQVwOrfrd1/Iott0EztocSGkNr/ffdLSR58QlM GiExt/wvCUZ5MX0o9MpOvU5rcgUD+8+U8xPbN4oPs7V8zff3LgGtbLcNieuY+dtQ == X-ME-Sender: Received: from xps.localnet (184.203.134.77.rev.sfr.net [77.134.203.184]) by mail.messagingengine.com (Postfix) with ESMTPA id 89581E4919; Sun, 13 May 2018 12:47:16 -0400 (EDT) From: Thomas Monjalon To: Andy Green Cc: dev@dpdk.org, bruce.richardson@intel.com, olivier.matz@6wind.com Date: Sun, 13 May 2018 18:47:15 +0200 Message-ID: <1908380.h0rCPQG6nq@xps> In-Reply-To: <152609036246.121661.18385114679529023835.stgit@localhost.localdomain> References: <152609021699.121661.5295227351721865436.stgit@localhost.localdomain> <152609036246.121661.18385114679529023835.stgit@localhost.localdomain> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Subject: Re: [dpdk-dev] [PATCH v3 08/24] rte_ring_generic.h: stack declarations before code X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 13 May 2018 16:47:18 -0000 12/05/2018 03:59, Andy Green: > /projects/lagopus/src/dpdk/build/include/rte_ring_generic.h: > In function '__rte_ring_move_prod_head': > /projects/lagopus/src/dpdk/build/include/rte_ring_generic.h:76:3: > warning: ISO C90 forbids mixed declarations and code > [-Wdeclaration-after-statement] > const uint32_t cons_tail = r->cons.tail; > ^~~~~ > /projects/lagopus/src/dpdk/build/include/rte_ring_generic.h: > In function '__rte_ring_move_cons_head': > /projects/lagopus/src/dpdk/build/include/rte_ring_generic.h:147:3: > warning: ISO C90 forbids mixed declarations and code > [-Wdeclaration-after-statement] > const uint32_t prod_tail = r->prod.tail; The fix line is: Fixes: 0dfc98c507b1 ("ring: separate out head index manipulation") But I wonder why it was done like this. Maybe there is a hidden reason. Bruce? Olivier? > Signed-off-by: Andy Green [...] > --- a/lib/librte_ring/rte_ring_generic.h > +++ b/lib/librte_ring/rte_ring_generic.h > @@ -73,14 +73,13 @@ __rte_ring_move_prod_head(struct rte_ring *r, int is_sp, > */ > rte_smp_rmb(); > > - const uint32_t cons_tail = r->cons.tail; > /* > * The subtraction is done between two unsigned 32bits value > * (the result is always modulo 32 bits even if we have > * *old_head > cons_tail). So 'free_entries' is always between 0 > * and capacity (which is < size). > */ > - *free_entries = (capacity + cons_tail - *old_head); > + *free_entries = (capacity + r->cons.tail - *old_head);