From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-wg0-f45.google.com (mail-wg0-f45.google.com [74.125.82.45]) by dpdk.org (Postfix) with ESMTP id 9BA0E231C for ; Thu, 22 May 2014 16:32:45 +0200 (CEST) Received: by mail-wg0-f45.google.com with SMTP id m15so3534175wgh.16 for ; Thu, 22 May 2014 07:32:55 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:from:to:cc:subject:date:message-id:organization :user-agent:in-reply-to:references:mime-version :content-transfer-encoding:content-type; bh=/+r1sk4LqAVN/oNaxyUxWGBZtBLHQZqqcK+x0QDyVBI=; b=d5bVDmRYq0Ok7Gpm69qvAJjALpU0+b8HRnOQq7aUO69qE3adfY3qJ8sCrY3jh4as0O UzRFOPjybCULNdpvCQ/geGC2Lyf3Ebd37oyi3uw7ySQe02zF3xm6TNmeUiwPMDqZ2Cri Iwg0ro+OrHP71idTBOXlZaeP3x7dwpvzjQCVmqrddr4GBUzdHv/J3qlf5C1eZNP+iUvf GOCWpYQEZ60OlahVptzK3p/jZCF/Ow14nE4aEdIJWMQ0E3kYbhjDw1i65wfUcKtNxmT5 OMFydXFOtGRzo1p/lqjbFcsZvBIvJ9zpIj1BtJPOu6W/28XpCJFebsJwDgolHeI49yUw nT7w== X-Gm-Message-State: ALoCoQkzsi+xdM/drNnxW3wbaFLy9OtWyBg/rATw+Jgeqms8OkBQE0Z7vaGO2xGnEpCc+yunMVgf X-Received: by 10.181.12.104 with SMTP id ep8mr7503098wid.0.1400769175110; Thu, 22 May 2014 07:32:55 -0700 (PDT) Received: from xps13.localnet (6wind.net2.nerim.net. [213.41.180.237]) by mx.google.com with ESMTPSA id na4sm8262883wic.21.2014.05.22.07.32.53 for (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Thu, 22 May 2014 07:32:53 -0700 (PDT) From: Thomas Monjalon To: Helin Zhang Date: Thu, 22 May 2014 16:32:51 +0200 Message-ID: <1909311.37348vjfnn@xps13> Organization: 6WIND User-Agent: KMail/4.13 (Linux/3.14.4-1-ARCH; KDE/4.13.0; x86_64; ; ) In-Reply-To: <1400729717-6195-1-git-send-email-helin.zhang@intel.com> References: <1400729717-6195-1-git-send-email-helin.zhang@intel.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Cc: dev@dpdk.org Subject: Re: [dpdk-dev] [PATCH v2] kni: bug fix for compile issue in KNI on Fedora 18 with kernel 3.6.10 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 22 May 2014 14:32:46 -0000 2014-05-22 11:35, Helin Zhang: > Error of "implicit-function-declaration" can be seen when building KNI > kernel module on Linux kernel 3.6.10 platform, as follows. > "x86_64-native-linuxapp-gcc/build/lib/librte_eal/linuxapp/kni/igb_ethtool.c: > In function \u2018igb_get_eee\u2019: > x86_64-native-linuxapp-gcc/build/lib/librte_eal/linuxapp/kni/igb_ethtool.c: > 2441:4: error: implicit declaration of function > \u2018mmd_eee_adv_to_ethtool_adv_t\u2019 > [-Werror=implicit-function-declaration] > x86_64-native-linuxapp-gcc/build/lib/librte_eal/linuxapp/kni/igb_ethtool.c: > In function \u2018igb_set_eee\u2019: > x86_64-native-linuxapp-gcc/build/lib/librte_eal/linuxapp/kni/igb_ethtool.c: > 2551:2: error: implicit declaration of function > \u2018ethtool_adv_to_mmd_eee_adv_t\u2019 > [-Werror=implicit-function-declaration]" > > The root cause is as follows. > On Fedora 18 with kernel 3.6.10, ETHTOOL_GEEE is defined in Linux > header file of "linux/ethtool.h", while is not defined in most of other > linux kernel versions. > mmd_eee_cap_to_ethtool_sup_t(), mmd_eee_adv_to_ethtool_adv_t() and > ethtool_adv_to_mmd_eee_adv_t() in kcompat.h are disabled by "#if > !defined(ETHTOOL_GEEE) || (RHEL_RELEASE_CODE && RHEL_RELEASE_CODE <= > RHEL_RELEASE_VERSION(6,4))", while are called in igb_get_eee() in > igb_ethtool.c which is enabled by "#ifdef ETHTOOL_GEEE". > > Signed-off-by: Helin Zhang Acked-by: Thomas Monjalon Applied for version 1.7.0. Thanks -- Thomas