From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 092B9A0548; Mon, 10 May 2021 07:44:26 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 7F87C40140; Mon, 10 May 2021 07:44:26 +0200 (CEST) Received: from mga14.intel.com (mga14.intel.com [192.55.52.115]) by mails.dpdk.org (Postfix) with ESMTP id 37CD04003E for ; Mon, 10 May 2021 07:44:23 +0200 (CEST) IronPort-SDR: vjth/BfboLBcKN8iXrUsSC/mzJuKGH5PMjnxBY+50k+mKokk8KJluuZz2ABNE8e4DKlifwf2wm IxZPqQey2YVA== X-IronPort-AV: E=McAfee;i="6200,9189,9979"; a="198793592" X-IronPort-AV: E=Sophos;i="5.82,286,1613462400"; d="scan'208";a="198793592" Received: from fmsmga004.fm.intel.com ([10.253.24.48]) by fmsmga103.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 09 May 2021 22:44:21 -0700 IronPort-SDR: IEqRg7hZFz9B7EzRz9/AFO9Xij8uL21oq3DBRzYcS7teWGIPNkUv2l5aNl+i5YURx6ZjyKoGHB +YPa8Z2t3Pmg== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.82,286,1613462400"; d="scan'208";a="454265721" Received: from fmsmsx601.amr.corp.intel.com ([10.18.126.81]) by fmsmga004.fm.intel.com with ESMTP; 09 May 2021 22:44:20 -0700 Received: from shsmsx603.ccr.corp.intel.com (10.109.6.143) by fmsmsx601.amr.corp.intel.com (10.18.126.81) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2106.2; Sun, 9 May 2021 22:44:20 -0700 Received: from shsmsx601.ccr.corp.intel.com (10.109.6.141) by SHSMSX603.ccr.corp.intel.com (10.109.6.143) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2106.2; Mon, 10 May 2021 13:44:18 +0800 Received: from shsmsx601.ccr.corp.intel.com ([10.109.6.141]) by SHSMSX601.ccr.corp.intel.com ([10.109.6.141]) with mapi id 15.01.2106.013; Mon, 10 May 2021 13:44:18 +0800 From: "Zhang, Qi Z" To: "Yang, Qiming" CC: "dev@dpdk.org" Thread-Topic: [PATCH] net/ice/base: remove unnecessary code Thread-Index: AQHXRUtTujcXbRTGaEuFsmdfa72IQarbopcAgACRwHA= Date: Mon, 10 May 2021 05:44:18 +0000 Message-ID: <190dd395a4134d49bb07f3ab43b25289@intel.com> References: <20210510032326.3163171-1-qi.z.zhang@intel.com> In-Reply-To: Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: dlp-reaction: no-action dlp-version: 11.5.1.3 dlp-product: dlpe-windows x-originating-ip: [10.239.127.36] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Subject: Re: [dpdk-dev] [PATCH] net/ice/base: remove unnecessary code X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" > -----Original Message----- > From: Yang, Qiming > Sent: Monday, May 10, 2021 1:02 PM > To: Zhang, Qi Z > Cc: dev@dpdk.org > Subject: RE: [PATCH] net/ice/base: remove unnecessary code >=20 >=20 > > -----Original Message----- > > From: Zhang, Qi Z > > Sent: Monday, May 10, 2021 11:23 > > To: Yang, Qiming > > Cc: dev@dpdk.org; Zhang, Qi Z > > Subject: [PATCH] net/ice/base: remove unnecessary code > > > > Coverty issue: 370613 > > Execution cannot reach this statement: "break;". > > Remove the unnecessary if branch. > > > > Fixes: 2913bc4155d2 ("net/ice/base: sign external device package > > programming") > > > > Signed-off-by: Qi Zhang > > --- > > drivers/net/ice/base/ice_common.c | 3 --- > > 1 file changed, 3 deletions(-) > > > > diff --git a/drivers/net/ice/base/ice_common.c > > b/drivers/net/ice/base/ice_common.c > > index ac412a1aa7..cf0a7d4e7f 100644 > > --- a/drivers/net/ice/base/ice_common.c > > +++ b/drivers/net/ice/base/ice_common.c > > @@ -2009,9 +2009,6 @@ ice_parse_common_caps(struct ice_hw *hw, > struct > > ice_hw_common_caps *caps, > > { > > u8 index =3D cap - ICE_AQC_CAPS_EXT_TOPO_DEV_IMG0; > > > > - if (index >=3D ICE_EXT_TOPO_DEV_IMG_COUNT) > > - break; > > - > > caps->ext_topo_dev_img_ver_high[index] =3D number; > > caps->ext_topo_dev_img_ver_low[index] =3D logical_id; > > caps->ext_topo_dev_img_part_num[index] =3D > > -- > > 2.26.2 >=20 > Acked-by: Qiming Yang Applied to dpdk-next-net-intel. Thanks Qi