DPDK patches and discussions
 help / color / mirror / Atom feed
From: Thomas Monjalon <thomas.monjalon@6wind.com>
To: Declan Doherty <declan.doherty@intel.com>
Cc: dev@dpdk.org
Subject: Re: [dpdk-dev] [PATCH 4/6] bond: free mbufs if transmission fails in bonding tx_burst functions
Date: Fri, 29 Aug 2014 17:36:48 +0200
Message-ID: <1910212.FXdz9376n2@xps13> (raw)
In-Reply-To: <D01A81B6.27E1%rsanford@akamai.com>

Hi Declan,

Your patchset is pending for an answer to this comment.

2014-08-20 15:54, Sanford, Robert:
> I have a problem with the TX-burst logic of this patch. I believe that for
> packets that we *don't* enqueue to the device, we should *NOT* free them.
> The API expects that the caller will free them or try again to send them.
> 
> Here is one way to accomplish selective freeing: Move mbuf pointers of
> packets successfully enqueued, to the beginning of the caller's mbuf
> vector; move mbuf pointers of packets not enqueued, to the end of the
> caller's mbuf list. Although possibly re-ordered, the caller will be able
> to free/resend all (and only) mbufs that we failed to enqueue.

  reply	other threads:[~2014-08-29 15:32 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-08-20 20:54 Sanford, Robert
2014-08-29 15:36 ` Thomas Monjalon [this message]
  -- strict thread matches above, loose matches on Subject: below --
2014-08-19 13:51 [dpdk-dev] [PATCH 0/6] link bonding Declan Doherty
2014-08-19 13:51 ` [dpdk-dev] [PATCH 4/6] bond: free mbufs if transmission fails in bonding tx_burst functions Declan Doherty

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1910212.FXdz9376n2@xps13 \
    --to=thomas.monjalon@6wind.com \
    --cc=declan.doherty@intel.com \
    --cc=dev@dpdk.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

DPDK patches and discussions

This inbox may be cloned and mirrored by anyone:

	git clone --mirror https://inbox.dpdk.org/dev/0 dev/git/0.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 dev dev/ https://inbox.dpdk.org/dev \
		dev@dpdk.org
	public-inbox-index dev

Example config snippet for mirrors.
Newsgroup available over NNTP:
	nntp://inbox.dpdk.org/inbox.dpdk.dev


AGPL code for this site: git clone https://public-inbox.org/public-inbox.git