DPDK patches and discussions
 help / color / mirror / Atom feed
From: Thomas Monjalon <thomas@monjalon.net>
To: Rosen Xu <rosen.xu@intel.com>
Cc: dev@dpdk.org, roy.fan.zhang@intel.com, declan.doherty@intel.com,
	bruce.richardson@intel.com, shreyansh.jain@nxp.com,
	ferruh.yigit@intel.com, konstantin.ananyev@intel.com,
	tianfei.zhang@intel.com, song.liu@intel.com, hao.wu@intel.com,
	gaetan.rivet@6wind.com
Subject: Re: [dpdk-dev] [dpdk-stable] [PATCH] drivers/raw/ifpga_rawdev: fix coverity issue
Date: Mon, 21 May 2018 16:22:33 +0200	[thread overview]
Message-ID: <1913991.jNxr5nhODZ@xps> (raw)
In-Reply-To: <1526478813-154172-1-git-send-email-rosen.xu@intel.com>

16/05/2018 15:53, Rosen Xu:
> Fix coverity issue: 279449
> 
> Signed-off-by: Rosen Xu <rosen.xu@intel.com>
> 
> Fixes: ef1e8ede3da5 ("raw/ifpga: add Intel FPGA bus rawdev driver")
> Coverity issue: 279449
> Cc: stable@dpdk.org

Not for stable

> --- a/drivers/raw/ifpga_rawdev/ifpga_rawdev.c
> +++ b/drivers/raw/ifpga_rawdev/ifpga_rawdev.c
> @@ -227,7 +227,7 @@
>  	int file_fd;
>  	int ret = 0;
>  	ssize_t buffer_size;
> -	void *buffer;
> +	void *buffer = NULL;

It is not fixing anything.
This variable cannot be read before being written.

  reply	other threads:[~2018-05-21 14:22 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-05-16 13:53 [dpdk-dev] " Rosen Xu
2018-05-21 14:22 ` Thomas Monjalon [this message]
2018-05-22 10:42   ` [dpdk-dev] [dpdk-stable] " Xu, Rosen

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1913991.jNxr5nhODZ@xps \
    --to=thomas@monjalon.net \
    --cc=bruce.richardson@intel.com \
    --cc=declan.doherty@intel.com \
    --cc=dev@dpdk.org \
    --cc=ferruh.yigit@intel.com \
    --cc=gaetan.rivet@6wind.com \
    --cc=hao.wu@intel.com \
    --cc=konstantin.ananyev@intel.com \
    --cc=rosen.xu@intel.com \
    --cc=roy.fan.zhang@intel.com \
    --cc=shreyansh.jain@nxp.com \
    --cc=song.liu@intel.com \
    --cc=tianfei.zhang@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).