From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <thomas@monjalon.net>
Received: from out1-smtp.messagingengine.com (out1-smtp.messagingengine.com
 [66.111.4.25]) by dpdk.org (Postfix) with ESMTP id 035A11B1B4
 for <dev@dpdk.org>; Mon, 21 May 2018 16:22:41 +0200 (CEST)
Received: from compute1.internal (compute1.nyi.internal [10.202.2.41])
 by mailout.nyi.internal (Postfix) with ESMTP id 09B0622443;
 Mon, 21 May 2018 10:22:40 -0400 (EDT)
Received: from mailfrontend1 ([10.202.2.162])
 by compute1.internal (MEProxy); Mon, 21 May 2018 10:22:40 -0400
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h=
 cc:content-transfer-encoding:content-type:date:from:in-reply-to
 :message-id:mime-version:references:subject:to:x-me-sender
 :x-me-sender:x-sasl-enc; s=mesmtp; bh=amNAL4DVx8uVOsPGlkBewbCTck
 g0BB9hS0/d2iAoUss=; b=Tz+tsUP6u4Bp9+vgYIOdQ227Garmn4INOtlPel++y7
 7v7LOBXRO73C3USVuqiymWAu3DxENyaEeT65T+4FVXAbdUPLCdI6bezTIQgVtDLe
 TtNsNTY6wsIMDN+sw4LZ2b77QxsLwniL8IKgBXGekRbaKjt6ZKvE24K/LHw+nL7u
 8=
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=
 messagingengine.com; h=cc:content-transfer-encoding:content-type
 :date:from:in-reply-to:message-id:mime-version:references
 :subject:to:x-me-sender:x-me-sender:x-sasl-enc; s=fm2; bh=amNAL4
 DVx8uVOsPGlkBewbCTckg0BB9hS0/d2iAoUss=; b=f4EzeIGFb9gx86Eqk2vGws
 iQO08DzshFf+GSeqQKrmd4zyK2VpKktUF2ArYTDUuLRDJDrEM9V1HBtc6/+kH4Sa
 jVPGE2CP3UEyD1Muy+wxn66hma8y9GyK/cWoxDX37jInlBoALqRe+hfC55G3K3R2
 vsQW38B/Syjf/+XgTqfwxwrocsjEPALx5Vy16m+0cLKfNeVaPDWlvxhFOgbAHup+
 pMBVpTEy+45hDEHbsGNAy21R7pc01Vc8C7Hfyhq93BDCiL+ooJ36aswmZKJPE8YU
 CgxHAAopCfSP8YWPgaCJvCKYgbRjrFg9hh3XEwMTmLCqlJuHyRqlSfIqUsJSZYIQ
 ==
X-ME-Proxy: <xmx:L9YCW_l6CYq_emPSW2PkvGC05L7oUxWPRRofh0CKcSjIIZp0FUy4Aw>
X-ME-Proxy: <xmx:L9YCW2Qw7DL7EVeytoVBFS7x2vsW93f5_-dQMOzD_ghMPqh0RJSB9w>
X-ME-Proxy: <xmx:L9YCW-Lbo_dVQnXQzkR46_o40OB8JOGjB6Y6QrRg6sMNzkHQkRXYag>
X-ME-Proxy: <xmx:L9YCW-A4YLr8M0SpBRolLa-4w0g40pY-z1iyrcWeKqlo3LFRzQhnGw>
X-ME-Proxy: <xmx:L9YCWwQ6jCmloOSnszLlzUFEDTi_MID4WIzzt3kQ3HUxfhdKZqVqtA>
X-ME-Proxy: <xmx:L9YCW4qa7KWvSlIWPPjtl2W53pI2xgifsYDNRJeQuRicm5Uu8GZRJQ>
X-ME-Sender: <xms:L9YCW3_91LM6VI3gDpW8lkSMD_34dQ2Hk0i6wJAfuXzHLOZ2IvqHTg>
Received: from xps.localnet (236.204.154.77.rev.sfr.net [77.154.204.236])
 by mail.messagingengine.com (Postfix) with ESMTPA id 3F666E4BB5;
 Mon, 21 May 2018 10:22:36 -0400 (EDT)
From: Thomas Monjalon <thomas@monjalon.net>
To: Rosen Xu <rosen.xu@intel.com>
Cc: dev@dpdk.org, roy.fan.zhang@intel.com, declan.doherty@intel.com,
 bruce.richardson@intel.com, shreyansh.jain@nxp.com, ferruh.yigit@intel.com,
 konstantin.ananyev@intel.com, tianfei.zhang@intel.com, song.liu@intel.com,
 hao.wu@intel.com, gaetan.rivet@6wind.com
Date: Mon, 21 May 2018 16:22:33 +0200
Message-ID: <1913991.jNxr5nhODZ@xps>
In-Reply-To: <1526478813-154172-1-git-send-email-rosen.xu@intel.com>
References: <1526478813-154172-1-git-send-email-rosen.xu@intel.com>
MIME-Version: 1.0
Content-Transfer-Encoding: 7Bit
Content-Type: text/plain; charset="us-ascii"
Subject: Re: [dpdk-dev] [dpdk-stable] [PATCH] drivers/raw/ifpga_rawdev: fix
	coverity issue
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <https://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <https://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
X-List-Received-Date: Mon, 21 May 2018 14:22:42 -0000

16/05/2018 15:53, Rosen Xu:
> Fix coverity issue: 279449
> 
> Signed-off-by: Rosen Xu <rosen.xu@intel.com>
> 
> Fixes: ef1e8ede3da5 ("raw/ifpga: add Intel FPGA bus rawdev driver")
> Coverity issue: 279449
> Cc: stable@dpdk.org

Not for stable

> --- a/drivers/raw/ifpga_rawdev/ifpga_rawdev.c
> +++ b/drivers/raw/ifpga_rawdev/ifpga_rawdev.c
> @@ -227,7 +227,7 @@
>  	int file_fd;
>  	int ret = 0;
>  	ssize_t buffer_size;
> -	void *buffer;
> +	void *buffer = NULL;

It is not fixing anything.
This variable cannot be read before being written.