From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 44729A0540; Wed, 8 Jun 2022 19:22:41 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 2295740689; Wed, 8 Jun 2022 19:22:41 +0200 (CEST) Received: from out4-smtp.messagingengine.com (out4-smtp.messagingengine.com [66.111.4.28]) by mails.dpdk.org (Postfix) with ESMTP id 9563940042 for ; Wed, 8 Jun 2022 19:22:40 +0200 (CEST) Received: from compute4.internal (compute4.nyi.internal [10.202.2.44]) by mailout.nyi.internal (Postfix) with ESMTP id 5238D5C01DA; Wed, 8 Jun 2022 13:22:40 -0400 (EDT) Received: from mailfrontend1 ([10.202.2.162]) by compute4.internal (MEProxy); Wed, 08 Jun 2022 13:22:40 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h= cc:cc:content-transfer-encoding:content-type:date:date:from:from :in-reply-to:in-reply-to:message-id:mime-version:references :reply-to:sender:subject:subject:to:to; s=fm2; t=1654708960; x= 1654795360; bh=UxhLP/sxB3MUIbGFbgDrsV5yQlYXLmfCXPnfops9pmg=; b=q 1d09B2KQb3URb9HIOV9VZ+LOzm3aC7q4aLoIn7q/DQ5r7WDyeeiN+he4+uLa6HA1 7rQGuLwBcWIrCdjX60de7k0c/Xggr76GXazlKct2Rucu+N4G4VRBRXy7YPuYu9Kt peTrs6O0Vj57kgXqeqDbMC9keiWc//+nY2zyd5eJlxBhwSymAJrIVkXQPLrc7h8E d66DqYIsovHtBHmCQG7zsGeKB1A6hidy1oltW/sAmu2z/Ab1YI/15zq3jW/xbjBg o/QTBCRp6RHK+kmDeWjy6Pc52JP/8Hq8mv994AAoHTlxtyEcR9MbPAubvfY42zjr 2BafY9WTev/79UiHEH9KA== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-transfer-encoding :content-type:date:date:feedback-id:feedback-id:from:from :in-reply-to:in-reply-to:message-id:mime-version:references :reply-to:sender:subject:subject:to:to:x-me-proxy:x-me-proxy :x-me-sender:x-me-sender:x-sasl-enc; s=fm2; t=1654708960; x= 1654795360; bh=UxhLP/sxB3MUIbGFbgDrsV5yQlYXLmfCXPnfops9pmg=; b=x ew9PIx4Re7Z7idsxOJ3RSeKp2iKnNjI8XkKQJUssqdjtarkXNB5KRgsigsN8wGbY 3TjsY2r6cn0CJ9bPYgUH4S6sFNZmMACnwXeNWozoOHyL1sI+ZGhNXJcTij6Mmp8u Y8JgSW1fuqGli4CSCuX67l962vTbahC41mb13TvbgOvIEntdoMdwWfKZAfW5CEWI 4y3h92yopfeY+C00jY0A8unE/nLxEK0Lt9TX8aeFImr/NtTIKOgKl/KCXMak/fdk lf5eW7PrsV9ppObgaEtGrgIF2qVHOaPO778TOSPhp+li1pLQF+iWZVjwF39EXh3d vJFLXhpcG+/EZO0dC7i2Q== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvfedruddtjedguddtjecutefuodetggdotefrod ftvfcurfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdpuffrtefokffrpgfnqfgh necuuegrihhlohhuthemuceftddtnecusecvtfgvtghiphhivghnthhsucdlqddutddtmd enucfjughrpefhvfevufffkfgjfhgggfgtsehtufertddttddvnecuhfhrohhmpefvhhho mhgrshcuofhonhhjrghlohhnuceothhhohhmrghssehmohhnjhgrlhhonhdrnhgvtheqne cuggftrfgrthhtvghrnheptdejieeifeehtdffgfdvleetueeffeehueejgfeuteeftddt ieekgfekudehtdfgnecuvehluhhsthgvrhfuihiivgeptdenucfrrghrrghmpehmrghilh hfrhhomhepthhhohhmrghssehmohhnjhgrlhhonhdrnhgvth X-ME-Proxy: Feedback-ID: i47234305:Fastmail Received: by mail.messagingengine.com (Postfix) with ESMTPA; Wed, 8 Jun 2022 13:22:38 -0400 (EDT) From: Thomas Monjalon To: Andrew Rybchenko , Spike Du Cc: Xiaoyun Li , Aman Singh , Yuying Zhang , Ferruh Yigit , Ray Kinsella , dev@dpdk.org Subject: Re: [PATCH v6] ethdev: introduce available Rx descriptors threshold Date: Wed, 08 Jun 2022 19:22:37 +0200 Message-ID: <1914507.usQuhbGJ8B@thomas> In-Reply-To: <20220608163528.1850326-1-andrew.rybchenko@oktetlabs.ru> References: <20220607125942.241379-1-spiked@nvidia.com> <20220608163528.1850326-1-andrew.rybchenko@oktetlabs.ru> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org 08/06/2022 18:35, Andrew Rybchenko: > From: Spike Du > > A new event RTE_ETH_EVENT_RX_AVAIL_THRESH should be generated by HW > when number of available descriptors in Rx queue goes below the > threshold. > > The threshold is defined as a percentage of an Rx queue size with valid > values from 0 to 99 (inclusive). Zero (default) value disables it. > > There is no capability reporting for the feature. Application should > simply try to set required threshold value and handle result. > > Add testpmd commands to control the threshold: > set port rxq avail_thresh > > Signed-off-by: Spike Du > Signed-off-by: Andrew Rybchenko > --- > v6: > - try to make descriptor shorter and more useful > - refine terminology to use "available descriptors threshold" > everywhere (plural "descriptors") > - fix ethdev API documenation > - define negative return values > - define rules to convert percentage to descriptors number > in drivers > - avoid extra checks in testpmd helper to allow ethdev API > to do its job > - minor fixes in testpmd variables naming > - fix testpmd help to be human oriented > - update testpmd users guide > - add release notes What a (more than) review work, thanks a lot for this v6! Acked-by: Thomas Monjalon With a few minor arrangements, applied, thanks.