From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id CB1E4A0549; Thu, 16 Jul 2020 14:50:13 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 7D35F1D404; Thu, 16 Jul 2020 14:50:13 +0200 (CEST) Received: from wout2-smtp.messagingengine.com (unknown [64.147.123.25]) by dpdk.org (Postfix) with ESMTP id 0D6C81D176 for ; Thu, 16 Jul 2020 14:50:11 +0200 (CEST) Received: from compute7.internal (compute7.nyi.internal [10.202.2.47]) by mailout.west.internal (Postfix) with ESMTP id F2632B53; Thu, 16 Jul 2020 08:50:01 -0400 (EDT) Received: from mailfrontend1 ([10.202.2.162]) by compute7.internal (MEProxy); Thu, 16 Jul 2020 08:50:02 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h= from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding:content-type; s=fm1; bh= V2kVAcUQqoeDKIacWvN5yqM7ebVLzaWStP8zqwHO/LI=; b=Otbi1idMwMVfWF9+ xZsew/rw5I8psc2i/uq3S8SHZaZK6mqIAt+gFSeojoIUXLqz1dcQLPIbCe+COOka kp7Kpsc9rsHipkaVMZv9s7Rzsd3XXG/6af0VdkkelRKinI+3wLJThT/P2OOEAnkq jmKAHR5ei5oMF9yqTCMlTiNhFbx9zMiZLX94+NacXZ6wqWbK6IjD7CKHWi9PQY/D yWLT9u4mjcRh1Q/fKPRGKE3VnF+e5GkKqXLqwSteCgY/6hJJg+/uyZHKJMSz51q2 2NzBRaBw3uC5r+up329vJ3mbxei7ZhhjyGk+4qxiWyqzuHkbpPtTGORbzOpdysyE GlG9LA== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-transfer-encoding:content-type :date:from:in-reply-to:message-id:mime-version:references :subject:to:x-me-proxy:x-me-proxy:x-me-sender:x-me-sender :x-sasl-enc; s=fm3; bh=V2kVAcUQqoeDKIacWvN5yqM7ebVLzaWStP8zqwHO/ LI=; b=QeAMx75jOTs2WZnfftAHJjEXc/EpJXOfpAR00P4HP3a9KC3cEmOLHchrt p0IYSelYOz0Bj+l6yj3NvT2kSdLk3MjX378n8Nc3zbDUkqKJN3vD10opTuHSG0uN LOWxGXsDj61/XlL6oYgAf1hbs+h6nNd9bV0vUFGnpzYy/OQtzximOJySpEgU1UQQ znN3mEiqRZ9MHbJMN9cL0a1pD3yQxWQR9mYTnC4GC1tbQlyU5MUhCuBp67Ujdd6X 2n+GHwy2zUVmIPxByFvXIrJPywxJwA689AKNSl+wQlpdLSBt4tjOIgwd33aDTrBK f0llG58WpMByV+94duzh8duApemsg== X-ME-Sender: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgeduiedrfeeggdehjecutefuodetggdotefrodftvf curfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdpuffrtefokffrpgfnqfghnecu uegrihhlohhuthemuceftddtnecusecvtfgvtghiphhivghnthhsucdlqddutddtmdenuc fjughrpefhvffufffkjghfggfgtgesthhqredttddtudenucfhrhhomhepvfhhohhmrghs ucfoohhnjhgrlhhonhcuoehthhhomhgrshesmhhonhhjrghlohhnrdhnvghtqeenucggtf frrghtthgvrhhnpeefgeffiefhfeettdfhvdfgteekffffudekvedtvedtvdfgveeuudev gedvgeegtdenucfkphepjeejrddufeegrddvtdefrddukeegnecuvehluhhsthgvrhfuih iivgeptdenucfrrghrrghmpehmrghilhhfrhhomhepthhhohhmrghssehmohhnjhgrlhho nhdrnhgvth X-ME-Proxy: Received: from xps.localnet (184.203.134.77.rev.sfr.net [77.134.203.184]) by mail.messagingengine.com (Postfix) with ESMTPA id 6DF08328005D; Thu, 16 Jul 2020 08:49:59 -0400 (EDT) From: Thomas Monjalon To: Jerin Jacob Cc: =?ISO-8859-1?Q?Ga=EBtan?= Rivet , Manish Chopra , Ferruh Yigit , Igor Russkikh , dpdk-dev Date: Thu, 16 Jul 2020 14:49:57 +0200 Message-ID: <1914663.Rf5fFZbPsG@thomas> In-Reply-To: References: <20200713151319.17547-2-manishc@marvell.com> <2902125.JAyrVFZy8S@thomas> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="iso-8859-1" Subject: Re: [dpdk-dev] [PATCH v2 1/7] lib/librte_pci: add rte_pci_regs.h X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" 16/07/2020 13:55, Jerin Jacob: > On Thu, Jul 16, 2020 at 4:57 PM Thomas Monjalon wro= te: > > > > 16/07/2020 12:27, Jerin Jacob: > > > On Thu, Jul 16, 2020 at 3:48 PM Ga=EBtan Rivet wrote: > > > > > > > > On 16/07/20 12:08 +0200, Ga=EBtan Rivet wrote: > > > > > Re-CCing dev@dpdk.org as it was removed from the reply. > > > > > > > > > > On 13/07/20 08:13 -0700, Manish Chopra wrote: > > > > > > This is merely copy of latest linux/pci_regs.h in > > > > > > order to avoid dependency of dpdk on user headers. > > > > > > > > > > > > > > > > I guess this dependency is an issue on non-linux systems, when yo= u must > > > > > use those defines in a generic implementation. Can you confirm th= is is > > > > > the motivation here? > > > > > > > > > > If so, I think it would be clearer to state "in order to avoid > > > > > dependency of DPDK on linux headers". > > > > > > > > > > > > > To add to it, if this is actually the motivation to add this header= , I > > > > don't think it is sufficient. > > > > > > > > You can restrict the function definition to the linux part of the > > > > PCI bus driver instead, using stubs for other systems. > > > > > > > > > > Signed-off-by: Manish Chopra > > > > > > Signed-off-by: Igor Russkikh > > > > > > --- > > > > > > drivers/bus/pci/linux/pci_uio.c | 2 +- > > > > > > drivers/bus/pci/linux/pci_vfio.c | 2 +- > > > > > > drivers/net/bnx2x/bnx2x.h | 2 +- > > > > > > drivers/net/hns3/hns3_ethdev_vf.c | 2 +- > > > > > > drivers/vdpa/ifc/base/ifcvf_osdep.h | 2 +- > > > > > > lib/librte_pci/Makefile | 1 + > > > > > > lib/librte_pci/meson.build | 2 +- > > > > > > lib/librte_pci/rte_pci_regs.h | 1075 +++++++++++++++++++= ++++++++ > > > > > > 8 files changed, 1082 insertions(+), 6 deletions(-) > > > > > > create mode 100644 lib/librte_pci/rte_pci_regs.h > > > > > > > > > > > > > > > > [...] > > > > > > > > > > > diff --git a/lib/librte_pci/rte_pci_regs.h b/lib/librte_pci/rte= _pci_regs.h > > > > > > new file mode 100644 > > > > > > index 000000000..1d11f4de5 > > > > > > --- /dev/null > > > > > > +++ b/lib/librte_pci/rte_pci_regs.h > > > > > > @@ -0,0 +1,1075 @@ > > > > > > +/* SPDX-License-Identifier: GPL-2.0 WITH Linux-syscall-note */ > > > > > > +/* > > > > > > > > > > This file is delivered alongside the PCI lib, targeting userspace. > > > > > This seems to be an exception to the license policy described in > > > > > license/README. Code shared between kernel and userspace is expec= ted > > > > > to be dual-licensed BSD-3 and GPL-2.0. > > > > > > > > > > As it is a copy of Linux user includes, re-licensing it as BSD-3 = as well > > > > > is not possible. > > > > > > > > > > So I think it might require a techboard + governing board excepti= on > > > > > approval. Ferruh or Thomas, what do you think? > > > > > > I think, instead of importing GPL-2.0 file, We can add the constants > > > as need by the DPDK > > > as symbols start from RTE_PCI_*(It will fix up the namespace as well). > > > > If symbols can be found in /usr/include/, don't add anything. >=20 > Not by default on all the distros. It is part of pciutils library. > Moreover, we need these symbols for Windows OS as well. > IMO, We should add absolute minimum constants that needed for DPDK as RTE= _PCI_* I am for mandating the dependency instead of copying it. pciutils cannot be installed on Windows? Why do you care about Windows? I don't see any contribution for qede on Windows.