From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <thomas.monjalon@6wind.com>
Received: from mail-wg0-f48.google.com (mail-wg0-f48.google.com [74.125.82.48])
 by dpdk.org (Postfix) with ESMTP id 987087E9F
 for <dev@dpdk.org>; Tue, 28 Oct 2014 14:19:34 +0100 (CET)
Received: by mail-wg0-f48.google.com with SMTP id m15so842996wgh.19
 for <dev@dpdk.org>; Tue, 28 Oct 2014 06:28:21 -0700 (PDT)
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=1e100.net; s=20130820;
 h=x-gm-message-state:from:to:cc:subject:date:message-id:organization
 :user-agent:in-reply-to:references:mime-version
 :content-transfer-encoding:content-type;
 bh=coupRSvVU0+hyB80Cq9Ycm+PzTZnAxVVcGorpO11ckc=;
 b=HpgwogfE6y2LYo8QH/Li/yjunuuvYFkU6ryMpmNgajDOUuEglI1Lhy+avefzsfyygc
 3t7Eocfy8b9LQYzO/379Q1KrMXzk3zviWmANGl/SLBf2CTSAdydPf9j/CaxpEhwZ2o/b
 KHVkr/bgO9awhuf0yD3pgbAa6NpEcNWOP8n4Gl2KzPj4leGeugPtJIBi9aJvYANf8Y4a
 Whm5rXi2XCL4s9ka4LK7q+I04LZsGA7lxHul7Ua/uDSydMC+Ixzo1sHZALzSbQugdYgL
 VSYwmOSZHOOzwpkL+UVoJFhHKTC9xp1n7Zsj4rtKN1aYVZcmkta2kWTda/nCGdiNrXVH
 hhUQ==
X-Gm-Message-State: ALoCoQksIoE1geZTzXYSkaHF4NcXRdGAGzjgAwrVnPF6JOBsIx/JO8dFA63SyLP/am3mruFJfpLk
X-Received: by 10.194.250.105 with SMTP id zb9mr3447030wjc.123.1414502901821; 
 Tue, 28 Oct 2014 06:28:21 -0700 (PDT)
Received: from xps13.localnet (136-92-190-109.dsl.ovh.fr. [109.190.92.136])
 by mx.google.com with ESMTPSA id gm9sm2215698wib.18.2014.10.28.06.28.20
 for <multiple recipients>
 (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128);
 Tue, 28 Oct 2014 06:28:21 -0700 (PDT)
From: Thomas Monjalon <thomas.monjalon@6wind.com>
To: Jingjing Wu <jingjing.wu@intel.com>
Date: Tue, 28 Oct 2014 14:28:03 +0100
Message-ID: <1914722.TcObfZY1uh@xps13>
Organization: 6WIND
User-Agent: KMail/4.14.2 (Linux/3.17.1-1-ARCH; KDE/4.14.2; x86_64; ; )
In-Reply-To: <1413939687-11177-9-git-send-email-jingjing.wu@intel.com>
References: <1411711418-12881-1-git-send-email-jingjing.wu@intel.com>
 <1413939687-11177-1-git-send-email-jingjing.wu@intel.com>
 <1413939687-11177-9-git-send-email-jingjing.wu@intel.com>
MIME-Version: 1.0
Content-Transfer-Encoding: 7Bit
Content-Type: text/plain; charset="us-ascii"
Cc: dev@dpdk.org
Subject: Re: [dpdk-dev] [PATCH v4 08/21] mbuf: extend fdir field
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: patches and discussions about DPDK <dev.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
X-List-Received-Date: Tue, 28 Oct 2014 13:19:34 -0000

2014-10-22 09:01, Jingjing Wu:
> extend fdir field to support flex bytes reported when fdir match

The commit log should explain why it is required (i40e?).
It will help to understand when digging into git history of mbuf file.

> --- a/lib/librte_mbuf/rte_mbuf.h
> +++ b/lib/librte_mbuf/rte_mbuf.h
> @@ -171,8 +173,14 @@ struct rte_mbuf {
>  	union {
>  		uint32_t rss;     /**< RSS hash result if RSS enabled */
>  		struct {
> -			uint16_t hash;
> -			uint16_t id;
> +			union {
> +				struct {
> +					uint16_t hash;
> +					uint16_t id;
> +				};
> +				uint32_t lo; /**< flexible bytes low*/
> +			};
> +			uint32_t hi;         /**< flexible bytes high*/
>  		} fdir;           /**< Filter identifier if FDIR enabled */

Please explain what could be the data of "flexible bytes high".

-- 
Thomas