Re: [dpdk-dev] [PATCH v9 3/4] examples: add l3fwd-thread example in performance-thread

[Thomas Monjalon <thomas.monjalon@6wind.com>]

2015-12-07 17:58, Ian Betts:
> --- a/MAINTAINERS
> +++ b/MAINTAINERS
> @@ -575,3 +575,10 @@ F: doc/guides/sample_app_ug/vmdq_dcb_forwarding.rst
>  M: Pablo de Lara <pablo.de.lara.guarch@intel.com>
>  M: Daniel Mrzyglod <danielx.t.mrzyglod@intel.com>
>  F: examples/ptpclient/
> +
> +M: Ian Betts <ian.betts@intel.com>
> +F: examples/performance-thread/
> +
> +M: Ian Betts <ian.betts@intel.com>
> +M: John McNamara <john.mcnamara@intel.com>
> +F: doc/guides/sample_app_ug/performance_thread.rst

Why doing 2 sections?
John is already the doc maintainer. You don't need to add him here.

> --- a/examples/Makefile
> +++ b/examples/Makefile
> @@ -77,5 +77,9 @@ DIRS-y += vmdq
>  DIRS-y += vmdq_dcb
>  DIRS-$(CONFIG_RTE_LIBRTE_POWER) += vm_power_manager
>  DIRS-$(CONFIG_RTE_LIBRTE_CRYPTODEV) += l2fwd-crypto
> -
> +ifneq ($(CONFIG_RTE_EXEC_ENV_LINUXAPP),)
> +ifneq ($(CONFIG_RTE_ARCH_X86_64),)
> +DIRS-y += performance-thread
> +endif
> +endif

Matter of taste, I would prefer DIRS-$(CONFIG_RTE_ARCH_X86_64)