From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <thomas.monjalon@6wind.com>
Received: from mail-we0-f172.google.com (mail-we0-f172.google.com
 [74.125.82.172]) by dpdk.org (Postfix) with ESMTP id 3CD73B0A4
 for <dev@dpdk.org>; Wed, 16 Apr 2014 13:40:20 +0200 (CEST)
Received: by mail-we0-f172.google.com with SMTP id t61so10810246wes.31
 for <dev@dpdk.org>; Wed, 16 Apr 2014 04:40:19 -0700 (PDT)
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=1e100.net; s=20130820;
 h=x-gm-message-state:from:to:cc:subject:date:message-id:organization
 :user-agent:in-reply-to:references:mime-version
 :content-transfer-encoding:content-type;
 bh=Sm0lkXpg4/4aqdlqUirIuoJEaN46PMPjqejcYTkbqdM=;
 b=CQ58SD5jcZaHet7tqFEn1CsiHJrpjgzYGz9sdUUJecPcVTl35Z3klGViWIeU5c/yla
 FBFDBST2tr3CQUfcP6d6VQFwz360ekNiqxqSeS2d8e3MnJQFsHQxQENCq3GNeoF/aPwf
 kb0pLqqZk3P15WWYuUCXlvneVztNZNmadsFm49uTjizn+33+FhIckwO9Y+RV7qel42xG
 2Q2QGUta4j9K14cySCsBj+oNIsMrNnNx/ZvbH6kNec9OdYYG6jtR4IraIIbIaMsg6Xo5
 AW/DHSof8izTpj2sIFCfnJHpDc1l5asAd7LJ9979r1XKHpkfvu065fAxI8kV0HAlv2Gc
 y34w==
X-Gm-Message-State: ALoCoQlYBlGqs3QekYPUu2NLE6SEC2+ttLbqvjYztnx/AnCWyrHkLRm2KSqeI13Qqn/lrKi+HgP2
X-Received: by 10.194.84.101 with SMTP id x5mr6603717wjy.52.1397648419568;
 Wed, 16 Apr 2014 04:40:19 -0700 (PDT)
Received: from xps13.localnet (6wind.net2.nerim.net. [213.41.180.237])
 by mx.google.com with ESMTPSA id b2sm35458429wiz.15.2014.04.16.04.40.18
 for <multiple recipients>
 (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128);
 Wed, 16 Apr 2014 04:40:18 -0700 (PDT)
From: Thomas Monjalon <thomas.monjalon@6wind.com>
To: Neil Horman <nhorman@tuxdriver.com>
Date: Wed, 16 Apr 2014 13:40:19 +0200
Message-ID: <1915373.2zxdALVbPM@xps13>
Organization: 6WIND
User-Agent: KMail/4.12.4 (Linux/3.14.1-1-ARCH; KDE/4.12.4; x86_64; ; )
In-Reply-To: <20140416110204.GC26829@hmsreliant.think-freely.org>
References: <1397585169-14537-1-git-send-email-nhorman@tuxdriver.com>
 <6240253.CLYuMHWmd2@xps13>
 <20140416110204.GC26829@hmsreliant.think-freely.org>
MIME-Version: 1.0
Content-Transfer-Encoding: 7Bit
Content-Type: text/plain; charset="us-ascii"
Cc: dev@dpdk.org
Subject: Re: [dpdk-dev] [PATCH 02/15] make: include whole archive on static
	link
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: patches and discussions about DPDK <dev.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
X-List-Received-Date: Wed, 16 Apr 2014 11:40:20 -0000

2014-04-16 07:02, Neil Horman:
> On Wed, Apr 16, 2014 at 11:26:48AM +0200, Thomas Monjalon wrote:
> > 2014-04-15 14:05, Neil Horman:
> > > This happens automatically on dyanmic linking, but when linking an
> > > archive
> > > we need to to include the whole archive to make sure we call all the
> > > constructors. Not doing this causes them to be discarded due to the fact
> > > theres no symbolic reference connecting the pmds to the application.
> > > 
> > > Signed-off-by: Neil Horman <nhorman@tuxdriver.com>
> > 
> > This patch conflicts with Olivier's one:
> > 	http://dpdk.org/browse/dpdk/commit/?id=20afd76a504155e947
> 
> How does it conflict?  I've got it in my dpdk tree here, based off commit
> 396b69e56a3462ff80537deccebcdecb2771d8ca, which includes Oliviers patch, and
> mine is applied on top of it cleanly.

It's not a git conflict.
I mean --whole-archive is set twice.
Maybe that your patch is not needed.

-- 
Thomas