From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-wm0-f46.google.com (mail-wm0-f46.google.com [74.125.82.46]) by dpdk.org (Postfix) with ESMTP id 830F529D6 for ; Wed, 2 Mar 2016 22:55:52 +0100 (CET) Received: by mail-wm0-f46.google.com with SMTP id n186so106130785wmn.1 for ; Wed, 02 Mar 2016 13:55:52 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=6wind-com.20150623.gappssmtp.com; s=20150623; h=from:to:cc:subject:date:message-id:organization:user-agent :in-reply-to:references:mime-version:content-transfer-encoding; bh=KIXbFZGQ0K/rSKSg+Fuge3GWW0n1YJoU2ewghvlnCGM=; b=sntHAXXSjU6I0+qa9nbrvd7y1jxihH+ZVWJbgRiY/E8+5tqnEdDgLkphMsvh/J0JYZ spjnopBQGiE9f2msl6N/2G1/2GnpQIkIYKh6cBFbjQG+0DxXyoljfYHE7Pa8nCUHV5B8 c/7lDcTwn7U/gMzUG9cLBiY2oEVOv71bZHrLlQU7XharKrW0GzKPSw4rCR2k6TSbD+Mh wgRVjO9/fd1huTxbCM2Ok9b1mJyct9kQpYy91dJSO9+D/l21XUoUOzYX1i3zyLUklRle zBi+2B8wgGPH75zknOfsDuHKbgjxkwli6BBdj2Rig+yt25rVVFuC3MCgM1/SI/eehq/L BTCw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:from:to:cc:subject:date:message-id:organization :user-agent:in-reply-to:references:mime-version :content-transfer-encoding; bh=KIXbFZGQ0K/rSKSg+Fuge3GWW0n1YJoU2ewghvlnCGM=; b=ao9kitc49gy7EJvKELlPFvbG8Wg5qPT95H0qOhkGeRQ308CRkSMCs3RVW/3Pwo5Edj 3Q7Ow3lmPDwqpQVXD/vOq6o+i7BxpE5XT2jBaXJCsiaO1BX49gsLazIYM+d5sWmrEYlO t7PEwceXu6OStTwGHk5yFj/dO0ks4IoF+Cnb3QdordoEKHJv6GQ84+zj57HNt3Qir0YP 7p5u35U1jOgm8/WVg2W8wNJRcTM2o36OUWqa+aXQ9j7J+1Z6g/zq6zNtJwuh6JLOMKjh 6KbjSoUU7w4el9A8K3LONgWbZe6pMP0r7cyLZFt4/uzGajq6IE+QvcfG4T9/8PWd/egS jthQ== X-Gm-Message-State: AD7BkJJ1YP+WNYf1yzM5/ueS4cl7jfhj6nAJ2XRZwfTZyM2veErcti4saFV/G6quxb7ym73a X-Received: by 10.194.120.99 with SMTP id lb3mr34573483wjb.59.1456955752329; Wed, 02 Mar 2016 13:55:52 -0800 (PST) Received: from xps13.localnet ([93.158.56.12]) by smtp.gmail.com with ESMTPSA id p125sm6042456wmd.16.2016.03.02.13.55.51 (version=TLSv1/SSLv3 cipher=OTHER); Wed, 02 Mar 2016 13:55:51 -0800 (PST) From: Thomas Monjalon To: Stephen Hurd Date: Wed, 02 Mar 2016 22:54:15 +0100 Message-ID: <1915798.D06pWLxedU@xps13> Organization: 6WIND User-Agent: KMail/4.14.10 (Linux/4.1.6-1-ARCH; KDE/4.14.11; x86_64; ; ) In-Reply-To: References: <20160302082450.6f64cf8e@xeon-e3> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Cc: dev@dpdk.org Subject: Re: [dpdk-dev] New driver (large patch) question. X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 02 Mar 2016 21:55:52 -0000 2016-03-02 13:30, Stephen Hurd: > The bulk of the patch is the hardware interface header file. With all the > comments, it weighs in around 800k. If I strip the comments, it's around > 300k. If I both strip all the comments and remove all the currently unused > structures, I can get the entire patch down just below 300k, but that makes > it much harder for someone to do further development. I'm willing to do > that though if it's what's preferred. > > The other large file (560k) is just a bunch of extra debug output that > makes it easier to debug issues. It's normally not compiled, so it sounds > like it's not wanted either. If the code is not needed, it's obviously better to not submit it :) > I'll submit without comments in the hardware interface file and take it > from there. I don't think removing the comments is a good option. Please try to split per-feature to make it readable. You can check how fm10k was introduced as an example: http://thread.gmane.org/gmane.comp.networking.dpdk.devel/13447 or mlx5: http://thread.gmane.org/gmane.comp.networking.dpdk.devel/26986