From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <thomas.monjalon@6wind.com>
Received: from mail-we0-f175.google.com (mail-we0-f175.google.com
 [74.125.82.175]) by dpdk.org (Postfix) with ESMTP id 8E7D86A89
 for <dev@dpdk.org>; Tue, 30 Sep 2014 07:01:07 +0200 (CEST)
Received: by mail-we0-f175.google.com with SMTP id q59so3087945wes.34
 for <dev@dpdk.org>; Mon, 29 Sep 2014 22:07:46 -0700 (PDT)
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=1e100.net; s=20130820;
 h=x-gm-message-state:from:to:cc:subject:date:message-id:organization
 :user-agent:in-reply-to:references:mime-version
 :content-transfer-encoding:content-type;
 bh=L6KpT20BCjBonJUJH1bkF5evGUL9bwkI4a5G7pvsk/o=;
 b=Qi82nt5zAitEXvVjC9HDWkegUctYK0reITNzXr6Bl0ukHFnQNjsruQfmFjkj8F0h+L
 xXVZe7YFoAIb/t33QxJ6y7/VEG8XXgC5bB4uMjIC5LJbPF+n+kBEkQModPe9OlnMOSyQ
 LO3mqsL/JhxYpA/rnQBgQbHT54BbG3YvojFdw561k8ACKdEA5FHODRj+0oIl3OjnVz8P
 kSxN2k1g2SfY5GnFisztTQbfSTUHgK4Z2j7HwBiaw9f4IRKFDTWmuNmIS2zqTZ6+uT/g
 jgHu3gGC14dlVAi8zpUdRohY1ecLU1yd0sJdeyUzSxgtPBhg3J19UCReEM36s4KE0TgS
 ozFQ==
X-Gm-Message-State: ALoCoQllzo3ibMX7PqVe1MQsZIAYQmLFxGIMGbv3yEBLEwmfaCnTPOyE8KPYrHm3zpx3ISgzvG51
X-Received: by 10.194.186.239 with SMTP id fn15mr310431wjc.129.1412053666571; 
 Mon, 29 Sep 2014 22:07:46 -0700 (PDT)
Received: from xps13.localnet (14.21.90.92.rev.sfr.net. [92.90.21.14])
 by mx.google.com with ESMTPSA id d6sm6646088wiz.0.2014.09.29.22.07.45
 for <multiple recipients>
 (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128);
 Mon, 29 Sep 2014 22:07:45 -0700 (PDT)
From: Thomas Monjalon <thomas.monjalon@6wind.com>
To: Jingjing Wu <jingjing.wu@intel.com>
Date: Tue, 30 Sep 2014 07:07:33 +0200
Message-ID: <1916931.VRG6JyPOdY@xps13>
Organization: 6WIND
User-Agent: KMail/4.13.3 (Linux/3.15.8-1-ARCH; KDE/4.13.3; x86_64; ; )
In-Reply-To: <1412045348-18543-1-git-send-email-jingjing.wu@intel.com>
References: <1412045348-18543-1-git-send-email-jingjing.wu@intel.com>
MIME-Version: 1.0
Content-Transfer-Encoding: 7Bit
Content-Type: text/plain; charset="us-ascii"
Cc: dev@dpdk.org
Subject: Re: [dpdk-dev] [PATCH] llib/ibrte_net: workaround to avoid macro
	conflict
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: patches and discussions about DPDK <dev.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
X-List-Received-Date: Tue, 30 Sep 2014 05:01:07 -0000

Hi Jingjing,

2014-09-30 10:49, Jingjing Wu:
> Macros such as IPPROTO_TCP, IPPROTO_UDP are already defined in <netinet/in.h>.
> If user's application includes <netinet/in.h> and rte_ip.h at the same time,
> there will be conflict error.
> 
> This patch uses the way "#ifndef #endif" to avoid the conflict. 

I still think it is not the good approach.
	see http://dpdk.org/ml/archives/dev/2014-August/005006.html
	and http://dpdk.org/ml/archives/dev/2014-August/005026.html
Why not simply remove these definitions?

-- 
Thomas