From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-wg0-f42.google.com (mail-wg0-f42.google.com [74.125.82.42]) by dpdk.org (Postfix) with ESMTP id EB2B46A95 for ; Thu, 11 Dec 2014 01:47:13 +0100 (CET) Received: by mail-wg0-f42.google.com with SMTP id z12so5129440wgg.29 for ; Wed, 10 Dec 2014 16:47:13 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:from:to:cc:subject:date:message-id:organization :user-agent:in-reply-to:references:mime-version :content-transfer-encoding:content-type; bh=3H+O9IpYxPaMTcVj8Cuf40q9i2yOZ1mtO2w7zOQaxjQ=; b=RWLPgCoSMXl72LquULo6Y/Uc/os8IV/ZVv+pmEvZMjsXFzG+zLxmiZkO3vnwl+JmCY Wq9HZlVGNGmuIs255OB8JJAv+qHG9bzQu8dgGVn8ipIrn2oulgehbgMiOFjx2f6oVsHc lANytaIyH0eOe0pKQt2D4eF6/gzVdX47dqgZ0DH91g1eS/QXM2o9ageuDLl7MG5nTaMd jXvrczRBHWA3onbWbWgoz0zrLUXVW1xTHTDgJGH8fG0WvEe/hMJQY2zLk7WThDhG3m+u ftD4fOOqaA7IcPBZ8bqxW102nVrBBsOCSL0ncdnArd/kdmrJ1SC+DMUvw98Vi3TZfKOf Xf7w== X-Gm-Message-State: ALoCoQkVqp7NzZJAiWS5+PKwj6Km0T+sV8pQzMxOmNEEkF19M5Hm0qQYmIqRYgimxrNhmx9geEPq X-Received: by 10.180.72.199 with SMTP id f7mr10897342wiv.53.1418258833828; Wed, 10 Dec 2014 16:47:13 -0800 (PST) Received: from xps13.localnet ([88.249.222.12]) by mx.google.com with ESMTPSA id be4sm746341wib.16.2014.12.10.16.47.12 for (version=TLSv1 cipher=ECDHE-RSA-RC4-SHA bits=128/128); Wed, 10 Dec 2014 16:47:13 -0800 (PST) From: Thomas Monjalon To: Hiroshi Shimamoto Date: Thu, 11 Dec 2014 01:46:36 +0100 Message-ID: <1917406.222ZYZX27x@xps13> Organization: 6WIND User-Agent: KMail/4.14.3 (Linux/3.17.4-1-ARCH; KDE/4.14.3; x86_64; ; ) In-Reply-To: <7F861DC0615E0C47A872E6F3C5FCDDBD05DD32B1@BPXM14GP.gisp.nec.co.jp> References: <7F861DC0615E0C47A872E6F3C5FCDDBD05DCB8C6@BPXM14GP.gisp.nec.co.jp> <20141208150154.GA3907@localhost.localdomain> <7F861DC0615E0C47A872E6F3C5FCDDBD05DD32B1@BPXM14GP.gisp.nec.co.jp> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Cc: dev@dpdk.org, Hayato Momma Subject: Re: [dpdk-dev] mk: fix LDFLAGS for shared lib X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 11 Dec 2014 00:47:14 -0000 2014-12-08 23:44, Hiroshi Shimamoto: > > On Wed, Dec 03, 2014 at 11:33:54PM +0000, Hiroshi Shimamoto wrote: > > > From: Hiroshi Shimamoto > > > > > > Only CPU_LDFLAGS is used in mk/rte.sharelib.mk. > > > It should be LDFLAGS to build the library with correct linkage options. > > > > > > Signed-off-by: Hiroshi Shimamoto > > > Reviewed-by: Hayato Momma > > > > > > --- > > > mk/rte.sharelib.mk | 2 +- > > > 1 file changed, 1 insertion(+), 1 deletion(-) > > > > > > diff --git a/mk/rte.sharelib.mk b/mk/rte.sharelib.mk > > > index c0a811a..df6c268 100644 > > > --- a/mk/rte.sharelib.mk > > > +++ b/mk/rte.sharelib.mk > > > @@ -45,7 +45,7 @@ sharelib: $(LIB_ONE) FORCE > > > > > > OBJS = $(wildcard $(RTE_OUTPUT)/build/lib/*.o) > > > > > > -O_TO_S = $(LD) $(CPU_LDFLAGS) -shared $(OBJS) -o $(RTE_OUTPUT)/lib/$(LIB_ONE) > > > +O_TO_S = $(LD) $(LDFLAGS) -shared $(OBJS) -o $(RTE_OUTPUT)/lib/$(LIB_ONE) > > > O_TO_S_STR = $(subst ','\'',$(O_TO_S)) #'# fix syntax highlight > > > O_TO_S_DISP = $(if $(V),"$(O_TO_S_STR)"," LD $(@)") > > > O_TO_S_CMD = "cmd_$@ = $(O_TO_S_STR)" > > > > Does this continue to work on cross compiled arches (32 bit on 64 bit systems > > and vice versa)? I have this recollection that something in CPU_LDFLAGS was > > needed > > yes, LDFLAGS must contain CPU_LDFLAGS. > > mk/target/generic/rte.vars.mk:# merge all LDFLAGS > mk/target/generic/rte.vars.mk:LDFLAGS := $(CPU_LDFLAGS) $(EXECENV_LDFLAGS) $(TOOLCHAIN_LDFLAGS) $(MACHINE_LDFLAGS) > mk/target/generic/rte.vars.mk:LDFLAGS += $(TARGET_LDFLAGS) Applied Thanks -- Thomas