From: Thomas Monjalon <thomas.monjalon@6wind.com>
To: Stephen Hemminger <stephen@networkplumber.org>
Cc: dev@dpdk.org, Stephen Hemminger <shemming@brocade.com>
Subject: Re: [dpdk-dev] [PATCH 4/5] igb_uio: fix IRQ mode handling
Date: Thu, 22 May 2014 15:50:58 +0200 [thread overview]
Message-ID: <19189491.dUSBC7Ojvo@xps13> (raw)
In-Reply-To: <20140514163510.727992614@networkplumber.org>
Hi Stephen,
2014-05-14 09:34, Stephen Hemminger:
> The igb_uio driver does not handle interrupt mode correctly.
> It doesn't do the right thing and start with the most desired
> mode and fall back to legacy modes as needed.
I'm not sure to understand what you describe.
> It also has a custom pci config lock was broken for any recent kernels.
> Instead pci_intx functions that provide the needed access.
I think some words are missing here.
> VMWare PCI emulation of interrupts is particularly broken.
> E1000 on VMWare doesn't work at all because INTX support
> in ESX doesn't really work. The kernel pci_intx routines check
> this and detect the failure. To handle this case fallback
> to an even more legacy mode using irq enable/disable.
Is it possible to split this patch for each issue?
Thanks
--
Thomas
next prev parent reply other threads:[~2014-05-22 13:50 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-05-14 16:34 [dpdk-dev] [PATCH 0/5] igb_uio patches Stephen Hemminger
2014-05-14 16:34 ` [dpdk-dev] [PATCH 1/5] igb_uio: use kernel standard log message Stephen Hemminger
2014-05-14 16:34 ` [dpdk-dev] [PATCH 2/5] igb_uio: use standard uio naming Stephen Hemminger
2014-05-14 16:34 ` [dpdk-dev] [PATCH 3/5] igb_uio: mark module param read/only Stephen Hemminger
2014-05-14 16:34 ` [dpdk-dev] [PATCH 4/5] igb_uio: fix IRQ mode handling Stephen Hemminger
2014-05-22 13:50 ` Thomas Monjalon [this message]
2014-05-14 16:34 ` [dpdk-dev] [PATCH 5/5] igb_uio: fix checkpatch warnings Stephen Hemminger
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=19189491.dUSBC7Ojvo@xps13 \
--to=thomas.monjalon@6wind.com \
--cc=dev@dpdk.org \
--cc=shemming@brocade.com \
--cc=stephen@networkplumber.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).