From: Thomas Monjalon <thomas@monjalon.net>
To: David Hunt <david.hunt@intel.com>
Cc: dev@dpdk.org, john.mcnamara@intel.com, marko.kovacevic@intel.com
Subject: Re: [dpdk-dev] [PATCH] doc/power: fix references in power management
Date: Thu, 17 Jan 2019 19:51:25 +0100 [thread overview]
Message-ID: <1919587.yrck2HIdBR@xps> (raw)
In-Reply-To: <20190115133835.52147-1-david.hunt@intel.com>
15/01/2019 14:38, David Hunt:
> In the References section in the Power Management overview,
> both links pointed to the same l3fwd-power app. Fix the links
> so that one points to l3fwd-power, and the other points to
> the vm_power_manager sample app.
>
> Signed-off-by: David Hunt <david.hunt@intel.com>
> ---
> doc/guides/prog_guide/power_man.rst | 6 ++++--
> 1 file changed, 4 insertions(+), 2 deletions(-)
>
> diff --git a/doc/guides/prog_guide/power_man.rst b/doc/guides/prog_guide/power_man.rst
> index f55436bc9..8f23f7958 100644
> --- a/doc/guides/prog_guide/power_man.rst
> +++ b/doc/guides/prog_guide/power_man.rst
> @@ -195,6 +195,8 @@ The mechanism can applied to any device which is based on polling. e.g. NIC, FPG
> References
> ----------
>
> -* l3fwd-power: The sample application in DPDK that performs L3 forwarding with power management.
> +* The :doc:`L3 Forwarding with Power Management Sample Application<../sample_app_ug/l3_forward_power_man>`
> + chapter in the :doc:`Sample Applications User Guides<../sample_app_ug/index>` section.
>
> -* The "L3 Forwarding with Power Management Sample Application" chapter in the *DPDK Sample Application's User Guide*.
> +* The :doc:`VM Power Management Application<../sample_app_ug/vm_power_management>`
> + chapter in the :doc:`Sample Applications User Guides<../sample_app_ug/index>` section.
These are complex references. You don't need to specifiy the title,
it is automatically generated.
Marko, please take care of not making the doc more complex in your review.
In your patch "doc: add new introduction to sample app guides",
you did the same as above.
Dave, when in doubt, please check at what is already in the tree:
git grep :doc:
About the title, we don't use doc/power:
git log --oneline --reverse doc/guides/prog_guide/power_man.rst
next prev parent reply other threads:[~2019-01-17 18:51 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-01-15 13:38 David Hunt
2019-01-17 10:50 ` Kovacevic, Marko
2019-01-17 18:51 ` Thomas Monjalon [this message]
2019-01-18 12:15 ` Mcnamara, John
2019-01-18 14:31 ` Thomas Monjalon
2019-01-18 9:34 ` [dpdk-dev] [PATCH v2] doc: fix references in power management guide David Hunt
2019-01-20 12:26 ` Thomas Monjalon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1919587.yrck2HIdBR@xps \
--to=thomas@monjalon.net \
--cc=david.hunt@intel.com \
--cc=dev@dpdk.org \
--cc=john.mcnamara@intel.com \
--cc=marko.kovacevic@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).