From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 91CE5A0A02; Mon, 5 Apr 2021 21:01:20 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 1E5464068C; Mon, 5 Apr 2021 21:01:20 +0200 (CEST) Received: from out2-smtp.messagingengine.com (out2-smtp.messagingengine.com [66.111.4.26]) by mails.dpdk.org (Postfix) with ESMTP id E83E04014E; Mon, 5 Apr 2021 21:01:18 +0200 (CEST) Received: from compute2.internal (compute2.nyi.internal [10.202.2.42]) by mailout.nyi.internal (Postfix) with ESMTP id 34ADC5C0060; Mon, 5 Apr 2021 15:01:18 -0400 (EDT) Received: from mailfrontend2 ([10.202.2.163]) by compute2.internal (MEProxy); Mon, 05 Apr 2021 15:01:18 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h= from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding:content-type; s=fm3; bh= lvyA+94Q8/iaaW/RCXLaU3zJotMrLB5eai+7ySAT8xI=; b=CLq7PIgIaHe7uNEn QWlIEhoVdVPDGLPd/7Fa+E6b85tgiWIIIfitNNSslOFPkvKOO+40I7zfkMXiOfGj ExycooxK8FjnjCkKzOvKfKWxXZoZCPCvzDdSwv+58ueW5Lx/0kmCOpvK3uLuIX6N mVt2s90aJFHBT36Bq4nbbR6RmKGCC9kDTXtHsHZZOGqHzf2dneiBKKLFdO9NDhHa Rfp0T0Ly3LWEzVLiS+T27HbLTzXHRgnwpkBDA3gZdUyuzRYCFtfRCl7jKFRl3HxE PhpC5LVkSHyNMNn81gdXchkOro1aXT6JQURk27+zdbGbzPg8sRKtP4XP3Ql4oIHx 46aixg== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-transfer-encoding:content-type :date:from:in-reply-to:message-id:mime-version:references :subject:to:x-me-proxy:x-me-proxy:x-me-sender:x-me-sender :x-sasl-enc; s=fm2; bh=lvyA+94Q8/iaaW/RCXLaU3zJotMrLB5eai+7ySAT8 xI=; b=c4zVUPKE0MhP8UVVnrD9OP09rwlUHWLSeMgKsPN3+VQPjGrS2ca61iR/s 3z0yzFv8S3XDWjJMu4TwzgIuuVel60E5AO00R8GmewPIne539ExEWQ+BFfUPdzqC 0BH0Z7zcTEHKY5WTYMnzXQ/njbn7AjnX0QQo5QmeE/iofWmuXUaP/uedjO4U7GDO fV1mLohNHyrqUUTY1/bgu/jagxrkP7Syy5HKAXMp4GSxcV3LFb7SCQUtptcH6Cym sYSbv4y/pULPsm0iyY0f+6UCJHrZ+ALmVkzBsXZUSQNmtXufoA2wsfbNq0dAJe98 lilfC2FPdwYDQH9i4Tv+zVlcgRxxg== X-ME-Sender: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgeduledrudejvddgudeffecutefuodetggdotefrod ftvfcurfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdpuffrtefokffrpgfnqfgh necuuegrihhlohhuthemuceftddtnecusecvtfgvtghiphhivghnthhsucdlqddutddtmd enucfjughrpefhvffufffkjghfggfgtgesthfuredttddtvdenucfhrhhomhepvfhhohhm rghsucfoohhnjhgrlhhonhcuoehthhhomhgrshesmhhonhhjrghlohhnrdhnvghtqeenuc ggtffrrghtthgvrhhnpedugefgvdefudfftdefgeelgffhueekgfffhfeujedtteeutdej ueeiiedvffegheenucfkphepjeejrddufeegrddvtdefrddukeegnecuvehluhhsthgvrh fuihiivgeptdenucfrrghrrghmpehmrghilhhfrhhomhepthhhohhmrghssehmohhnjhgr lhhonhdrnhgvth X-ME-Proxy: Received: from xps.localnet (184.203.134.77.rev.sfr.net [77.134.203.184]) by mail.messagingengine.com (Postfix) with ESMTPA id F341F108005F; Mon, 5 Apr 2021 15:01:16 -0400 (EDT) From: Thomas Monjalon To: Tal Shnaiderman Cc: dev@dpdk.org, matan@nvidia.com, rasland@nvidia.com, ophirmu@nvidia.com, stable@dpdk.org Date: Mon, 05 Apr 2021 21:01:14 +0200 Message-ID: <1920198.nUkcdjmOzk@thomas> In-Reply-To: <20210405161844.9560-1-talshn@nvidia.com> References: <20210405161844.9560-1-talshn@nvidia.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Subject: Re: [dpdk-dev] [PATCH] net/mlx5/windows: fix link speed calculation X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" There is no previous commit with net/mlx5/windows as title prefix. In general, there is "on Windows" at the end of the title. This way we can have the same formatting when fixing the common code for a Windows case. 05/04/2021 18:18, Tal Shnaiderman: > In Windows DevX returns the value of the current link speed > in bps rate, the conversion to the Mbps rate expected by DPDK > is incorrect and fixed. "was" incorrect. I think you should explain the confusion between Mbit/s and Mibit/s. > - dev_link.link_speed = context_obj->mlx5_dev.link_speed / (1024 * 1024); > + dev_link.link_speed = context_obj->mlx5_dev.link_speed / (1000 * 1000);