From mboxrd@z Thu Jan 1 00:00:00 1970
Return-Path: <thomas@monjalon.net>
Received: from out4-smtp.messagingengine.com (out4-smtp.messagingengine.com
[66.111.4.28]) by dpdk.org (Postfix) with ESMTP id EA8601C4A;
Fri, 5 May 2017 15:55:12 +0200 (CEST)
Received: from compute1.internal (compute1.nyi.internal [10.202.2.41])
by mailout.nyi.internal (Postfix) with ESMTP id 93E2020A04;
Fri, 5 May 2017 09:55:12 -0400 (EDT)
Received: from frontend1 ([10.202.2.160])
by compute1.internal (MEProxy); Fri, 05 May 2017 09:55:12 -0400
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h=
cc:content-transfer-encoding:content-type:date:from:in-reply-to
:message-id:mime-version:references:subject:to:x-me-sender
:x-me-sender:x-sasl-enc:x-sasl-enc; s=mesmtp; bh=arQiNXVnt66prPC
rB7Qdh3PP0jZCRgrlM5AQpDJSd2E=; b=mK7kn4iNnehzBnbYb8YLQz4BbBV6k9Q
8WBpdT+zTmKmfW8Z+P6xRUr1zsMlB51iNpzp4kWHPMBEvNdufpkZYUxwl5hUBOn3
wbvCIs0yZyCJ6maK5GuPOHAD1gXU0Agdc0KkYs0ucmVoKtid8s8sEw+SnrmHx7TK
p4qrs3l0cgIA=
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=
messagingengine.com; h=cc:content-transfer-encoding:content-type
:date:from:in-reply-to:message-id:mime-version:references
:subject:to:x-me-sender:x-me-sender:x-sasl-enc:x-sasl-enc; s=
fm1; bh=arQiNXVnt66prPCrB7Qdh3PP0jZCRgrlM5AQpDJSd2E=; b=L0Ndhc6W
QxjLqfv+GOh+afqIMDQsD3fzorW34HlQya1qku+TmjtaHQ0WKiphqIcLe0Ao9tbL
cRITFLOOPD0jzdcNDEJP/NZER6OyV0PECFRn8fwTI+we50bCzEo4LaIwSYi8Amac
BBkUdBe6Iy5duwz861yR8A8CP4/mgLrdQgZD/BTlXb85YKJpalr5jGlgQwEEbBjn
ix1hzpcT2QUDTa4Y0TU+BXvVLLNN9AC5B8eNn4isBASZW1nY0YAycjHDT4s+O6n1
7kF+zqp8EpQ/MxP7IwlP0CaDdcOTXF3WN89CZJxyqOwhDre+awnMHHGtRY6Nxw1S
OLuVk1b1l6C/lQ==
X-ME-Sender: <xms:QIQMWVlpKFjcgNMcvS_WE1QYJOjEwPry2hDQDGLH9QYIlZg83q43eQ>
X-Sasl-enc: /u5mJPdQRtI7Guf5GUd9LIMr+m2VEqIp7GuoC1hmCT7y 1493992512
Received: from xps.localnet (184.203.134.77.rev.sfr.net [77.134.203.184])
by mail.messagingengine.com (Postfix) with ESMTPA id 52A427E320;
Fri, 5 May 2017 09:55:12 -0400 (EDT)
From: Thomas Monjalon <thomas@monjalon.net>
To: Ferruh Yigit <ferruh.yigit@intel.com>
Cc: dev@dpdk.org, stable@dpdk.org
Date: Fri, 05 May 2017 15:55:11 +0200
Message-ID: <1925837.mma5Bi0xzW@xps>
In-Reply-To: <20170503161037.3763-1-ferruh.yigit@intel.com>
References: <20170503161037.3763-1-ferruh.yigit@intel.com>
MIME-Version: 1.0
Content-Transfer-Encoding: 7Bit
Content-Type: text/plain; charset="us-ascii"
Subject: Re: [dpdk-dev] [PATCH] kni: fix unit test segfault
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/dev>,
<mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/dev>,
<mailto:dev-request@dpdk.org?subject=subscribe>
X-List-Received-Date: Fri, 05 May 2017 13:55:13 -0000
03/05/2017 18:10, Ferruh Yigit:
> To clean alloc_q, which has physicall addresses of the mbufs, kni lib
> free the pkt_mempool, but this leads a crash in kni unit test.
>
> KNI library shouldn't free the pkt_mempool.
>
> Implementation updated to find the mbufs in the alloc_q and return them
> back to mempool.
>
> Fixes: 8eba5ebd1811 ("kni: fix possible memory leak")
>
> Signed-off-by: Ferruh Yigit <ferruh.yigit@intel.com>
Cc: stable@dpdk.org
Applied, thanks