From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from out1-smtp.messagingengine.com (out1-smtp.messagingengine.com [66.111.4.25]) by dpdk.org (Postfix) with ESMTP id 67B27235 for ; Tue, 24 Jul 2018 14:33:54 +0200 (CEST) Received: from compute1.internal (compute1.nyi.internal [10.202.2.41]) by mailout.nyi.internal (Postfix) with ESMTP id C4D8021BBE; Tue, 24 Jul 2018 08:33:53 -0400 (EDT) Received: from mailfrontend1 ([10.202.2.162]) by compute1.internal (MEProxy); Tue, 24 Jul 2018 08:33:53 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to:x-me-sender :x-me-sender:x-sasl-enc; s=mesmtp; bh=zB5CRhUDB1TaQzYTHXui+x7Xuy vF1kJDKvLkNBhNfY8=; b=rXgwci5T9owJ3LTNA2G+eZbWLY/QMJvJyBrIfW+ghE I+tsXX8lD+X69KIoXjYXxoOB+xZoDsekbXT41tOW/6QtVKUp4FVnjFW3UfrR/OiE t0LxAZoWRHLEZl9QaXsrET0d2eLweloigjU+qU5yZthnT3x6P7iUI/FquZwD0Kaj 8= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-transfer-encoding:content-type :date:from:in-reply-to:message-id:mime-version:references :subject:to:x-me-sender:x-me-sender:x-sasl-enc; s=fm3; bh=zB5CRh UDB1TaQzYTHXui+x7XuyvF1kJDKvLkNBhNfY8=; b=d7Ms0tGxOg1LQib1mWonvE wdrlVjMhw2VW0kDwW6ledmOEkt+ltXVamcKleRghYMGWtZAyV3vtQdJtCGCxkkOJ eNfD2zxrhgd0ZodDgkSC4v4HE93M7I0H1wYQGDVNxQZVL0/Qu+UUIMZTwEpZ2DuP njlD9hrVeQKS0QU1/9YoLnzrU2BFAUxDDuZxfEVTWdi6GCXfCukXpLM59AYGRZG1 TLEBMqRU6fTwz4wJicJZSBphqVvtE8CRBxBMuCarDBf4DqOJqn+8g8AQWkbrkxdm LDxrvOdD4CovMdiSG/arpCdqyFcnvIXe1O1umDKiZMM6yh8nxMhHzR0bbtAI/dHA == X-ME-Proxy: X-ME-Sender: Received: from xps.localnet (184.203.134.77.rev.sfr.net [77.134.203.184]) by mail.messagingengine.com (Postfix) with ESMTPA id CC2C1E4627; Tue, 24 Jul 2018 08:33:51 -0400 (EDT) From: Thomas Monjalon To: Jasvinder Singh Cc: dev@dpdk.org, bernard.iremonger@intel.com, reshma.pattan@intel.com, motih@mellanox.com, olivier.matz@6wind.com, cristian.dumitrescu@intel.com Date: Tue, 24 Jul 2018 14:33:47 +0200 Message-ID: <1925999.Zqez9Xlb98@xps> In-Reply-To: <1876510.4y0gDTZx5Q@xps> References: <20180723104425.10090-1-jasvinder.singh@intel.com> <1876510.4y0gDTZx5Q@xps> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Subject: Re: [dpdk-dev] [PATCH] app/testpmd: fix testpmd exit using ctrl+d X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 24 Jul 2018 12:33:54 -0000 Important note: testpmd is currently really broken. We cannot have a RC2 until it is fixed. 24/07/2018 13:25, Thomas Monjalon: > 23/07/2018 12:44, Jasvinder Singh: > > Fix testpmd app exit by pressing ctrl+d, End-of-Transmission character (EOT) > > on the empty command line. > > Please describe what is the issue and what is the cause. > > > Fixes: 0ad778b398c6 ("app/testpmd: rework softnic forward mode") > > > > Reported-by: Mordechay Haimovsky > > Signed-off-by: Jasvinder Singh > > --- > > app/test-pmd/cmdline.c | 10 ++++++---- > > lib/librte_cmdline/cmdline.c | 2 +- > > It is very suspicious to change the cmdline library. > If there is a bug in this library, it deserves a separate fix.