From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from out1-smtp.messagingengine.com (out1-smtp.messagingengine.com [66.111.4.25]) by dpdk.org (Postfix) with ESMTP id 103F81F5 for ; Fri, 4 Aug 2017 00:42:56 +0200 (CEST) Received: from compute1.internal (compute1.nyi.internal [10.202.2.41]) by mailout.nyi.internal (Postfix) with ESMTP id 99D4920BD3; Thu, 3 Aug 2017 18:42:56 -0400 (EDT) Received: from frontend2 ([10.202.2.161]) by compute1.internal (MEProxy); Thu, 03 Aug 2017 18:42:56 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to:x-me-sender :x-me-sender:x-sasl-enc:x-sasl-enc; s=mesmtp; bh=DkUw38iRSx+PQlh 9fT2TXoMiMoio1VtMAixpBC1HfIE=; b=GkMCOv/U9oYh2rrzE9hCoTGmLMlEraS 4PZskkaWUj/pxLYiei9t44zCa/RBk0ZCM878haHs94/D73qrCKO/vLnZlf+OR52H rCH215/9PKGVlG7wCKyhL9fGkEyz3CP+Z9sy7dLk+7uU2R1MbGJ981JgZ4ERvJIJ 5KSZuoSzW0NE= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-transfer-encoding:content-type :date:from:in-reply-to:message-id:mime-version:references :subject:to:x-me-sender:x-me-sender:x-sasl-enc:x-sasl-enc; s= fm1; bh=DkUw38iRSx+PQlh9fT2TXoMiMoio1VtMAixpBC1HfIE=; b=mSduS+US 3BX+Kt/XQRv+MKrlOFV151unSNtts5mP9ncxTL+paMQjha13swqrzv3VKzaphAW0 rzBM+PWhBA0G0v87RUH/OjhggCD6pM2gDArgwSG5xqlpZlBuVX9cWkdvqhZI8RKx dN3Ux8VmFz5KKV6oUmDp0XCVUXdNESHzFERX7BhrdbRJyHVYpbth4y92ApE1T7FU Qb+OYB2j4YV5Hku6/bGFFfoNJ1SlJ6Ggte0iIEooVZXJMgTNI875d+qH4UuXy6aX xsctAqJLxIn0CWreqTt+0Mfb4hYgMTgA3Vk5NIC0S8ip3CiVyg4PGcrNU817dgri VVN7HIKbxcWl/A== X-ME-Sender: X-Sasl-enc: rX+qgudlyFy/pqRK/cI9ejB6DWZtAVgq4mOCPkqCqFDZ 1501800176 Received: from xps.localnet (196.114.118.80.rev.sfr.net [80.118.114.196]) by mail.messagingengine.com (Postfix) with ESMTPA id 280672436A; Thu, 3 Aug 2017 18:42:56 -0400 (EDT) From: Thomas Monjalon To: David Hunt Cc: dev@dpdk.org, shreyansh.jain@nxp.com Date: Fri, 04 Aug 2017 00:42:54 +0200 Message-ID: <1926257.pNRFXqBP4n@xps> In-Reply-To: <1496846277-280267-3-git-send-email-david.hunt@intel.com> References: <1495788764-37652-2-git-send-email-david.hunt@intel.com> <1496846277-280267-1-git-send-email-david.hunt@intel.com> <1496846277-280267-3-git-send-email-david.hunt@intel.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Subject: Re: [dpdk-dev] [PATCH v3 2/3] mk: allow use of environment var for template X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 03 Aug 2017 22:42:57 -0000 07/06/2017 16:37, David Hunt: > Added new environment variable RTE_TEMPLATE which is an additional > variable that can be set in the users environment. This maps on to the > existing 'T' command line variable typically used when 'make config' > or 'make install' is invoked. > > So, instead of typing 'make config T=x86_64-native-linuxapp-gcc', the user > can now do 'export RTE_TEMPLATE=x86_64-native-linuxapp-gcc' followed by > 'make config'. If the user instead chooses to 'make install', this will > do the configure, build, and install in one step. [...] > --- a/mk/rte.sdkinstall.mk > +++ b/mk/rte.sdkinstall.mk > @@ -47,6 +47,10 @@ ifneq ($(MAKECMDGOALS),pre_install) > include $(RTE_SDK)/mk/rte.vars.mk > endif > > +ifndef T > +T := $(RTE_TEMPLATE) > +endif "make install T=" is an old syntax. We should drop this non-standard syntax. So I prefer we do not encourage it with this variable. > --- a/mk/rte.sdkroot.mk > +++ b/mk/rte.sdkroot.mk > +ifdef RTE_TEMPLATE > +RTE_CONFIG_TEMPLATE := $(RTE_SRCDIR)/config/defconfig_$(RTE_TEMPLATE) > +endif What is the benefit of exporting RTE_TEMPLATE instead of T= ? I am afraid it get more confusion.