From: Thomas Monjalon <thomas.monjalon@6wind.com>
To: John McNamara <john.mcnamara@intel.com>, bruce.richardson@intel.com
Cc: dev@dpdk.org
Subject: Re: [dpdk-dev] [PATCH v2 1/4] ethdev: rename callbacks field to intr_cbs
Date: Fri, 13 Feb 2015 17:52:01 +0100 [thread overview]
Message-ID: <1927015.aErEKHGAj8@xps13> (raw)
In-Reply-To: <4241109.JKBOKelqd6@xps13>
2015-02-13 17:06, Thomas Monjalon:
> 2015-02-13 15:39, John McNamara:
> > From: Richardson, Bruce <bruce.richardson@intel.com>
> >
> > The callbacks member of the rte_eth_dev structure has been renamed
> > to intr_cbs to make it clear that it refers to callbacks from NIC
> > interrupts. This then allows us to add other types of callbacks to
> > the structure without ambiguity.
>
> Yes, good.
> Actually this callback is used only for link status interrupt, right?
> In the patchset for interrupt mode, new callbacks are used, right?
> Should we name this callback more precisely?
More naming considerations:
- The link status interrupt callback could be named link_intr_cb.
- The Rx callback could be named post_rx_burst_cb
- The Tx callback could be named pre_tx_burst_cb
next prev parent reply other threads:[~2015-02-13 16:52 UTC|newest]
Thread overview: 73+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-12-22 16:47 [dpdk-dev] [PATCH RFC 0/3] DPDK ethdev callback support Bruce Richardson
2014-12-22 16:47 ` [dpdk-dev] [PATCH RFC 1/3] ethdev: rename callbacks field to intr_cbs Bruce Richardson
2014-12-22 16:47 ` [dpdk-dev] [PATCH RFC 2/3] ethdev: Add in data rxtx callback support Bruce Richardson
2014-12-22 16:47 ` [dpdk-dev] [PATCH RFC 3/3] examples: example showing use of callbacks Bruce Richardson
2014-12-22 17:02 ` [dpdk-dev] [PATCH RFC 0/3] DPDK ethdev callback support Thomas Monjalon
2014-12-22 17:33 ` Bruce Richardson
2014-12-22 17:47 ` Neil Horman
2014-12-23 9:28 ` Bruce Richardson
2014-12-23 13:09 ` Neil Horman
2014-12-23 14:09 ` Bruce Richardson
2015-01-05 16:17 ` Bruce Richardson
2014-12-22 18:31 ` Stephen Hemminger
2014-12-23 9:29 ` Bruce Richardson
2014-12-23 4:23 ` Vithal S Mohare
2014-12-23 9:30 ` Bruce Richardson
2014-12-23 9:37 ` Vithal S Mohare
2014-12-24 1:43 ` Zhang, Helin
2014-12-24 5:06 ` Qiu, Michael
2015-02-12 19:57 ` [dpdk-dev] [PATCH " John McNamara
2015-02-12 19:57 ` [dpdk-dev] [PATCH 1/3] ethdev: rename callbacks field to intr_cbs John McNamara
2015-02-12 19:57 ` [dpdk-dev] [PATCH 2/3] ethdev: Add in data rxtx callback support John McNamara
2015-02-12 21:12 ` Neil Horman
2015-02-12 19:57 ` [dpdk-dev] [PATCH 3/3] examples: example showing use of callbacks John McNamara
2015-02-13 14:54 ` [dpdk-dev] [PATCH 0/3] DPDK ethdev callback support Declan Doherty
2015-02-13 15:39 ` [dpdk-dev] [PATCH v2 0/4] " John McNamara
2015-02-13 15:39 ` [dpdk-dev] [PATCH v2 1/4] ethdev: rename callbacks field to intr_cbs John McNamara
2015-02-13 16:06 ` Thomas Monjalon
2015-02-13 16:52 ` Thomas Monjalon [this message]
2015-02-13 15:39 ` [dpdk-dev] [PATCH v2 2/4] ethdev: Add in data rxtx callback support John McNamara
2015-02-13 16:33 ` Thomas Monjalon
2015-02-13 17:49 ` Bruce Richardson
2015-02-13 15:39 ` [dpdk-dev] [PATCH v2 3/4] examples: example showing use of callbacks John McNamara
2015-02-13 16:02 ` Thomas Monjalon
2015-02-16 14:33 ` Olivier MATZ
2015-02-16 15:16 ` Bruce Richardson
2015-02-16 17:34 ` Thomas Monjalon
2015-02-17 12:17 ` Declan Doherty
2015-02-17 12:25 ` Bruce Richardson
2015-02-17 13:28 ` Olivier MATZ
2015-02-17 13:50 ` Bruce Richardson
2015-02-17 15:49 ` Neil Horman
2015-02-17 16:00 ` Bruce Richardson
2015-02-17 16:08 ` Neil Horman
2015-02-17 16:15 ` Bruce Richardson
2015-02-17 19:27 ` Neil Horman
2015-02-17 15:32 ` Thomas Monjalon
2015-02-17 15:58 ` Bruce Richardson
2015-02-13 15:39 ` [dpdk-dev] [PATCH v2 4/4] abi: Added rxtx callback functions to ABI versioning John McNamara
2015-02-13 15:59 ` Thomas Monjalon
2015-02-13 15:48 ` [dpdk-dev] [PATCH v2 0/4] DPDK ethdev callback support Declan Doherty
2015-02-18 17:42 ` [dpdk-dev] [PATCH v3 0/3] " John McNamara
2015-02-18 17:42 ` [dpdk-dev] [PATCH v3 1/3] ethdev: Rename callbacks field to link_intr_cbs John McNamara
2015-02-18 17:42 ` [dpdk-dev] [PATCH v3 2/3] ethdev: Add rxtx callback support John McNamara
2015-02-18 18:19 ` Thomas Monjalon
2015-02-19 9:33 ` Mcnamara, John
2015-02-18 17:42 ` [dpdk-dev] [PATCH v3 3/3] examples: example showing use of callbacks John McNamara
2015-02-19 17:56 ` [dpdk-dev] [PATCH v4 0/3] DPDK ethdev callback support John McNamara
2015-02-19 17:56 ` [dpdk-dev] [PATCH v4 1/3] ethdev: rename callbacks field to link_intr_cbs John McNamara
2015-02-19 17:56 ` [dpdk-dev] [PATCH v4 2/3] ethdev: add optional rxtx callback support John McNamara
2015-02-20 10:06 ` Bruce Richardson
2015-02-20 10:31 ` Thomas Monjalon
2015-02-19 17:56 ` [dpdk-dev] [PATCH v4 3/3] examples: example showing use of callbacks John McNamara
2015-02-20 17:03 ` [dpdk-dev] [PATCH v5 0/3] DPDK ethdev callback support John McNamara
2015-02-20 17:03 ` [dpdk-dev] [PATCH v5 1/3] ethdev: rename callbacks field to link_intr_cbs John McNamara
2015-02-20 17:03 ` [dpdk-dev] [PATCH v5 2/3] ethdev: add optional rxtx callback support John McNamara
2015-02-23 15:11 ` Thomas Monjalon
2015-02-23 17:27 ` Mcnamara, John
2015-02-20 17:03 ` [dpdk-dev] [PATCH v5 3/3] examples: example showing use of callbacks John McNamara
2015-02-23 18:30 ` [dpdk-dev] [PATCH v6 0/3] DPDK ethdev callback support John McNamara
2015-02-23 18:30 ` [dpdk-dev] [PATCH v6 1/3] ethdev: rename callbacks field to link_intr_cbs John McNamara
2015-02-23 18:30 ` [dpdk-dev] [PATCH v6 2/3] ethdev: add optional rxtx callback support John McNamara
2015-02-23 18:30 ` [dpdk-dev] [PATCH v6 3/3] examples: example showing use of callbacks John McNamara
2015-02-23 23:39 ` [dpdk-dev] [PATCH v6 0/3] DPDK ethdev callback support Thomas Monjalon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1927015.aErEKHGAj8@xps13 \
--to=thomas.monjalon@6wind.com \
--cc=bruce.richardson@intel.com \
--cc=dev@dpdk.org \
--cc=john.mcnamara@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).