From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-wg0-f43.google.com (mail-wg0-f43.google.com [74.125.82.43]) by dpdk.org (Postfix) with ESMTP id 6F06AB4FD for ; Fri, 13 Feb 2015 17:52:33 +0100 (CET) Received: by mail-wg0-f43.google.com with SMTP id z12so4221428wgg.2 for ; Fri, 13 Feb 2015 08:52:33 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:from:to:cc:subject:date:message-id:organization :user-agent:in-reply-to:references:mime-version :content-transfer-encoding:content-type; bh=bEhAlGK+OcHmlEfDsAQBcG9xHCZwv9e0cpwWdmS3ViI=; b=nE4jLYLnwUwrAqMC4uNKDqvtTVVbe6VVlD8stm8S/H80fneqAGhMlGJeNXjref/0Kx zRtqEpipd/uLSy7appi/WE8I9mFTlV32N3tW3cUUGU9XjQHVtZVpgiw7aaGBZhaAY+T4 /+0aybn1zfU1zqLbRkg5l5QJn6QrSEWv29SIKU0HU25rPdS0QupxriQggpgY1mMxGO6s Z6Wuh/RAOvtQUZY0cW377zOIQ8/0xvssNY3JfTUHU7Q23KYQWTMItWAwwhlqdF8ZTalN lZzNdGH3RGmfbw/cMF93BRG5iW/ZsMjr+XmDqK+54bpSWJHsxa09mqZnZKpgvM/NWhzF lhuA== X-Gm-Message-State: ALoCoQkqTh9U6f98w9Ld2kWTUYow63Ahp/fuKzqIxwb+D+TrR+WMZMgHuJOozOjLwDFvMbPntisz X-Received: by 10.180.77.79 with SMTP id q15mr8611427wiw.19.1423846352064; Fri, 13 Feb 2015 08:52:32 -0800 (PST) Received: from xps13.localnet (136-92-190-109.dsl.ovh.fr. [109.190.92.136]) by mx.google.com with ESMTPSA id pl1sm7625576wic.23.2015.02.13.08.52.30 (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Fri, 13 Feb 2015 08:52:31 -0800 (PST) From: Thomas Monjalon To: John McNamara , bruce.richardson@intel.com Date: Fri, 13 Feb 2015 17:52:01 +0100 Message-ID: <1927015.aErEKHGAj8@xps13> Organization: 6WIND User-Agent: KMail/4.14.4 (Linux/3.18.4-1-ARCH; KDE/4.14.4; x86_64; ; ) In-Reply-To: <4241109.JKBOKelqd6@xps13> References: <1419266844-4848-1-git-send-email-bruce.richardson@intel.com> <1423841989-9090-2-git-send-email-john.mcnamara@intel.com> <4241109.JKBOKelqd6@xps13> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Cc: dev@dpdk.org Subject: Re: [dpdk-dev] [PATCH v2 1/4] ethdev: rename callbacks field to intr_cbs X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 13 Feb 2015 16:52:33 -0000 2015-02-13 17:06, Thomas Monjalon: > 2015-02-13 15:39, John McNamara: > > From: Richardson, Bruce > > > > The callbacks member of the rte_eth_dev structure has been renamed > > to intr_cbs to make it clear that it refers to callbacks from NIC > > interrupts. This then allows us to add other types of callbacks to > > the structure without ambiguity. > > Yes, good. > Actually this callback is used only for link status interrupt, right? > In the patchset for interrupt mode, new callbacks are used, right? > Should we name this callback more precisely? More naming considerations: - The link status interrupt callback could be named link_intr_cb. - The Rx callback could be named post_rx_burst_cb - The Tx callback could be named pre_tx_burst_cb