From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: <thomas.monjalon@6wind.com> Received: from mail-wg0-f45.google.com (mail-wg0-f45.google.com [74.125.82.45]) by dpdk.org (Postfix) with ESMTP id ADA235A9D for <dev@dpdk.org>; Wed, 10 Jun 2015 10:55:00 +0200 (CEST) Received: by wgv5 with SMTP id 5so30366707wgv.1 for <dev@dpdk.org>; Wed, 10 Jun 2015 01:55:00 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:from:to:cc:subject:date:message-id:organization :user-agent:in-reply-to:references:mime-version :content-transfer-encoding:content-type; bh=yy9xuFuXCKkm6BcbMqM5PK2hnJn7rhbuRmBuM71brlY=; b=boWPl7ST8Kh9dD9uQYBq9VFM/miFZEvzZ0du45ASss5errxbIzXcjZo5NSzoeMspK/ xUu2Y4AmgjPICuf9+Dg5DG+Eqj7VWPvWkk4S9teu8ju8DsOwfcijCbQcVmpGTgG/EEGD 3vfoY98Kin9P0Y2ljVA5EjKNAHCo29H/t1w2O5umFeZ8TTH+5ZtQbI9114DQvHNJmjpC i/k/EbvrN/4D3z8r6GNquovGHdOlOou8lxjNxHcI/W4BqV1bv23iCsuNgUrSxz+HW/G+ TrnxhQnGFHGRFm//zmSxQWtLJ7PRluOQIC3TyrHX/yz/dMnTnVz6F0d6IXDbIGWuiP4B xGUw== X-Gm-Message-State: ALoCoQmViK2aSwqd2aUHveOKWsOBkbBbbgX/LdlPqDeGSBJ4m7w7EA7I9rOQMWOdXoKwwDgRaDQr X-Received: by 10.194.178.225 with SMTP id db1mr4203484wjc.153.1433926500491; Wed, 10 Jun 2015 01:55:00 -0700 (PDT) Received: from xps13.localnet (guy78-3-82-239-227-177.fbx.proxad.net. [82.239.227.177]) by mx.google.com with ESMTPSA id bw5sm13404431wjc.31.2015.06.10.01.54.58 (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Wed, 10 Jun 2015 01:54:59 -0700 (PDT) From: Thomas Monjalon <thomas.monjalon@6wind.com> To: "Bernal Marin, Miguel" <miguel.bernal.marin@intel.com> Date: Wed, 10 Jun 2015 10:54:05 +0200 Message-ID: <1927342.Zb0Nrj3NUW@xps13> Organization: 6WIND User-Agent: KMail/4.14.8 (Linux/4.0.4-2-ARCH; KDE/4.14.8; x86_64; ; ) In-Reply-To: <F35DEAC7BCE34641BA9FAC6BCA4A12E70A87E0F2@SHSMSX104.ccr.corp.intel.com> References: <20150609174057.GA4394@linux.intel.com> <20150609181528.0053039d@urahara> <F35DEAC7BCE34641BA9FAC6BCA4A12E70A87E0F2@SHSMSX104.ccr.corp.intel.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Cc: dev@dpdk.org Subject: Re: [dpdk-dev] Headers files with BSD license in kernel X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK <dev.dpdk.org> List-Unsubscribe: <http://dpdk.org/ml/options/dev>, <mailto:dev-request@dpdk.org?subject=unsubscribe> List-Archive: <http://dpdk.org/ml/archives/dev/> List-Post: <mailto:dev@dpdk.org> List-Help: <mailto:dev-request@dpdk.org?subject=help> List-Subscribe: <http://dpdk.org/ml/listinfo/dev>, <mailto:dev-request@dpdk.org?subject=subscribe> X-List-Received-Date: Wed, 10 Jun 2015 08:55:00 -0000 2015-06-10 01:20, Zhang, Helin: > From: Stephen Hemminger [mailto:stephen@networkplumber.org] > > > > On Tue, Jun 09, 2015 at 12:40:57PM -0500, Miguel Bernal Marin wrote: > > > > > Hi, > > > > > > > > > > I'm working on Clear Linux project, and when I was integrating > > > > > DPDK kernel modules to our kernel I found there are two headers > > > > > with BSD License > > > > > > > > > > rte_pci_dev_feature_defs.h > > > > > rte_pci_dev_features.h > > > > > > > > > > those are included in igb_uio module. > > > > > > > > > > Are those licenses correct? > > > > You can always escalate a BSD license to GPL, but the other way is not allowed. > > Ideally, the language on the file should make it clear that it is dual licensed. > > In an ideal world, igb_uio would go away, I am working on that. > > Yes, I agree with you. To be clearer, rte_pci_dev_feature_defs.h should be in dual > liceses, and rte_pci_dev_features.h should be in GPL license. Yes, it is an error from this commit: http://dpdk.org/browse/dpdk/commit/?id=88701645c98c9c88 These definitions were moved from a GPL file so they should keep the GPL header. Then it is used in EAL: http://dpdk.org/browse/dpdk/commit/?id=ff0b67d1c868c19 So it must be dual licensed, like for rte_pci_dev_ids.h: http://dpdk.org/browse/dpdk/tree/lib/librte_eal/common/include/rte_pci_dev_ids.h