From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-wm0-f44.google.com (mail-wm0-f44.google.com [74.125.82.44]) by dpdk.org (Postfix) with ESMTP id 9BD8F2BBD for ; Mon, 11 Jul 2016 11:19:26 +0200 (CEST) Received: by mail-wm0-f44.google.com with SMTP id i5so7592177wmg.0 for ; Mon, 11 Jul 2016 02:19:26 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=6wind-com.20150623.gappssmtp.com; s=20150623; h=from:to:cc:subject:date:message-id:user-agent:in-reply-to :references:mime-version:content-transfer-encoding; bh=YwEkCvXBZdNG7OrLzoawwPva3leYohcoEpB5nz+7y9Y=; b=gh6LLSEI45AgD/JV7KKMUCbgC6F9shzZpHvtfyj2QvWIFPPDvALOXwfdniSHxXwhOL DErj8Jgb/fWcTXVZuftraXoxtAjF90HHPNgBRu2JO2/3DKvdjJd7EGrjO2fMmJ3vPbsx GJZSW3sgFw/zs5lHyICZQspgcTZQ5X8+AaYch+XpzHs50X3J/CeodpPEuilxaEMrXb3G izbrCmZLvU/pq5H/o4I8cjkXIoAP6UtmWWH1/5P6SI0fZ0Dpei5zD6FhqaOT1la2E+xu l9aAbkLAnwMch322BggYxkGMpflrYA8lrSz5aQA2Hp5wno1Zob7/DHk+oWC4dientjSQ fFVA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:from:to:cc:subject:date:message-id:user-agent :in-reply-to:references:mime-version:content-transfer-encoding; bh=YwEkCvXBZdNG7OrLzoawwPva3leYohcoEpB5nz+7y9Y=; b=FBn9Nk6QLT0ZzYwW/X9c8Jl2tnJ+j3z+2lFbta7aZHSd6rpopQUnmkrdJ04FVmc9/o eJO94Bh6W5TdM04sudcwvDGqWVQDO0iZmwu/olbdM9umOdRbihTD84i1FZPZmeA6qpie xGajflKo29vRURDw0w5Gb+fQVs69kuqe1MAlwwaNk10yeLvOkVj2Bvmx+1pVKCxn8c53 paZdnQIfTOja5K6byw6vGo+vFFeeNPN9v+VOdEiXxQtJ460JCmpj58OR66PtUybYKIDO 9PZgUQX4qXKEz9Ml4Q0fZtb6xbbhLZS6Jd+/FrHzKOtbdPK1ITflQ3lkdprfu0mR40C+ 7m6Q== X-Gm-Message-State: ALyK8tIS5ZEKw8dydoiTgXAV8/ucrlW/1xh6Y8FWbykpjfYDN6H/BQBOxPHjQhncjcFAjGcT X-Received: by 10.28.50.131 with SMTP id y125mr19247874wmy.94.1468228766356; Mon, 11 Jul 2016 02:19:26 -0700 (PDT) Received: from xps13.localnet (guy78-3-82-239-227-177.fbx.proxad.net. [82.239.227.177]) by smtp.gmail.com with ESMTPSA id r6sm13659298wme.14.2016.07.11.02.19.25 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Mon, 11 Jul 2016 02:19:25 -0700 (PDT) From: Thomas Monjalon To: "Ananyev, Konstantin" Cc: "Lu, Wenzhuo" , dev@dpdk.org Date: Mon, 11 Jul 2016 11:19:22 +0200 Message-ID: <1927507.Pj5eqIlGbv@xps13> User-Agent: KMail/4.14.10 (Linux/4.5.4-1-ARCH; KDE/4.14.11; x86_64; ; ) In-Reply-To: <2601191342CEEE43887BDE71AB97725836B7C73C@irsmsx105.ger.corp.intel.com> References: <1468218079-8064-1-git-send-email-wenzhuo.lu@intel.com> <2092181.9Q4Kasxdod@xps13> <2601191342CEEE43887BDE71AB97725836B7C73C@irsmsx105.ger.corp.intel.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Subject: Re: [dpdk-dev] [PATCH] lib/librte_ether: bypass code cleanup X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 11 Jul 2016 09:19:26 -0000 > From: dev [mailto:dev-bounces@dpdk.org] On Behalf Of Thomas Monjalon > > Hmmm. It's true it is cleaner. But I am not sure having a generic API > > for bypass is a good idea at all. > > I was thinking to totally remove it. > > Why to remove it? > As I know there are people who use that functionality. > > > Maybe we can try to have a specific API by including ixgbe_bypass.h in > > the application. > > Hmm, isn't that what we were trying to get rid of in last few years? > HW specific stuff? Yes exactly. I have the feeling the bypass API is specific to ixgbe. Isn't it? As we will probably see other features specific to only one device. Instead of adding a function in the generic API, I think it may be saner to include a driver header. Then if it appears to be used in more devices, it can be generalized. What do you think of this approach?