From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <thomas.monjalon@6wind.com>
Received: from mail-wi0-f174.google.com (mail-wi0-f174.google.com
 [209.85.212.174]) by dpdk.org (Postfix) with ESMTP id F1158C40C
 for <dev@dpdk.org>; Wed, 17 Jun 2015 14:10:35 +0200 (CEST)
Received: by wiga1 with SMTP id a1so137434499wig.0
 for <dev@dpdk.org>; Wed, 17 Jun 2015 05:10:35 -0700 (PDT)
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=1e100.net; s=20130820;
 h=x-gm-message-state:from:to:cc:subject:date:message-id:organization
 :user-agent:in-reply-to:references:mime-version
 :content-transfer-encoding:content-type;
 bh=Im+PN4Ayd4kGIKQf6xCcVRKGaXbH2RDnb87VQ/SPtz0=;
 b=jEyKpHj/U/7pE9+XuvJa8x7Qr/cUk68+7BPJPSqZoV4tG+XvejZAlDGa6da++DGD+W
 tseeHxHuwfA4c2WCuaWOUaR2silT4HDxwMqDgGvOkvMnn+XK45GhVietEGaOrp+zR+C9
 F90Kaczs4qUiBtKAIb2go4A41MfMWIZFdXVtb/UpZ8PdmCCbYRWlVKSJ2f3CDXSpLNL7
 WDf+KIlTRNCxjeI/sGO0jLYAvSCjS8p0ZTd1L4MTUU0qRXB8yLdtYxPHYEfgbqUPzQQJ
 mxhq5GZC0VE6QNc0MxtOAinGFxa/HWTYS8n9B8FSehNDj00S00D0Pj91bSfMT1A4AbIr
 6cZQ==
X-Gm-Message-State: ALoCoQlDot0ioEVm1FRAlx0J+yCeUYfCDtBScB7/oEpemM0mdrddPCPp9L9qfgjpkb2+lC5yuatf
X-Received: by 10.180.88.72 with SMTP id be8mr54094452wib.45.1434543035753;
 Wed, 17 Jun 2015 05:10:35 -0700 (PDT)
Received: from xps13.localnet (136-92-190-109.dsl.ovh.fr. [109.190.92.136])
 by mx.google.com with ESMTPSA id r6sm25655412wiy.13.2015.06.17.05.10.34
 (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128);
 Wed, 17 Jun 2015 05:10:34 -0700 (PDT)
From: Thomas Monjalon <thomas.monjalon@6wind.com>
To: Rahul Lakkireddy <rahul.lakkireddy@chelsio.com>
Date: Wed, 17 Jun 2015 14:09:35 +0200
Message-ID: <1931055.A5YAhvXmAm@xps13>
Organization: 6WIND
User-Agent: KMail/4.14.8 (Linux/4.0.4-2-ARCH; KDE/4.14.8; x86_64; ; )
In-Reply-To: <61d1c9174f7f9159d4005dd2cea16c7719cec964.1434462470.git.rahul.lakkireddy@chelsio.com>
References: <61d1c9174f7f9159d4005dd2cea16c7719cec964.1434462470.git.rahul.lakkireddy@chelsio.com>
MIME-Version: 1.0
Content-Transfer-Encoding: 7Bit
Content-Type: text/plain; charset="us-ascii"
Cc: dev@dpdk.org, Felix Marti <felix@chelsio.com>,
 Nirranjan Kirubaharan <nirranjan@chelsio.com>,
 Kumar Sanghvi <kumaras@chelsio.com>
Subject: Re: [dpdk-dev] [PATCH] vfio: Fix overflow while assigning vfio BAR
	region offset and size
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: patches and discussions about DPDK <dev.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
X-List-Received-Date: Wed, 17 Jun 2015 12:10:36 -0000

Hi Rahul,

2015-06-16 19:46, Rahul Lakkireddy:
> After the commit-id 90a1633b2 (eal/linux: allow to map BARs with MSI-X tables),

Please show this information before the Signed-off-by lines:
Fixes: 90a1633b2347 ("eal/linux: allow to map BARs with MSI-X tables")
generated with this git alias:
fixline = log -1 --abbrev=12 --format='Fixes: %h (\"%s\")'

> VFIO stopped working. On further debug, found that although BAR region

I suppose the whole VFIO didn't stopped working.
Please precise the conditions of the failures (large offset, etc).

> offset and size from vfio are read as u64, they are truncated when assigned to
> uint32_t variables resulting in wrong offset being passed for mmap.
> 
> The fix is to use uint64_t for offset and size.

Unfortunately, it doesn't build for 32-bit target.