From: Thomas Monjalon <thomas.monjalon@6wind.com> To: "Zhang, Helin" <helin.zhang@intel.com> Cc: dev@dpdk.org Subject: Re: [dpdk-dev] [PATCH] i40e: prefer base driver naming Date: Tue, 24 Jun 2014 23:43:36 +0200 Message-ID: <1931363.gcsx5jFyDH@xps13> (raw) In-Reply-To: <F35DEAC7BCE34641BA9FAC6BCA4A12E70A746880@SHSMSX104.ccr.corp.intel.com> 2014-06-24 15:32, Zhang, Helin: > From: Thomas Monjalon [mailto:thomas.monjalon@6wind.com] > > > The PMD is built on top of the base driver which is provided by Intel and > > shouldn't be modified to allow easy batch upgrade from Intel. > > > > The base driver is a "shared code" between many projects. But in DPDK, the > > "base driver" naming makes more sense. > > I prefer to keep the name of "shared code", and do not use "base driver". As > "base driver" is used to indicate the top level of Linux/Windows/FreeBSD > driver by our Network guys who provides us the shared code. If we do this > change, that will get us confused during following development. You are speaking about a code that we don't know and that doesn't matter in DPDK project. You say using "base driver" is confusing you but it's what it is: a base driver for PMD one. Furthermore, the name "shared code" is really confusing as it is shared with nothing else in DPDK. And it can be misunderstood as "code for shared libraries". > BTW, the names of "shared code" and "base driver" have been used for > specific code part for a long time by our Network guys. Wrong argument. We don't care about your Network guys here. We care about how contributors will dive into your code. I can be wrong so I'd like to have opinions from other people (preferably outside of Intel ;). Thanks -- Thomas
prev parent reply other threads:[~2014-06-24 21:43 UTC|newest] Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top 2014-06-24 8:56 Thomas Monjalon 2014-06-24 15:32 ` Zhang, Helin 2014-06-24 21:43 ` Thomas Monjalon [this message]
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=1931363.gcsx5jFyDH@xps13 \ --to=thomas.monjalon@6wind.com \ --cc=dev@dpdk.org \ --cc=helin.zhang@intel.com \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: link
DPDK patches and discussions This inbox may be cloned and mirrored by anyone: git clone --mirror https://inbox.dpdk.org/dev/0 dev/git/0.git # If you have public-inbox 1.1+ installed, you may # initialize and index your mirror using the following commands: public-inbox-init -V2 dev dev/ https://inbox.dpdk.org/dev \ dev@dpdk.org public-inbox-index dev Example config snippet for mirrors. Newsgroup available over NNTP: nntp://inbox.dpdk.org/inbox.dpdk.dev AGPL code for this site: git clone https://public-inbox.org/public-inbox.git