From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-wi0-f176.google.com (mail-wi0-f176.google.com [209.85.212.176]) by dpdk.org (Postfix) with ESMTP id 39AC6ADBE for ; Tue, 24 Jun 2014 23:43:22 +0200 (CEST) Received: by mail-wi0-f176.google.com with SMTP id n3so6723186wiv.9 for ; Tue, 24 Jun 2014 14:43:40 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:from:to:cc:subject:date:message-id:organization :user-agent:in-reply-to:references:mime-version :content-transfer-encoding:content-type; bh=mly0X5vYQ4in9vqSj/VZx47Sjr9d84UX38oXxMFhM9k=; b=M9+LZVbXizqCfjW8lIPye0QIuWCzhqy6ZKBg0zoQ8EKG/WMtnYmIPEdQpQDPe5A2MO t0iWTHHdTk/S8V3G4oHDsODfu60kswkuBJASH4JY2okpgaKJ+BeRdaxKV5/Yeov0VJpC iB/HPI7pJ78cA1lnXPTNipPhDdyy+qsDh9BnlH1kZv0JKndSA90dmN221P6ec+yXx3eD kw04KWrrngQ+5EYR97EdcFtLTB2ohqostJu4/fzjNmeyuarmEtfX1RAluCGrz8ZsAlVg awq+ZkIlnWtnR0hzxiSPoFt85/5yhwrF916adapCxkTJOxX8XatyteE524COcF6oZxGE vMsQ== X-Gm-Message-State: ALoCoQmP2aP4cmaOWqVTXFBnHrfYF2MOGZcOlZWjDZjO2dXi/yvVgntuaJ8BkkDPXhuz6q9xvpbA X-Received: by 10.181.8.198 with SMTP id dm6mr36788452wid.30.1403646220266; Tue, 24 Jun 2014 14:43:40 -0700 (PDT) Received: from xps13.localnet (136-92-190-109.dsl.ovh.fr. [109.190.92.136]) by mx.google.com with ESMTPSA id cd1sm3078551wjc.19.2014.06.24.14.43.38 for (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Tue, 24 Jun 2014 14:43:39 -0700 (PDT) From: Thomas Monjalon To: "Zhang, Helin" Date: Tue, 24 Jun 2014 23:43:36 +0200 Message-ID: <1931363.gcsx5jFyDH@xps13> Organization: 6WIND User-Agent: KMail/4.13.1 (Linux/3.14.6-1-ARCH; KDE/4.13.1; x86_64; ; ) In-Reply-To: References: <1403600215-9486-1-git-send-email-thomas.monjalon@6wind.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Cc: dev@dpdk.org Subject: Re: [dpdk-dev] [PATCH] i40e: prefer base driver naming X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 24 Jun 2014 21:43:22 -0000 2014-06-24 15:32, Zhang, Helin: > From: Thomas Monjalon [mailto:thomas.monjalon@6wind.com] > > > The PMD is built on top of the base driver which is provided by Intel and > > shouldn't be modified to allow easy batch upgrade from Intel. > > > > The base driver is a "shared code" between many projects. But in DPDK, the > > "base driver" naming makes more sense. > > I prefer to keep the name of "shared code", and do not use "base driver". As > "base driver" is used to indicate the top level of Linux/Windows/FreeBSD > driver by our Network guys who provides us the shared code. If we do this > change, that will get us confused during following development. You are speaking about a code that we don't know and that doesn't matter in DPDK project. You say using "base driver" is confusing you but it's what it is: a base driver for PMD one. Furthermore, the name "shared code" is really confusing as it is shared with nothing else in DPDK. And it can be misunderstood as "code for shared libraries". > BTW, the names of "shared code" and "base driver" have been used for > specific code part for a long time by our Network guys. Wrong argument. We don't care about your Network guys here. We care about how contributors will dive into your code. I can be wrong so I'd like to have opinions from other people (preferably outside of Intel ;). Thanks -- Thomas