* [dpdk-dev] [PATCH] ip_frag: promote APIs to stable
@ 2021-10-18 15:36 Konstantin Ananyev
2021-10-20 9:39 ` Kinsella, Ray
2021-10-28 11:51 ` [dpdk-dev] [PATCH v2] " Konstantin Ananyev
0 siblings, 2 replies; 4+ messages in thread
From: Konstantin Ananyev @ 2021-10-18 15:36 UTC (permalink / raw)
To: dev; +Cc: mdr, Konstantin Ananyev
Promote rte_frag_table_del_expired_entries() function to stable.
It was around for few years by now without any changes.
Signed-off-by: Konstantin Ananyev <konstantin.ananyev@intel.com>
---
lib/ip_frag/rte_ip_frag.h | 1 -
lib/ip_frag/version.map | 7 +------
2 files changed, 1 insertion(+), 7 deletions(-)
diff --git a/lib/ip_frag/rte_ip_frag.h b/lib/ip_frag/rte_ip_frag.h
index 08555fde6a..d856f87e6c 100644
--- a/lib/ip_frag/rte_ip_frag.h
+++ b/lib/ip_frag/rte_ip_frag.h
@@ -326,7 +326,6 @@ rte_ip_frag_table_statistics_dump(FILE * f, const struct rte_ip_frag_tbl *tbl);
* @param tms
* Current timestamp
*/
-__rte_experimental
void
rte_frag_table_del_expired_entries(struct rte_ip_frag_tbl *tbl,
struct rte_ip_frag_death_row *dr, uint64_t tms);
diff --git a/lib/ip_frag/version.map b/lib/ip_frag/version.map
index 33f231fb31..990384b536 100644
--- a/lib/ip_frag/version.map
+++ b/lib/ip_frag/version.map
@@ -8,13 +8,8 @@ DPDK_22 {
rte_ipv4_frag_reassemble_packet;
rte_ipv4_fragment_packet;
rte_ipv6_frag_reassemble_packet;
+ rte_frag_table_del_expired_entries;
rte_ipv6_fragment_packet;
local: *;
};
-
-EXPERIMENTAL {
- global:
-
- rte_frag_table_del_expired_entries;
-};
--
2.26.3
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [dpdk-dev] [PATCH] ip_frag: promote APIs to stable
2021-10-18 15:36 [dpdk-dev] [PATCH] ip_frag: promote APIs to stable Konstantin Ananyev
@ 2021-10-20 9:39 ` Kinsella, Ray
2021-10-28 11:51 ` [dpdk-dev] [PATCH v2] " Konstantin Ananyev
1 sibling, 0 replies; 4+ messages in thread
From: Kinsella, Ray @ 2021-10-20 9:39 UTC (permalink / raw)
To: Konstantin Ananyev, dev
On 18/10/2021 16:36, Konstantin Ananyev wrote:
> Promote rte_frag_table_del_expired_entries() function to stable.
> It was around for few years by now without any changes.
>
> Signed-off-by: Konstantin Ananyev <konstantin.ananyev@intel.com>
> ---
> lib/ip_frag/rte_ip_frag.h | 1 -
> lib/ip_frag/version.map | 7 +------
> 2 files changed, 1 insertion(+), 7 deletions(-)
>
> diff --git a/lib/ip_frag/rte_ip_frag.h b/lib/ip_frag/rte_ip_frag.h
> index 08555fde6a..d856f87e6c 100644
> --- a/lib/ip_frag/rte_ip_frag.h
> +++ b/lib/ip_frag/rte_ip_frag.h
> @@ -326,7 +326,6 @@ rte_ip_frag_table_statistics_dump(FILE * f, const struct rte_ip_frag_tbl *tbl);
> * @param tms
> * Current timestamp
> */
> -__rte_experimental
> void
> rte_frag_table_del_expired_entries(struct rte_ip_frag_tbl *tbl,
> struct rte_ip_frag_death_row *dr, uint64_t tms);
> diff --git a/lib/ip_frag/version.map b/lib/ip_frag/version.map
> index 33f231fb31..990384b536 100644
> --- a/lib/ip_frag/version.map
> +++ b/lib/ip_frag/version.map
> @@ -8,13 +8,8 @@ DPDK_22 {
> rte_ipv4_frag_reassemble_packet;
> rte_ipv4_fragment_packet;
> rte_ipv6_frag_reassemble_packet;
> + rte_frag_table_del_expired_entries;
isn't f before i?
> rte_ipv6_fragment_packet;
>
> local: *;
> };
> -
> -EXPERIMENTAL {
> - global:
> -
> - rte_frag_table_del_expired_entries;
> -};
>
Ray K
^ permalink raw reply [flat|nested] 4+ messages in thread
* [dpdk-dev] [PATCH v2] ip_frag: promote APIs to stable
2021-10-18 15:36 [dpdk-dev] [PATCH] ip_frag: promote APIs to stable Konstantin Ananyev
2021-10-20 9:39 ` Kinsella, Ray
@ 2021-10-28 11:51 ` Konstantin Ananyev
2021-11-04 18:24 ` Thomas Monjalon
1 sibling, 1 reply; 4+ messages in thread
From: Konstantin Ananyev @ 2021-10-28 11:51 UTC (permalink / raw)
To: dev; +Cc: mdr, Konstantin Ananyev
Promote rte_frag_table_del_expired_entries() function to stable.
It was around for few years by now without any changes.
Signed-off-by: Konstantin Ananyev <konstantin.ananyev@intel.com>
---
lib/ip_frag/rte_ip_frag.h | 1 -
lib/ip_frag/version.map | 7 +------
2 files changed, 1 insertion(+), 7 deletions(-)
diff --git a/lib/ip_frag/rte_ip_frag.h b/lib/ip_frag/rte_ip_frag.h
index 08555fde6a..d856f87e6c 100644
--- a/lib/ip_frag/rte_ip_frag.h
+++ b/lib/ip_frag/rte_ip_frag.h
@@ -326,7 +326,6 @@ rte_ip_frag_table_statistics_dump(FILE * f, const struct rte_ip_frag_tbl *tbl);
* @param tms
* Current timestamp
*/
-__rte_experimental
void
rte_frag_table_del_expired_entries(struct rte_ip_frag_tbl *tbl,
struct rte_ip_frag_death_row *dr, uint64_t tms);
diff --git a/lib/ip_frag/version.map b/lib/ip_frag/version.map
index 33f231fb31..2e13bef645 100644
--- a/lib/ip_frag/version.map
+++ b/lib/ip_frag/version.map
@@ -1,6 +1,7 @@
DPDK_22 {
global:
+ rte_frag_table_del_expired_entries;
rte_ip_frag_free_death_row;
rte_ip_frag_table_create;
rte_ip_frag_table_destroy;
@@ -12,9 +13,3 @@ DPDK_22 {
local: *;
};
-
-EXPERIMENTAL {
- global:
-
- rte_frag_table_del_expired_entries;
-};
--
2.26.3
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [dpdk-dev] [PATCH v2] ip_frag: promote APIs to stable
2021-10-28 11:51 ` [dpdk-dev] [PATCH v2] " Konstantin Ananyev
@ 2021-11-04 18:24 ` Thomas Monjalon
0 siblings, 0 replies; 4+ messages in thread
From: Thomas Monjalon @ 2021-11-04 18:24 UTC (permalink / raw)
To: Konstantin Ananyev; +Cc: dev, mdr
28/10/2021 13:51, Konstantin Ananyev:
> Promote rte_frag_table_del_expired_entries() function to stable.
> It was around for few years by now without any changes.
>
> Signed-off-by: Konstantin Ananyev <konstantin.ananyev@intel.com>
> ---
> lib/ip_frag/rte_ip_frag.h | 1 -
In general, the namespace in this file is wrong.
A lot of structs and enum don't have the correct name prefix.
> --- a/lib/ip_frag/version.map
> +++ b/lib/ip_frag/version.map
> @@ -1,6 +1,7 @@
> DPDK_22 {
> global:
>
> + rte_frag_table_del_expired_entries;
It seems that the right name should be rte_ip_frag_table_del_expired_entries.
> rte_ip_frag_free_death_row;
> rte_ip_frag_table_create;
> rte_ip_frag_table_destroy;
> @@ -12,9 +13,3 @@ DPDK_22 {
>
> local: *;
> };
> -
> -EXPERIMENTAL {
> - global:
> -
> - rte_frag_table_del_expired_entries;
> -};
We could keep this name as experimental during an expiration period.
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2021-11-04 18:24 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-10-18 15:36 [dpdk-dev] [PATCH] ip_frag: promote APIs to stable Konstantin Ananyev
2021-10-20 9:39 ` Kinsella, Ray
2021-10-28 11:51 ` [dpdk-dev] [PATCH v2] " Konstantin Ananyev
2021-11-04 18:24 ` Thomas Monjalon
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).