From: Thomas Monjalon <thomas@monjalon.net>
To: Wathsala Vithanage <wathsala.vithanage@arm.com>
Cc: Bruce Richardson <bruce.richardson@intel.com>,
dev@dpdk.org, nd@arm.com, Dhruv Tripathi <dhruv.tripathi@arm.com>
Subject: Re: [PATCH v3 1/2] config/arm: strict use of -mcpu for supported CPUs
Date: Wed, 05 Feb 2025 17:57:39 +0100 [thread overview]
Message-ID: <19321312.jiFIW2sfyF@thomas> (raw)
In-Reply-To: <20250106183146.540161-1-wathsala.vithanage@arm.com>
06/01/2025 19:31, Wathsala Vithanage:
> + 'mcpu_generic_aarch32': {
> + 'march': 'armv8-a',
> + 'march_extensions': ['simd'],
> + }
> + 'mcpu_thunderx2t99': {
> + 'march': 'armv8.1-a',
> + 'march_extensions': ['crc', 'crypto']
> + },
A comma is missing.
I can fix it but I am afraid you didn't test it at all.
And we need the CI to run on it.
Please send a v4.
next prev parent reply other threads:[~2025-02-05 16:57 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-10-28 23:31 [PATCH " Wathsala Vithanage
2024-10-28 23:31 ` [PATCH 2/2] config/arm: sort SOCs alphabetically Wathsala Vithanage
2024-10-29 1:06 ` [PATCH 1/2] config/arm: strict use of -mcpu for supported CPUs fengchengwen
2024-10-29 1:59 ` [PATCH v2 " Wathsala Vithanage
2024-10-29 1:59 ` [PATCH v2 2/2] config/arm: sort SOCs alphabetically Wathsala Vithanage
2024-11-11 14:12 ` [PATCH v2 1/2] config/arm: strict use of -mcpu for supported CPUs Thomas Monjalon
2024-11-11 17:57 ` Wathsala Wathawana Vithanage
2024-11-11 18:14 ` Thomas Monjalon
2024-11-11 19:46 ` Wathsala Wathawana Vithanage
2025-01-06 18:31 ` [PATCH v3 " Wathsala Vithanage
2025-01-06 18:31 ` [PATCH v3 2/2] config/arm: sort SOCs alphabetically Wathsala Vithanage
2025-02-05 16:41 ` Thomas Monjalon
2025-02-05 16:57 ` Thomas Monjalon [this message]
2024-11-29 23:47 [PATCH v3 1/2] config/arm: strict use of -mcpu for supported CPUs Wathsala Vithanage
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=19321312.jiFIW2sfyF@thomas \
--to=thomas@monjalon.net \
--cc=bruce.richardson@intel.com \
--cc=dev@dpdk.org \
--cc=dhruv.tripathi@arm.com \
--cc=nd@arm.com \
--cc=wathsala.vithanage@arm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).