From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-wg0-f45.google.com (mail-wg0-f45.google.com [74.125.82.45]) by dpdk.org (Postfix) with ESMTP id 7F45C7DF4 for ; Fri, 5 Dec 2014 17:18:55 +0100 (CET) Received: by mail-wg0-f45.google.com with SMTP id b13so1326027wgh.4 for ; Fri, 05 Dec 2014 08:18:55 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:from:to:cc:subject:date:message-id:organization :user-agent:in-reply-to:references:mime-version :content-transfer-encoding:content-type; bh=+lZWFvlvekb/Cm4YfPmyInlSo4QivIr4OGvJxs/U66o=; b=h7R68FORy37KcO/m7TZQupSi91A7MN2H4SBfGLBuKDQ/rbw0vpeF0kD0qgA+/hchHM ZRC7Y54wd6jQdybE/co0QctsPCzSzYn6eU1aEQRP98vhP2C0dLCgNttOOStgDM+ETajM x1o3txAOdjezEu9PZz3BeyipgU5qmGATc7nqKrLoM/2Esc6qqKYjFSuflv4bkfAY5+Yl EEyJttwM9+Fp22IToQcIj2gPGQ7UA+0BM+1Y7iNAgfq01UK8F+wwuiQwA6cxeD3iO4tJ cNC2U0FRlaC8Vuu3oObQJHVU9FCgnXHW9JHGOCfGKDXt8PiAMvXaIBm0IamJrg9/EFQ5 S19Q== X-Gm-Message-State: ALoCoQkYuytSOKZt3hMTd4Yxjjf2cJYwXO5frO85jYxjPXS5FA2d8aAAXmbWKZLYyggJfMpxZroy X-Received: by 10.194.59.17 with SMTP id v17mr25830332wjq.130.1417796335308; Fri, 05 Dec 2014 08:18:55 -0800 (PST) Received: from xps13.localnet (136-92-190-109.dsl.ovh.fr. [109.190.92.136]) by mx.google.com with ESMTPSA id e16sm2851573wik.2.2014.12.05.08.18.54 for (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Fri, 05 Dec 2014 08:18:54 -0800 (PST) From: Thomas Monjalon To: "Richardson, Bruce" Date: Fri, 05 Dec 2014 17:18:30 +0100 Message-ID: <1933365.Vq8yqmzseS@xps13> Organization: 6WIND User-Agent: KMail/4.14.3 (Linux/3.17.4-1-ARCH; KDE/4.14.3; x86_64; ; ) In-Reply-To: <3EB4FA525960D640B5BDFFD6A3D89126322DA654@IRSMSX108.ger.corp.intel.com> References: <1417703052-32575-1-git-send-email-bruce.richardson@intel.com> <3EB4FA525960D640B5BDFFD6A3D89126322DA654@IRSMSX108.ger.corp.intel.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Cc: dev@dpdk.org Subject: Re: [dpdk-dev] [PATCH] table: fix table_array for incomplete bitmask X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 05 Dec 2014 16:18:55 -0000 > When a lookup was done on a table_array structure with an incomplete > bitmask, the results was always zero hits. This was because the > pkts_mask value was cleared as we process each entry, and the result > was assigned at the end of the loop, when pkts_mask was zero. > Changing the assignment to occur at the start, before the pkts_mask > gets cleared, fixes this issue. > > Signed-off-by: Bruce Richardson > Acked by: Applied Thanks -- Thomas