From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 334AFA059F; Fri, 10 Apr 2020 16:41:34 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 12BA21D564; Fri, 10 Apr 2020 16:41:34 +0200 (CEST) Received: from out5-smtp.messagingengine.com (out5-smtp.messagingengine.com [66.111.4.29]) by dpdk.org (Postfix) with ESMTP id BEF611D557 for ; Fri, 10 Apr 2020 16:41:32 +0200 (CEST) Received: from compute7.internal (compute7.nyi.internal [10.202.2.47]) by mailout.nyi.internal (Postfix) with ESMTP id 0CB9D5C00C1; Fri, 10 Apr 2020 10:41:32 -0400 (EDT) Received: from mailfrontend2 ([10.202.2.163]) by compute7.internal (MEProxy); Fri, 10 Apr 2020 10:41:32 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h= from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding:content-type; s=mesmtp; bh=b+DUqvZJDtUlO7UpA4P4zCEItaWZPovGGXo/aJGoTLc=; b=NJSF4FyLCq2J qDgFBu7HzSxXWk/+7JwTbZci3dLNvWRab+72UwtwOPsnFmC3miWDCCxLEq3WVIGA ftDmtpA8C8DqgacX33UCOUk47S/tNrWc0Cit9qzxz5IFwiuimm5HwMhdS2TdgUoe 9EY1yw8+NcnI55LfUf4k8Qv5Y/ruuHM= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-transfer-encoding:content-type :date:from:in-reply-to:message-id:mime-version:references :subject:to:x-me-proxy:x-me-proxy:x-me-sender:x-me-sender :x-sasl-enc; s=fm2; bh=b+DUqvZJDtUlO7UpA4P4zCEItaWZPovGGXo/aJGoT Lc=; b=dlWBBNa5zQZHxJSBuNAylWs4tMVEOUTSUPRMQy21CIbdgyuzxsVPsYA2p unkU6BbG7i4kcKBa3rRRrltep+wPq9VwlCidHAE1uPXRvU1GaQoM0Z37IcSrzxf8 gMOhWFnG4DIhrM3tTv1Cs38nqCjF1v9bBEegd4cCTxVjvWftvQabp51zJN6ZeCyv tON++vuyt2xYiJxhcRyw7ebWQfu3SfnnsVwTV8xZRqlYcy9ElDArIB6ok35FskNI ryOG9lI1PSPdV5FQS+BB3dN01M/qMqI80MqPghFquFVHjJAqEaqHMTQK7n4/iPtu LcgR/JHolCUBGQyEMrgbkgMkQik7g== X-ME-Sender: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgeduhedrvddvgdektdcutefuodetggdotefrodftvf curfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdpuffrtefokffrpgfnqfghnecu uegrihhlohhuthemuceftddtnecusecvtfgvtghiphhivghnthhsucdlqddutddtmdenuc fjughrpefhvffufffkjghfggfgtgesthfuredttddtvdenucfhrhhomhepvfhhohhmrghs ucfoohhnjhgrlhhonhcuoehthhhomhgrshesmhhonhhjrghlohhnrdhnvghtqeenucfkph epjeejrddufeegrddvtdefrddukeegnecuvehluhhsthgvrhfuihiivgeptdenucfrrghr rghmpehmrghilhhfrhhomhepthhhohhmrghssehmohhnjhgrlhhonhdrnhgvth X-ME-Proxy: Received: from xps.localnet (184.203.134.77.rev.sfr.net [77.134.203.184]) by mail.messagingengine.com (Postfix) with ESMTPA id 2CE263060060; Fri, 10 Apr 2020 10:41:30 -0400 (EDT) From: Thomas Monjalon To: Bruce Richardson Cc: dev@dpdk.org, Lukasz Wojciechowski , Aaron Conole , Ruifeng Wang , David Marchand , Gavin Hu Date: Fri, 10 Apr 2020 16:41:28 +0200 Message-ID: <1933780.kXSN5OTJKJ@thomas> In-Reply-To: <20200410132547.GB42@bricha3-MOBL.ger.corp.intel.com> References: <20200409180332.592074-1-thomas@monjalon.net> <1813726.1xdlsreqCQ@thomas> <20200410132547.GB42@bricha3-MOBL.ger.corp.intel.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Subject: Re: [dpdk-dev] [PATCH v3] test: remove meson dependency on /proc file X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" 10/04/2020 15:25, Bruce Richardson: > On Fri, Apr 10, 2020 at 02:27:30PM +0200, Thomas Monjalon wrote: > > 10/04/2020 12:42, Bruce Richardson: > > > On Fri, Apr 10, 2020 at 12:29:50PM +0200, Thomas Monjalon wrote: > > > > --- a/app/test/meson.build > > > > +++ b/app/test/meson.build > > > > has_hugepage = true > > > > if is_linux > > > > > > Since you check for linux in the script, you can drop these two lines, > > > > The issue is for Windows. > > I am not sure how we will skip shell scripts > > when adding Windows support for this application. > > So there are two options now: > > a) remove Linux check before calling the script and ignore Windows support for now > > b) keep Linux check without knowing whether it will be useful for Windows support > > > > We vote a? > > > c) Write all such scripts in python, to allow them to run everywhere. :-) > > Given that windows is the problem, having the is_linux check in the > meson.build file makes most sense - in which case I don't think we need the > check for linux in the script. Yes, let's make it simple for now.