* [dpdk-dev] [PATCH] hash: fix use after free in thash
@ 2021-10-29 14:54 Vladimir Medvedkin
2021-11-03 15:41 ` David Marchand
0 siblings, 1 reply; 3+ messages in thread
From: Vladimir Medvedkin @ 2021-10-29 14:54 UTC (permalink / raw)
To: dev; +Cc: Yipeng Wang, Sameh Gobriel, Bruce Richardson
This patch fixes use after free in thash library, reported by ASAN.
Bugzilla ID: 868
Fixes: 28ebff11c2dc ("hash: add predictable RSS")
Signed-off-by: Vladimir Medvedkin <vladimir.medvedkin@intel.com>
---
lib/hash/rte_thash.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/lib/hash/rte_thash.c b/lib/hash/rte_thash.c
index 696a112..7a284a7 100644
--- a/lib/hash/rte_thash.c
+++ b/lib/hash/rte_thash.c
@@ -416,10 +416,10 @@ insert_before(struct rte_thash_ctx *ctx,
return ret;
}
} else if ((next_ent != NULL) && (end > next_ent->offset)) {
- rte_free(ent);
RTE_LOG(ERR, HASH,
"Can't add helper %s due to conflict with existing"
" helper %s\n", ent->name, next_ent->name);
+ rte_free(ent);
return -ENOSPC;
}
attach_lfsr(ent, cur_ent->lfsr);
@@ -465,10 +465,10 @@ insert_after(struct rte_thash_ctx *ctx,
int ret;
if ((next_ent != NULL) && (end > next_ent->offset)) {
- rte_free(ent);
RTE_LOG(ERR, HASH,
"Can't add helper %s due to conflict with existing"
" helper %s\n", ent->name, next_ent->name);
+ rte_free(ent);
return -EEXIST;
}
--
2.7.4
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [dpdk-dev] [PATCH] hash: fix use after free in thash
2021-10-29 14:54 [dpdk-dev] [PATCH] hash: fix use after free in thash Vladimir Medvedkin
@ 2021-11-03 15:41 ` David Marchand
2021-11-04 10:38 ` Thomas Monjalon
0 siblings, 1 reply; 3+ messages in thread
From: David Marchand @ 2021-11-03 15:41 UTC (permalink / raw)
To: Vladimir Medvedkin; +Cc: dev, Yipeng Wang, Sameh Gobriel, Bruce Richardson
On Fri, Oct 29, 2021 at 4:55 PM Vladimir Medvedkin
<vladimir.medvedkin@intel.com> wrote:
>
> This patch fixes use after free in thash library, reported by ASAN.
>
> Bugzilla ID: 868
> Fixes: 28ebff11c2dc ("hash: add predictable RSS")
>
> Signed-off-by: Vladimir Medvedkin <vladimir.medvedkin@intel.com>
Reviewed-by: David Marchand <david.marchand@redhat.com>
--
David Marchand
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [dpdk-dev] [PATCH] hash: fix use after free in thash
2021-11-03 15:41 ` David Marchand
@ 2021-11-04 10:38 ` Thomas Monjalon
0 siblings, 0 replies; 3+ messages in thread
From: Thomas Monjalon @ 2021-11-04 10:38 UTC (permalink / raw)
To: Vladimir Medvedkin
Cc: dev, Yipeng Wang, Sameh Gobriel, Bruce Richardson, David Marchand
03/11/2021 16:41, David Marchand:
> On Fri, Oct 29, 2021 at 4:55 PM Vladimir Medvedkin
> <vladimir.medvedkin@intel.com> wrote:
> >
> > This patch fixes use after free in thash library, reported by ASAN.
> >
> > Bugzilla ID: 868
> > Fixes: 28ebff11c2dc ("hash: add predictable RSS")
> >
> > Signed-off-by: Vladimir Medvedkin <vladimir.medvedkin@intel.com>
>
> Reviewed-by: David Marchand <david.marchand@redhat.com>
Applied, thanks.
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2021-11-04 10:38 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-10-29 14:54 [dpdk-dev] [PATCH] hash: fix use after free in thash Vladimir Medvedkin
2021-11-03 15:41 ` David Marchand
2021-11-04 10:38 ` Thomas Monjalon
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).