From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-wm0-f46.google.com (mail-wm0-f46.google.com [74.125.82.46]) by dpdk.org (Postfix) with ESMTP id DF8F82BB0 for ; Wed, 24 Feb 2016 11:33:21 +0100 (CET) Received: by mail-wm0-f46.google.com with SMTP id g62so237541515wme.0 for ; Wed, 24 Feb 2016 02:33:21 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=6wind-com.20150623.gappssmtp.com; s=20150623; h=from:to:cc:subject:date:message-id:organization:user-agent :in-reply-to:references:mime-version:content-transfer-encoding :content-type; bh=XqTSp2LQVECu6ZQp+uAjJy/vDw9oidz6KffndpK/p5s=; b=b5qrcNeG54XID1sILEXWCew2S9psrxUNMfa5zN9Ay1+c9TNjzxIOXm2Vs6nlVnrj5l iQzQntnhTMK0kj2N2+LgF4FbGZaOnYCPSDUNO6N9IsaHk/t6f9sJ2e3vGtaH/EGAj3pd dRpoJ3OAivPjsSIxqVGs5GtUYx4e4O1cCDgW5MjGQyF8Cof1QQijF0kbTRHE9H+atE9r IkPVKVifxG4RKC3cka8kYYQiivVFpyNx7/9FnNBhChUPyNuXl3wLvETlpOiLIVvF+JZY vnKifjhBZAsb9z+0sYgu8+eaLafz+cO3zVx9Gxgzv/+wN0OTL8QhqVZufYVvkVKCFbhO e2gA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:from:to:cc:subject:date:message-id:organization :user-agent:in-reply-to:references:mime-version :content-transfer-encoding:content-type; bh=XqTSp2LQVECu6ZQp+uAjJy/vDw9oidz6KffndpK/p5s=; b=C9aaXnUz014/RPJvePMh9SoOU8kEn0fN2oo8g9SYsh1WZjZcoO0duRxjmDxBtoK1e5 8RrgxFUrdtNeO845HjIvLprZnXPB7tsLwM6ENG08nN5EAyqGvgHjvb26E15lS3UXcFyg 3PsxX3/OE7VGhvi7lzyXfFfIwID0HE5NTEXSwd4upf8XPFmlcMITgIhqEBnLhdTW/vzv 26L+TwJEcf3NhayTRGX2SHx9lP5rk9BHN96XGNfy4wUIRXqRkOkd2tBIbYRYkxprjtWd waUZ/ASEWKiiARQYmEcUOzcow61szBt1nxeGIofTwwXRFS8BJvdKbtp49uV34rCtqGux sF6g== X-Gm-Message-State: AG10YORswNmXRZBXqnISbp05VfOTfHm839IM4dOsraHlYhnjWZPK/F2YXmjk4QSjaG2igGbH X-Received: by 10.28.65.5 with SMTP id o5mr24387831wma.75.1456310001722; Wed, 24 Feb 2016 02:33:21 -0800 (PST) Received: from xps13.localnet (171.36.101.84.rev.sfr.net. [84.101.36.171]) by smtp.gmail.com with ESMTPSA id u9sm30671022wmd.4.2016.02.24.02.33.20 (version=TLSv1/SSLv3 cipher=OTHER); Wed, 24 Feb 2016 02:33:21 -0800 (PST) From: Thomas Monjalon To: Bruce Richardson Date: Wed, 24 Feb 2016 11:31:47 +0100 Message-ID: <1937812.yRyThFtAzm@xps13> Organization: 6WIND User-Agent: KMail/4.14.10 (Linux/4.1.6-1-ARCH; KDE/4.14.11; x86_64; ; ) In-Reply-To: <20160224101011.GA19784@bricha3-MOBL3> References: <2221343.vDGpEpgp97@xps13> <20160224101011.GA19784@bricha3-MOBL3> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Cc: dev@dpdk.org, "Kantecki, Tomasz" Subject: Re: [dpdk-dev] [PATCH] eal: Initial implementation of PQoS EAL extension X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 24 Feb 2016 10:33:22 -0000 2016-02-24 10:10, Bruce Richardson: > On Wed, Feb 24, 2016 at 09:24:33AM +0100, Thomas Monjalon wrote: > > 2016-02-23 23:03, Kantecki, Tomasz: > > > > From: Thomas Monjalon [mailto:thomas.monjalon@6wind.com] > > > > If there is nothing specific in DPDK for PQos, why writing an example in > > > > DPDK? > > > The example makes it much easier to use the technology with DPDK. > > > > > > > Maybe the example should be better in the library itself. > > > The library in question (https://github.com/01org/intel-cmt-cat) has a couple of examples but none of them refers to DPDK. > > > > > > > I suggest to mention the library in > > > > doc/guides/linux_gsg/nic_perf_intel_platform.rst > > > Ok it can be added to this document. Does it imply -1 for the sample code idea? > > > > I may be wrong but I have the feeling the example is more about PQoS than DPDK. > > So yes, I would vote -1. > > > Well, the intersection of DPDK and PQoS is what the example is really all about, > and as such it is relevant to both DPDK and the library itself. Platform QoS > can be of great use to packet processing applications for helping to ensure that > the app gets the resources it needed - especially in a virtualised world - and > so we believe that having an example in DPDK showing how to use PQoS with DPDK > is well worthwhile having. It's more effective than a simple doc update in > raising awareness of the existence of the feature, and also provides for DPDK > users a readily available app for the user to start playing with to evaluate > PQoS for their own use-cases. > I also fail to see what the downside of having the sample app is - it won't add > significantly to the project maintenance overhead. We need to draw a line in the sand to decide what can go in DPDK examples because any code using some DPDK functions could require to be integrated. Until now, the examples were used to demonstrate some DPDK API. Here you are advocating that examples are "marketing tools" to bring awareness on a library. I have no strong opinion, except that we cannot host and maintain 100 examples. Other opinions are welcome.