From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <dev-bounces@dpdk.org>
Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124])
	by inbox.dpdk.org (Postfix) with ESMTP id 0A36245AAE;
	Fri,  4 Oct 2024 14:19:12 +0200 (CEST)
Received: from mails.dpdk.org (localhost [127.0.0.1])
	by mails.dpdk.org (Postfix) with ESMTP id EF002410D5;
	Fri,  4 Oct 2024 14:19:11 +0200 (CEST)
Received: from fhigh-a5-smtp.messagingengine.com
 (fhigh-a5-smtp.messagingengine.com [103.168.172.156])
 by mails.dpdk.org (Postfix) with ESMTP id A9AF640E5E
 for <dev@dpdk.org>; Fri,  4 Oct 2024 14:19:10 +0200 (CEST)
Received: from phl-compute-08.internal (phl-compute-08.phl.internal
 [10.202.2.48])
 by mailfhigh.phl.internal (Postfix) with ESMTP id 2DF6E11402D5;
 Fri,  4 Oct 2024 08:19:10 -0400 (EDT)
Received: from phl-mailfrontend-02 ([10.202.2.163])
 by phl-compute-08.internal (MEProxy); Fri, 04 Oct 2024 08:19:10 -0400
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h=
 cc:cc:content-transfer-encoding:content-type:content-type:date
 :date:from:from:in-reply-to:in-reply-to:message-id:mime-version
 :references:reply-to:subject:subject:to:to; s=fm2; t=1728044350;
 x=1728130750; bh=zqzHmFU+w+UKvIWEkUUTCptjPmUIngjXkevOLqlJgzc=; b=
 TiomE60vGxWelPOvH2GBpV8Evk7QDoaFL3JhW6v9xpPbe2pA33VUWJDihkW9jjzb
 qSROhdIrKvTqyVHZIUC95dhCRxNrh7Jzar1NTxXGPVYlosDiiAaFoF+D2dbOrfbg
 OOa64m0+igvp++qB9mDftHRg51xPSGCd9iBX3FEg4SRGWtTe6kZ5Ip+wit/bbBa0
 JA6v42p6SKlvv3mTnifWM4R1rvln9wcjHTMflUksntk6oZ8+MD3o0Cbke0zMlYAl
 +rxPBKPAREikIyLI3tzzR5YuWnVqnC0b+FMroLLDGLYkDlETBmYgW/WS6xEq8+TS
 RpakJ8HdThs1fKH+dqaQ5Q==
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=
 messagingengine.com; h=cc:cc:content-transfer-encoding
 :content-type:content-type:date:date:feedback-id:feedback-id
 :from:from:in-reply-to:in-reply-to:message-id:mime-version
 :references:reply-to:subject:subject:to:to:x-me-proxy:x-me-proxy
 :x-me-sender:x-me-sender:x-sasl-enc; s=fm2; t=1728044350; x=
 1728130750; bh=zqzHmFU+w+UKvIWEkUUTCptjPmUIngjXkevOLqlJgzc=; b=Z
 ieTO2lBvY9Zcu7YDAv2UvLpu/OcBURGQ3Q9BM8sEvoJY0KP3m5Sud/vU3SNlBh3k
 kAQLCiGVD3CVuh9zT8yhzFoxcchtUbzffeudwmAiO98QageeaFPTpeAuA7ipu746
 HHnr+EeDC7ZWFOiaCHMEHHjQLYtTFxnyDWLk8dOjeeDWXPmQwOgg/uKQPrnZzwOm
 JdWkNWi8UoFI4tuxSLovbUi4/ohaXnQkg8Jf1cKvft2tlwLaOJke057dEUNFmiUu
 DbFvmRrquV/jyjloUlfi3fT4Gf+a8SsHxO6Se5rkGpFoSNIC17KBvhgu1Osa1wyJ
 n7L4RPCJBvVtz5Yu+eqmA==
X-ME-Sender: <xms:Pd3_ZqDJaqCqhYCducHzZer9pQf4rgM83BLW0BFix2CzbRF9z4GKBA>
 <xme:Pd3_Zki1EyZldMNyWI_Ed33wR3bp0Rh0IoTlRDwoliF_BAqxWz5QptuyoVvApY1vH
 IdlvYN2CnrreZ4ZbQ>
X-ME-Received: <xmr:Pd3_Ztk3A3GfW7KdbO3o5h-ntEaYSZj1nZSMCP-2SxapEWiZzbpvkYHCYHaJZmZsHrYUc25xUcTfHKMzpVBs-DJlrg>
X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgeeftddrvddvfedghedtucetufdoteggodetrfdotf
 fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdggtfgfnhhsuhgsshgtrhhisggvpdfu
 rfetoffkrfgpnffqhgenuceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnh
 htshculddquddttddmnecujfgurhephffvvefufffkjghfggfgtgesthhqredttddtjeen
 ucfhrhhomhepvfhhohhmrghsucfoohhnjhgrlhhonhcuoehthhhomhgrshesmhhonhhjrg
 hlohhnrdhnvghtqeenucggtffrrghtthgvrhhnpeegtddtleejjeegffekkeektdejvedt
 heevtdekiedvueeuvdeiuddvleevjeeujeenucevlhhushhtvghrufhiiigvpedtnecurf
 grrhgrmhepmhgrihhlfhhrohhmpehthhhomhgrshesmhhonhhjrghlohhnrdhnvghtpdhn
 sggprhgtphhtthhopeduuddpmhhouggvpehsmhhtphhouhhtpdhrtghpthhtoheprhhjrg
 hrrhihsehrvgguhhgrthdrtghomhdprhgtphhtthhopehhohhfohhrsheslhihshgrthho
 rhdrlhhiuhdrshgvpdhrtghpthhtohepmhgrthhtihgrshdrrhhonhhnsghlohhmsegvrh
 hitghsshhonhdrtghomhdprhgtphhtthhopeguvghvseguphgukhdrohhrghdprhgtphht
 thhopehhvghnghdrfigrnhhgsegvrhhitghsshhonhdrtghomhdprhgtphhtthhopehsth
 gvphhhvghnsehnvghtfihorhhkphhluhhmsggvrhdrohhrghdprhgtphhtthhopehrohhr
 vghtiihlrgeslhhinhhugidrmhhitghrohhsohhfthdrtghomhdprhgtphhtthhopehmsg
 esshhmrghrthhshhgrrhgvshihshhtvghmshdrtghomhdprhgtphhtthhopehjrggtkhdr
 sghonhguqdhprhgvshhtohhnsehfohhsshdrrghrmhdrtghomh
X-ME-Proxy: <xmx:Pd3_Zowpe_E59ALjDS_arOvFBoguJUWCFkzOJwxxqQzxTtyTJtie-g>
 <xmx:Pd3_ZvQ8GGrSQoZA3vD_bMVZGz-b4KmgNwHdLLfkrGmvydLGpYVilQ>
 <xmx:Pd3_ZjbI6zzuALKG0Ek-RgoSCeRa919wfEx_dyIJjFgOG0G89_Suog>
 <xmx:Pd3_ZoRUqp7qiUtTnXc5A5RHYgUA2bUPxNSpz9mZoeuJqD1L7XYk2w>
 <xmx:Pt3_ZnZUfIYoEJrOZaoUYuHQBGw5ulJGb6St7wN_rp_5vGbsko4puINk>
Feedback-ID: i47234305:Fastmail
Received: by mail.messagingengine.com (Postfix) with ESMTPA; Fri,
 4 Oct 2024 08:19:07 -0400 (EDT)
From: Thomas Monjalon <thomas@monjalon.net>
To: Robin Jarry <rjarry@redhat.com>
Cc: Mattias =?UTF-8?B?UsO2bm5ibG9t?= <hofors@lysator.liu.se>,
 Mattias =?UTF-8?B?UsO2bm5ibG9t?= <mattias.ronnblom@ericsson.com>,
 dev@dpdk.org, Heng Wang <heng.wang@ericsson.com>,
 Stephen Hemminger <stephen@networkplumber.org>,
 Tyler Retzlaff <roretzla@linux.microsoft.com>,
 Morten =?UTF-8?B?QnLDuHJ1cA==?= <mb@smartsharesystems.com>,
 Jack Bond-Preston <jack.bond-preston@foss.arm.com>,
 David Marchand <david.marchand@redhat.com>,
 Chengwen Feng <fengchengwen@huawei.com>
Subject: Re: [PATCH v12 1/7] buildtools/chkincs: relax C linkage requirement
Date: Fri, 04 Oct 2024 14:19:06 +0200
Message-ID: <1939252.atdPhlSkOF@thomas>
In-Reply-To: <D4N008NW98G0.3BOAV6EBW5J0L@redhat.com>
References: <20240920062437.738706-2-mattias.ronnblom@ericsson.com>
 <74e86a66-4341-465d-bcba-d76db66035cd@lysator.liu.se>
 <D4N008NW98G0.3BOAV6EBW5J0L@redhat.com>
MIME-Version: 1.0
Content-Transfer-Encoding: quoted-printable
Content-Type: text/plain; charset="utf-8"
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <https://mails.dpdk.org/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://mails.dpdk.org/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <https://mails.dpdk.org/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org

04/10/2024 13:51, Robin Jarry:
> Mattias R=C3=B6nnblom, Oct 04, 2024 at 10:40:
> > Making small scripts needlessly complicated is not good example, it's a=
=20
> > bad one.
>=20
> I don't find adding argument checks needlessly complicated but this is=20
> a matter of preference. To me, Python is not shell script. If you want=20
> something small, shell might be more appropriate?
>=20
> >>> Sure, but it would be required to invoke the script for every header=
=20
> >>> file in the tree. Not sure I think that would be a net gain.
> >>=20
> >> You can store a global exit status in the script and process all heade=
rs=20
> >> before exiting with an error if any.
> >
> > You will need to give the user a list of offending header files.
>=20
> I'm not suggesting to avoid printing the offending file names. I'm only=20
> suggesting to exit(1) if there were *any* offending file names. That way=
=20
> you don't have to check *in meson* if the script did output anything.=20
> Checking the exit status is simpler.
>=20
> Sorry for being pedantic, but Python code in DPDK is already treated=20
> badly. I wish we could improve the quality a bit.

Thank you Robin for your detailed review.
I support this effort of improving our Python scripts.