Re: [dpdk-dev] [PATCH v4 0/3] net/pcap: build on Windows

[Thomas Monjalon <thomas@monjalon.net>]

21/04/2021 16:53, Dmitry Kozlyuk:
> 2021-04-21 00:20 (UTC+0200), Thomas Monjalon:
> > > Dmitry Kozlyuk (3):
> > >   eal/windows: add timespec_get shim for MinGW
> > >   net/pcap: move OS-dependent code to separate files
> > >   net/pcap: build on Windows  
> > 
> > Compilation is failing on FreeBSD 11:
> > http://mails.dpdk.org/archives/test-report/2021-April/188997.html
> > 	implicit declaration of function 'timespec_get' is invalid in C99
> > 	use of undeclared identifier 'TIME_UTC'
> > 
> > It should be fixed by including time.h 
> 
> No, FreeBSD 11 is missing timespec_get indeed.
> 
> > I cannot reproduce the issue with FreeBSD 12.
> 
> After adding a FreeBSD 11 shim and rebasing over "main"
> I get another error unrelated to the patch.
> It seems FreeBSD 11 is missing pthread_setname_np() as well.
> 
> [11/1847] Compiling C object lib/librte_telemetry.a.p/telemetry_telemetry.c.o
> ../src/lib/telemetry/telemetry.c:445:2: warning: implicit declaration of function 'pthread_setname_np' is invalid in C99 [-Wimplicit-function-declaration]
>         pthread_setname_np(t_old, "telemetry-v1");
>         ^
> ../src/lib/telemetry/telemetry.c:474:2: warning: implicit declaration of function 'pthread_setname_np' is invalid in C99 [-Wimplicit-function-declaration]
>         pthread_setname_np(t_new, "telemetry-v2");
>         ^

Sorry, that's because I've merged a patch which is failing
with FreeBSD < 12.2 and I missed the CI report.

I am fixing with this patch:
https://patches.dpdk.org/project/dpdk/patch/20210421181157.1634301-1-thomas@monjalon.net/