From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id EC56BA0547; Wed, 21 Apr 2021 20:13:03 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id DA82040687; Wed, 21 Apr 2021 20:13:03 +0200 (CEST) Received: from wout5-smtp.messagingengine.com (wout5-smtp.messagingengine.com [64.147.123.21]) by mails.dpdk.org (Postfix) with ESMTP id 12E8540150 for ; Wed, 21 Apr 2021 20:13:02 +0200 (CEST) Received: from compute2.internal (compute2.nyi.internal [10.202.2.42]) by mailout.west.internal (Postfix) with ESMTP id 1163519D4; Wed, 21 Apr 2021 14:13:01 -0400 (EDT) Received: from mailfrontend1 ([10.202.2.162]) by compute2.internal (MEProxy); Wed, 21 Apr 2021 14:13:01 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h= from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding:content-type; s=fm1; bh= LboL8SuUPXOADklE9HmkBAE/nsq7DRblC3Pf7JfuDJ4=; b=QKUgYdRkoVqG+dB8 YtbB71BqwafG1HF/U7drc0Zb0hqd6k4euNzZKQdoQ1k5i1EQsFvQE4iBMCXkPHKy 6TfA0RYelPZpyiLE6YQvAgf6jCgB+DicZYXM5HJcXhQRuJ/MUxOQnUBu+kLc9+36 dliZJag/+IckBwfShpdokzGf+ZclKGEIg3L+34tcbwveGWQvHh70xRW7Mg+zOYR4 Wc0w1RD7OFKgUMuTSQZ2HlogBEGzX7esc1BhbJcV1csdgCV0C2pObRfqc9ERC2Om hCb05hWpkhA5yBX/G0CfkG0BmZvMdcDkq23cGZ2p2T95q+CkMVSvnGpIdGlANIvL KFK5Dw== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-transfer-encoding:content-type :date:from:in-reply-to:message-id:mime-version:references :subject:to:x-me-proxy:x-me-proxy:x-me-sender:x-me-sender :x-sasl-enc; s=fm2; bh=LboL8SuUPXOADklE9HmkBAE/nsq7DRblC3Pf7JfuD J4=; b=JrXSlbs5YT+TpFibS3nZ9AiimtT5HM06HxZU4TIjBbr8XMkmk/3y70Zai NNSk/YZgFPMdb0pvGrdGAUbjglLlmYA1KODreskpKEFHHJ94CX2F8SIhNRbQLbwr gXw87KXA/fHVpjgJh46m6hL7CZx3RGhXs5yHM8V19SX0BG2bRnK/5tvx1glxlNMy sCmRHYQy3r4IyC8tWBR134aJjaYAISfM8cfkYLjWNF1CjmiSnSe3Fd8BHOSArpFd 1WqHrPe8FHEebWJPeJSoi7EOlOA/C9S1b87xRE04R2l44yp+lmx+fyR1NN/9+cNf In0tzK+H5a2M5bnfmQFlknPCjGM+w== X-ME-Sender: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgeduledrvddtkedguddvfecutefuodetggdotefrod ftvfcurfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdpuffrtefokffrpgfnqfgh necuuegrihhlohhuthemuceftddtnecunecujfgurhephffvufffkfgjfhgggfgtsehtuf ertddttddvnecuhfhrohhmpefvhhhomhgrshcuofhonhhjrghlohhnuceothhhohhmrghs sehmohhnjhgrlhhonhdrnhgvtheqnecuggftrfgrthhtvghrnhepffdvffejueetleefie eludduuefgteejleevfeekjeefieegheetffdvkeefgedunecuffhomhgrihhnpeguphgu khdrohhrghenucfkphepjeejrddufeegrddvtdefrddukeegnecuvehluhhsthgvrhfuih iivgeptdenucfrrghrrghmpehmrghilhhfrhhomhepthhhohhmrghssehmohhnjhgrlhho nhdrnhgvth X-ME-Proxy: Received: from xps.localnet (184.203.134.77.rev.sfr.net [77.134.203.184]) by mail.messagingengine.com (Postfix) with ESMTPA id 30AA124005C; Wed, 21 Apr 2021 14:13:00 -0400 (EDT) From: Thomas Monjalon To: Dmitry Kozlyuk Cc: dev@dpdk.org Date: Wed, 21 Apr 2021 20:12:57 +0200 Message-ID: <1939354.Lyt7oRkXTy@thomas> In-Reply-To: <20210421175303.75572a8c@sovereign> References: <20210324005008.24705-1-dmitry.kozliuk@gmail.com> <2873208.8DoL4XIl1F@thomas> <20210421175303.75572a8c@sovereign> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Subject: Re: [dpdk-dev] [PATCH v4 0/3] net/pcap: build on Windows X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" 21/04/2021 16:53, Dmitry Kozlyuk: > 2021-04-21 00:20 (UTC+0200), Thomas Monjalon: > > > Dmitry Kozlyuk (3): > > > eal/windows: add timespec_get shim for MinGW > > > net/pcap: move OS-dependent code to separate files > > > net/pcap: build on Windows > > > > Compilation is failing on FreeBSD 11: > > http://mails.dpdk.org/archives/test-report/2021-April/188997.html > > implicit declaration of function 'timespec_get' is invalid in C99 > > use of undeclared identifier 'TIME_UTC' > > > > It should be fixed by including time.h > > No, FreeBSD 11 is missing timespec_get indeed. > > > I cannot reproduce the issue with FreeBSD 12. > > After adding a FreeBSD 11 shim and rebasing over "main" > I get another error unrelated to the patch. > It seems FreeBSD 11 is missing pthread_setname_np() as well. > > [11/1847] Compiling C object lib/librte_telemetry.a.p/telemetry_telemetry.c.o > ../src/lib/telemetry/telemetry.c:445:2: warning: implicit declaration of function 'pthread_setname_np' is invalid in C99 [-Wimplicit-function-declaration] > pthread_setname_np(t_old, "telemetry-v1"); > ^ > ../src/lib/telemetry/telemetry.c:474:2: warning: implicit declaration of function 'pthread_setname_np' is invalid in C99 [-Wimplicit-function-declaration] > pthread_setname_np(t_new, "telemetry-v2"); > ^ Sorry, that's because I've merged a patch which is failing with FreeBSD < 12.2 and I missed the CI report. I am fixing with this patch: https://patches.dpdk.org/project/dpdk/patch/20210421181157.1634301-1-thomas@monjalon.net/