From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-wg0-f42.google.com (mail-wg0-f42.google.com [74.125.82.42]) by dpdk.org (Postfix) with ESMTP id A395E212 for ; Tue, 30 Sep 2014 06:28:43 +0200 (CEST) Received: by mail-wg0-f42.google.com with SMTP id z12so3859108wgg.1 for ; Mon, 29 Sep 2014 21:35:22 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:from:to:cc:subject:date:message-id:organization :user-agent:in-reply-to:references:mime-version :content-transfer-encoding:content-type; bh=9eFZjTO0MGdQGjOg2qJBZsW2lhhwS1lO+NHFlzmKlQY=; b=TaN7Web5Ni+18bAMgazYeHGX5rhnqcskd0SynzFF2B01EnrrM5tK11p1KVWzhWzsem DkWVndA4y9t1DxJr4aJUTBGRPaEWAtbCFveP9w+43XfrHTW14aRXZUYTv35U6QVgWdcC uPuAgXxX2I906TyDK2Qb++k9fzghZM/2r2neLCWOhNDFhojnAMeIcS5VREWc+j35dFrH IwkgJ9ev94FyedGqOjTRx9rEQP5HmyyD0t4K4e0Ki5eS6O4/8oe2Psk+r1AlZsVS2Ri0 sPvoib4ShICg+ioPwjzxEkr3SVDhnnJ9vwrke7rXKoli1SbDQK1GjZ9vvvpAUaKPrYtv OXdQ== X-Gm-Message-State: ALoCoQneNNGIuBUxIeEfAyL56z0CSbLproMOXV+25C+FLnNR/su0Ks9wqWUm/7Wwns0eUpJuGbHX X-Received: by 10.194.8.232 with SMTP id u8mr50925684wja.64.1412051722473; Mon, 29 Sep 2014 21:35:22 -0700 (PDT) Received: from xps13.localnet (110.26.90.92.rev.sfr.net. [92.90.26.110]) by mx.google.com with ESMTPSA id dc9sm13752248wib.5.2014.09.29.21.35.20 for (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Mon, 29 Sep 2014 21:35:21 -0700 (PDT) From: Thomas Monjalon To: "Xie, Huawei" Date: Tue, 30 Sep 2014 06:35:04 +0200 Message-ID: <1939857.K6XTWT658S@xps13> Organization: 6WIND User-Agent: KMail/4.13.3 (Linux/3.15.8-1-ARCH; KDE/4.13.3; x86_64; ; ) In-Reply-To: References: <1411724758-27488-1-git-send-email-huawei.xie@intel.com> <18610886.dgDN8rLRaO@xps13> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Cc: dev@dpdk.org Subject: Re: [dpdk-dev] [PATCH v5 01/11] lib/librte_vhost: move src files in vhost example to vhost lib directory X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 30 Sep 2014 04:28:43 -0000 2014-09-30 02:07, Xie, Huawei: > > In patch 2, you're using main.c to create vhost_rxtx.c. > > So it would be clearer to rename it in this patch 1. > > > Rename it to vhost_rxtx.c? Yes :) And rename virtio-net.h to rte_virtio_net.h. Please put all file renaming in the same patch. Then second patch should be definitive removals. >>From the third patch, you can start reworks. -- Thomas