DPDK patches and discussions
 help / color / mirror / Atom feed
From: Kevin Traynor <ktraynor@redhat.com>
To: "Burakov, Anatoly" <anatoly.burakov@intel.com>,
	David Marchand <david.marchand@redhat.com>,
	wangyunjian <wangyunjian@huawei.com>,
	Luca Boccassi <bluca@debian.org>
Cc: dev <dev@dpdk.org>, Hemant Agrawal <hemant.agrawal@nxp.com>,
	Sachin Saxena <sachin.saxena@nxp.com>,
	"Lilijun (Jerry)" <jerry.lilijun@huawei.com>,
	xudingke <xudingke@huawei.com>, dpdk stable <stable@dpdk.org>,
	Luca Boccassi <bluca@debian.org>
Subject: Re: [dpdk-dev] [dpdk-stable] [PATCH 1/2] vfio: fix check for vfio_group_fd
Date: Wed, 27 May 2020 11:45:04 +0100	[thread overview]
Message-ID: <1939e02f-b45c-65fd-567e-5cc1f71c6b72@redhat.com> (raw)
In-Reply-To: <f1d7e035-dbb5-000e-3cb2-0b6d9148fcfe@intel.com>

On 21/05/2020 13:53, Burakov, Anatoly wrote:
> On 19-May-20 8:43 AM, David Marchand wrote:
>> On Tue, May 19, 2020 at 5:42 AM wangyunjian <wangyunjian@huawei.com> wrote:
>>> From: Yunjian Wang <wangyunjian@huawei.com>
>>> The issue is that a file descriptor at 0 is a valid one. Currently
>>> the file not found, the return value will be set to 0. As a result,
>>> it is impossible to distinguish between a correct descriptor and a
>>> failed return value. Fix it to return -ENOENT instead of 0.
>>> Fixes: b758423bc4fe ("vfio: fix race condition with sysfs")
>>> Fixes: ff0b67d1c868 ("vfio: DMA mappinge")
>>> Cc: stable@dpdk.org
>> This patch reverts the (marked for stable) fix b758423bc4fe ("vfio:
>> fix race condition with sysfs") and comes with a different fix.
>> - Kevin, Luca, I would put this b758423bc4fe backport on hold.
>> - Anatoly, I don't want to put 20.05 at risk.
>> My simple question for 20.05 is, should we revert b758423bc4fe?
> No, let's not revert anything.
> As far as i can tell, this patch is a more complete fix, but it 
> essentially does the same thing, just in a different (and better) way. 
> Still, i haven't reviewed it in detail.

b758423bc4fe was not reverted in master - should that be backported now?
or should we wait until this new fix is ready for backport too?

>> - This patchset will go to 20.08 as I don't feel confident in taking it now.
> Yes, let's leave it for 20.08.

  parent reply	other threads:[~2020-05-27 10:45 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-05-19  3:42 [dpdk-dev] " wangyunjian
2020-05-19  7:43 ` [dpdk-dev] [dpdk-stable] " David Marchand
2020-05-21 12:53   ` Burakov, Anatoly
2020-05-22  7:36     ` David Marchand
2020-05-27 10:45     ` Kevin Traynor [this message]
2020-07-29 11:43       ` wangyunjian
2020-09-17 11:44 ` [dpdk-dev] " Burakov, Anatoly

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1939e02f-b45c-65fd-567e-5cc1f71c6b72@redhat.com \
    --to=ktraynor@redhat.com \
    --cc=anatoly.burakov@intel.com \
    --cc=bluca@debian.org \
    --cc=david.marchand@redhat.com \
    --cc=dev@dpdk.org \
    --cc=hemant.agrawal@nxp.com \
    --cc=jerry.lilijun@huawei.com \
    --cc=sachin.saxena@nxp.com \
    --cc=stable@dpdk.org \
    --cc=wangyunjian@huawei.com \
    --cc=xudingke@huawei.com \


* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).