From: "Wei Hu (Xavier)" <xavier.huwei@huawei.com>
To: Chas Williams <3chas3@gmail.com>, <dev@dpdk.org>
Subject: Re: [dpdk-dev] [PATCH] pmd_bond: fix mac address update for ACTIVE_BACKUP, TLB and ALB modes
Date: Fri, 19 Jun 2020 09:19:31 +0800 [thread overview]
Message-ID: <193e5a74-2f99-e2ca-b7b2-e1e7a32d8597@huawei.com> (raw)
In-Reply-To: <1768cd54-65a0-5fca-ef3f-418429a1ea3d@gmail.com>
Hi, Chas Williams & Sergey Lvov
There was a two-patch series about bonding those are still in reviewing
state,
and the one of them includes the identical modification. Thanks.
http://patches.dpdk.org/patch/68742/
The series include two patches:
http://patches.dpdk.org/patch/68742/
http://patches.dpdk.org/patch/68743/
Best Regards
Xavier
On 2020/6/19 4:32, Chas Williams wrote:
> Yes, this does look like a typo on someone's part.
>
> Please change use net/bonding: instead of pmd_bond:
> Please add a Fixes: line
> Please add a Cc: stable@dpdk.org
>
> On 6/17/20 3:02 PM, Sergey Lvov wrote:
> > It seems to be a typo
> >
> > Signed-off-by: Sergey Lvov <log0div0@gmail.com>
> > ---
> > drivers/net/bonding/rte_eth_bond_pmd.c | 2 +-
> > 1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/drivers/net/bonding/rte_eth_bond_pmd.c
> b/drivers/net/bonding/rte_eth_bond_pmd.c
> > index 612a64599..3ef0df84a 100644
> > --- a/drivers/net/bonding/rte_eth_bond_pmd.c
> > +++ b/drivers/net/bonding/rte_eth_bond_pmd.c
> > @@ -1533,7 +1533,7 @@ mac_address_slaves_update(struct rte_eth_dev
> *bonded_eth_dev)
> > if (internals->slaves[i].port_id ==
> > internals->current_primary_port) {
> > if (rte_eth_dev_default_mac_addr_set(
> > - internals->primary_port,
> > + internals->current_primary_port,
> > bonded_eth_dev->data->mac_addrs)) {
> > RTE_BOND_LOG(ERR, "Failed to update port Id %d
> MAC address",
> > internals->current_primary_port);
> >
>
next prev parent reply other threads:[~2020-06-19 1:19 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-06-17 19:02 Sergey Lvov
2020-06-18 20:32 ` Chas Williams
2020-06-19 1:19 ` Wei Hu (Xavier) [this message]
2020-07-11 10:01 ` Wei Hu (Xavier)
2020-07-17 11:43 ` Wei Hu (Xavier)
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=193e5a74-2f99-e2ca-b7b2-e1e7a32d8597@huawei.com \
--to=xavier.huwei@huawei.com \
--cc=3chas3@gmail.com \
--cc=dev@dpdk.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).