From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-wm0-f51.google.com (mail-wm0-f51.google.com [74.125.82.51]) by dpdk.org (Postfix) with ESMTP id 4F3EDC466 for ; Thu, 28 Jan 2016 14:40:51 +0100 (CET) Received: by mail-wm0-f51.google.com with SMTP id 128so11052510wmz.1 for ; Thu, 28 Jan 2016 05:40:51 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=6wind-com.20150623.gappssmtp.com; s=20150623; h=from:to:cc:subject:date:message-id:organization:user-agent :in-reply-to:references:mime-version:content-transfer-encoding :content-type; bh=JpUWp/o2xQum9QabkN1vh4l5dg/snvFWzLAIoHu+/wE=; b=pPU4TD3QeQq/g7uinRxk6kZ6999p1A+LsVanV8ILJbajjtkt1MWDFL7oy7FY86jEbO 0/L7P9uRnDHhX95cbZ4T0wXZ8mhDzg1pBHEn8AnTM8v69Au+FEtadW1HRx7MBBPN2dg6 GRFdOvxXXkF3DQlpZhEdfbNtVexMLqAAw3pxN9nhwJRfwG5dCC85tDNOxt5G1ITGnhmg qYKOzOehriQc241V0Lz97fvUdwJnsATd2ucKUanU+LOh61vXGwbAl6+V4mmV1uykdtPP 8ptlIAbsdM4Z0rzlAl38RhqGOsKfma/1C+am3yMytKBqiPQNDydRIQ6Fefscs+J2sjVd s6rQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:from:to:cc:subject:date:message-id:organization :user-agent:in-reply-to:references:mime-version :content-transfer-encoding:content-type; bh=JpUWp/o2xQum9QabkN1vh4l5dg/snvFWzLAIoHu+/wE=; b=CsQuZwb8d26oC/s3RiMSzD1NxxGfpE3F+PROGugLqOssRMLPeXZQRwqX/x2uO6G/97 JPhFsjd5ggZqfOh7gAkPDBbVO9pwo6Qug52DB1/u3MDhi+ZsIkCET8zNIRZJrDQ4mysG toXhdnT3QqaS+vutBbFXKhwhZrQgAE7iWQ5YZB3/Cgwo7eqCmKMdL/iCjm1A7P/12904 UIoz7B5M7jxA+J0uCQM7ZMdnyUX5c8s8YtIHr9MsZ/BjVeflK4o8azlpcXsdLdsUZjip 5uuh/RzfIxZXM3clw3rFjsUuBrgEk2TnwIKbU5MHcVP//yPFVE0tTx5rzapdUYlvBYp0 qMUQ== X-Gm-Message-State: AG10YORETQwyXPwa8GuIind+WJ6G0h4UcgmIqJWYBWT8HbuM5C7ASQTXtQzOZwXQMzcFV8xn X-Received: by 10.28.125.147 with SMTP id y141mr3073133wmc.18.1453988451141; Thu, 28 Jan 2016 05:40:51 -0800 (PST) Received: from xps13.localnet (136-92-190-109.dsl.ovh.fr. [109.190.92.136]) by smtp.gmail.com with ESMTPSA id gg7sm11102300wjd.10.2016.01.28.05.40.50 (version=TLSv1/SSLv3 cipher=OTHER); Thu, 28 Jan 2016 05:40:50 -0800 (PST) From: Thomas Monjalon To: Ferruh Yigit Date: Thu, 28 Jan 2016 14:39:39 +0100 Message-ID: <1940526.tdz5MxOLn2@xps13> Organization: 6WIND User-Agent: KMail/4.14.10 (Linux/4.1.6-1-ARCH; KDE/4.14.11; x86_64; ; ) In-Reply-To: <20160128101113.GA9647@sivlogin002.ir.intel.com> References: <1453716075-28150-1-git-send-email-ferruh.yigit@intel.com> <96929867.upEFuzBccp@xps13> <20160128101113.GA9647@sivlogin002.ir.intel.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Cc: dev@dpdk.org Subject: Re: [dpdk-dev] [PATCH] lib: remove "extern" keyword for functions from header files X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 28 Jan 2016 13:40:51 -0000 2016-01-28 10:11, Ferruh Yigit: > On Wed, Jan 27, 2016 at 07:05:52PM +0100, Thomas Monjalon wrote: > > 2016-01-25 10:01, Ferruh Yigit: > > > Remove "extern" keywords in header files, the ones for function > > > prototypes > > > > I've seen a lot of other extern keywords. Why not removing all? > > > Remaining one are Linux drivers in KNI, they are kind of internal headers, I doubt on touching them. > Should I remove them all? > Also there are more usage in "drivers" folder, I am not sure touching them too, what do you comment? > > > > -extern int rte_eth_dev_configure(uint8_t port_id, > > > - uint16_t nb_rx_queue, > > > - uint16_t nb_tx_queue, > > > - const struct rte_eth_conf *eth_conf); > > > +int rte_eth_dev_configure(uint8_t port_id, uint16_t nb_rx_queue, > > > + uint16_t nb_tx_queue, > > > + const struct rte_eth_conf *eth_conf); > > > > The indent is weird. > > Why not follow the guideline with 2 tabs? > > http://dpdk.org/doc/guides-2.2/contributing/coding_style.html#c-indentation > > Intentionally kept them as original, to scope the patch just to remove a keyword. > Do you want me fix the syntax wherever I touch for this patch? Syntax? Do you mean to fix the indent? Yes I think it is a good practice to fix the indent when modifying some code.