From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 07CB8A0544; Tue, 11 Oct 2022 01:11:57 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 6F40342B8E; Tue, 11 Oct 2022 01:11:56 +0200 (CEST) Received: from out2-smtp.messagingengine.com (out2-smtp.messagingengine.com [66.111.4.26]) by mails.dpdk.org (Postfix) with ESMTP id 9EF4740146; Tue, 11 Oct 2022 01:11:54 +0200 (CEST) Received: from compute5.internal (compute5.nyi.internal [10.202.2.45]) by mailout.nyi.internal (Postfix) with ESMTP id 448535C00D8; Mon, 10 Oct 2022 19:11:54 -0400 (EDT) Received: from mailfrontend1 ([10.202.2.162]) by compute5.internal (MEProxy); Mon, 10 Oct 2022 19:11:54 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h= cc:cc:content-transfer-encoding:content-type:date:date:from:from :in-reply-to:in-reply-to:message-id:mime-version:references :reply-to:sender:subject:subject:to:to; s=fm3; t=1665443514; x= 1665529914; bh=HAV5UAXNXwT5V9+Y3vF5qBG+3+fp0ozCb7JFaW98m40=; b=f EEDmZmCZsAMiHMP/K6oczsyANHxLkG1vanrIQ+xezN4uOTX37B66m18V+Cl+QQdf rBFZS3pcy7x1tb7lVjYVa6qxgmt+HZ73PG7qDMNkE2eQSGKcAhGJkyAw6SCYwCEB JcYiPvu4i+PY2HhjUwZrR3ezBAuZLPrkIJ4IXyQxzV8xkc4YUXQ01cHh2+lnT37y EP5fGky0iti0JkxFHV+J/aId9YowjQ6Y4NZ1QKTGsED3fWdMYC+VcjUElCt2ypkj I7Z+ruWhcUpQoFXit8j+TVFc8T0Lhzphepwsv5WN1p39zAPC3lduz6brfdUk5tKV +M07wTbJq2DUKcqP1FBrA== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-transfer-encoding :content-type:date:date:feedback-id:feedback-id:from:from :in-reply-to:in-reply-to:message-id:mime-version:references :reply-to:sender:subject:subject:to:to:x-me-proxy:x-me-proxy :x-me-sender:x-me-sender:x-sasl-enc; s=fm3; t=1665443514; x= 1665529914; bh=HAV5UAXNXwT5V9+Y3vF5qBG+3+fp0ozCb7JFaW98m40=; b=D KEt3nVY65RNok8HSyATBJYi5fToKdOdXwOZ3O0+4KpHTYjsy+RWGA2doO58pr46t ohTXMy3U0OTCSDKKusdrtHq+gYZY7Y5bgYuOLp+OnOd3Ulpq3bee67qBvkxfE+fD 9GIdvqltHLf3Y8IwZK1Eed4JJdHB+7ouJDa+C0RhKCjcX6OpWOLcRoxU2sL+nISU WOEJOMIhqhyKttYBBCRtT8Drm2CnKxJl7SmKESMvLcNMotGVHnZv1joQ2YuPBCAB CtnY5T6SiFDfK2Xgjmm3rU0PyEyfxTAAO5ljQgTHsMT/p4SZ33i3fgJXlsftoQP3 aKQ2Fu/tvSEni48oZ6sXQ== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvfedrfeejhedgudekucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmne cujfgurhephffvvefufffkjghfggfgtgesthhqredttddtudenucfhrhhomhepvfhhohhm rghsucfoohhnjhgrlhhonhcuoehthhhomhgrshesmhhonhhjrghlohhnrdhnvghtqeenuc ggtffrrghtthgvrhhnpeefhfejleeuvdevtddutdeutdevhfeijeethfffueejhfetuddu vedtkedtieekffenucevlhhushhtvghrufhiiigvpedtnecurfgrrhgrmhepmhgrihhlfh hrohhmpehthhhomhgrshesmhhonhhjrghlohhnrdhnvght X-ME-Proxy: Feedback-ID: i47234305:Fastmail Received: by mail.messagingengine.com (Postfix) with ESMTPA; Mon, 10 Oct 2022 19:11:53 -0400 (EDT) From: Thomas Monjalon To: Peng Zhang Cc: dev@dpdk.org, oss-drivers@corigine.com, Chaoyong He , stable@dpdk.org, Niklas =?ISO-8859-1?Q?S=F6derlund?= Subject: Re: [PATCH v2] buildtools: ensure the NUMA nodes are counted correct Date: Tue, 11 Oct 2022 01:11:51 +0200 Message-ID: <1942545.2IRrRt1zHL@thomas> In-Reply-To: <20220922080642.315800-1-niklas.soderlund@corigine.com> References: <1659426855-11014-1-git-send-email-chaoyong.he@corigine.com> <20220922080642.315800-1-niklas.soderlund@corigine.com> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="iso-8859-1" X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org 22/09/2022 10:06, Niklas S=F6derlund: > From: Peng Zhang >=20 > The method to fetch, sort and read the last entry of a list to figure > out the total number of NUMA nodes in the system fails with 10 or more > nodes. The reason being the usage of string compare while sorting, hence > node 'node10' will be sorted before 'node2'. >=20 > Solve this by sorting the list based on integer comparison of the > numerical part of the node name. >=20 > Before this change on a system with 16 NUMA nodes, >=20 > EAL: Detected CPU lcores: 128 > EAL: Detected NUMA nodes: 10 > EAL: Static memory layout is selected, amount of reserved memory can > be adjusted with -m or --socket-mem > EAL: Detected static linkage of DPDK > EAL: Multi-process socket /var/run/dpdk/rte/mp_socket > EAL: Selected IOVA mode 'VA' > EAL: VFIO support initialized >=20 > With this change on the same system, >=20 > EAL: Detected CPU lcores: 128 > EAL: Detected NUMA nodes: 16 > EAL: Static memory layout is selected, amount of reserved memory can > be adjusted with -m or --socket-mem > EAL: Detected static linkage of DPDK > EAL: Multi-process socket /var/run/dpdk/rte/mp_socket > EAL: Selected IOVA mode 'VA' > EAL: VFIO support initialized >=20 > Fixes: 8ef09fdc506b ("build: add optional NUMA and CPU counts detection") > Cc: stable@dpdk.org >=20 > Signed-off-by: Peng Zhang > Signed-off-by: Chaoyong He > Reviewed-by: Niklas S=F6derlund Applied, thanks.