From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-wg0-f52.google.com (mail-wg0-f52.google.com [74.125.82.52]) by dpdk.org (Postfix) with ESMTP id F0F80C312 for ; Tue, 16 Jun 2015 11:08:26 +0200 (CEST) Received: by wgez8 with SMTP id z8so7382826wge.0 for ; Tue, 16 Jun 2015 02:08:26 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:from:to:cc:subject:date:message-id:organization :user-agent:in-reply-to:references:mime-version :content-transfer-encoding:content-type; bh=5+I1ZmsuG01Z4uTkc2IcuE/CLP3PBEA6wy4sAvhZfNg=; b=N/tdhJ1mO56/hZ2LpxTR1+e66R/1h8XgmXt/SNBiNgnwZrQLqAGoi6akzHKDY7qxIp tm57gCrZboeu0Od8epiSG0fSeS1j/L+m6l7poYYug1GH+aqCgzKhAAdkvmYtqw2hHZl9 3gKxAETQMiizOB+gwHeLWOniHOEHb82InCL9QisN6fZFxQI8ihCTyJ+61i8znc7KeXi1 w4OyqsOY+dDqLcRkB1LaF8ekcHbRqCR37YQpolG2okJfGTUkteLhf83fOAOq7jxvvRNL 4lgp2qdhwjGcWsHdvAMXvUH2J/XqGpDWpA+CMryX1NaynQaXte76Cw5v52i/DiiSjHA6 Jc5A== X-Gm-Message-State: ALoCoQkzZI+MVCdITozTiS8JlXOM87q+KGg7ltZE3J4uOmbv1XxT8TDHxxyPuIwIYI5mC9ZiZDo0 X-Received: by 10.180.97.7 with SMTP id dw7mr41559534wib.74.1434445706810; Tue, 16 Jun 2015 02:08:26 -0700 (PDT) Received: from xps13.localnet (136-92-190-109.dsl.ovh.fr. [109.190.92.136]) by mx.google.com with ESMTPSA id q4sm646579wja.24.2015.06.16.02.08.25 (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Tue, 16 Jun 2015 02:08:26 -0700 (PDT) From: Thomas Monjalon To: bruce.richardson@intel.com Date: Tue, 16 Jun 2015 11:07:28 +0200 Message-ID: <1943830.H0qqKjE30e@xps13> Organization: 6WIND User-Agent: KMail/4.14.8 (Linux/4.0.4-2-ARCH; KDE/4.14.8; x86_64; ; ) In-Reply-To: <2783732.C59rBDiv7h@xps13> References: <1430832011-17764-1-git-send-email-medvedkinv@gmail.com> <1431097092-19790-1-git-send-email-medvedkinv@gmail.com> <2783732.C59rBDiv7h@xps13> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Cc: dev@dpdk.org Subject: Re: [dpdk-dev] [PATCH v2] Add toeplitz hash algorithm used by RSS X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 16 Jun 2015 09:08:27 -0000 2015-06-03 16:07, Thomas Monjalon: > 2015-05-08 10:58, Vladimir Medvedkin: > > Software implementation of the Toeplitz hash function used by RSS. > > Can be used either for packet distribution on single queue NIC > > or for simulating of RSS computation on specific NIC (for example > > after GRE header decapsulating). > > > > v3 changes > > - Rework API to be more generic > > - Add sctp_tag into tuple > > > > v2 changes > > - Add ipv6 support > > - Various style fixes > > > > Signed-off-by: Vladimir Medvedkin > > --- > > lib/librte_hash/Makefile | 1 + > > lib/librte_hash/rte_thash.h | 207 ++++++++++++++++++++++++++++++++++++++++++++ > > Without any comment, it seems this v3 is approved. > Maybe that this patch would be even better by implementing some unit tests. > I wonder if the hash chapter of the prog guide could list the different > algorithms and why/when use them? Bruce, any opinion? Don't you think that unit tests are required?