From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 22427A0547; Tue, 15 Nov 2022 18:20:49 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 03A3440F18; Tue, 15 Nov 2022 18:20:49 +0100 (CET) Received: from out3-smtp.messagingengine.com (out3-smtp.messagingengine.com [66.111.4.27]) by mails.dpdk.org (Postfix) with ESMTP id CDC6F40E03 for ; Tue, 15 Nov 2022 18:20:47 +0100 (CET) Received: from compute5.internal (compute5.nyi.internal [10.202.2.45]) by mailout.nyi.internal (Postfix) with ESMTP id 881C95C03A3; Tue, 15 Nov 2022 12:20:46 -0500 (EST) Received: from mailfrontend2 ([10.202.2.163]) by compute5.internal (MEProxy); Tue, 15 Nov 2022 12:20:46 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h= cc:cc:content-transfer-encoding:content-type:date:date:from:from :in-reply-to:in-reply-to:message-id:mime-version:references :reply-to:sender:subject:subject:to:to; s=fm1; t=1668532846; x= 1668619246; bh=ZHDNPBn1lKtzj0SSGCCV37ppdooi+kTMKxxF8EQqqUg=; b=Y 4DiLV30uxm52lePsON0w4B/AlO+qFhFBhFcEdp5DVVfmpvJUmyYSEG7Usi2zqBRl FmS/tLQouP3yAoKViOpbJIgO16coCKkChp5GT0AjQCcEUFpEVd3UVuq7JOAnJC5o AMPyMvVn69ypFftDT2pVHsDMh1dKQ1yYx0NiqTFO4wq5ORvMGonBX4wri51xiumT U7LJ2GRlceuoyBmkFYfPalP33lgWFi6fXtOXuwgzh0583YHV5cG8msDzgbpUUh+M s6JlzX4jUT8RddmWYZnTeIdtlR/2jlThLJgGO+C7Xnudkzk9AkWcJrZlZ3mwQ0yM snF6QnZ6awzD7f6SVRq2w== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-transfer-encoding :content-type:date:date:feedback-id:feedback-id:from:from :in-reply-to:in-reply-to:message-id:mime-version:references :reply-to:sender:subject:subject:to:to:x-me-proxy:x-me-proxy :x-me-sender:x-me-sender:x-sasl-enc; s=fm1; t=1668532846; x= 1668619246; bh=ZHDNPBn1lKtzj0SSGCCV37ppdooi+kTMKxxF8EQqqUg=; b=u njS7uCYncj+7Ae4W+i7nn8J+GmZQplIydOtpfnPH+n2U02svPUghPbSsQuexue74 iI3mxoC4BY+jImdYsWWVwwUZoFClUkvB4X0ox09G4XXSFXFk+C1/O0brFL5iG6vQ vSvHWwAvZPBLBV3DlYX/IXryvX0k/sr1qPFZsOvvxSQLShU/WCF0oezpqPNIxhVp oH+J30gnhqN45/eCgUZ29yI+LNKm395gsiZoEMxa9Qn68EczKrk+/oAnCJ0ZIn0c rdgCSAQRCf8/g+EDYrFnM/ImEBTxxup0HgSrcqE1SNN2+nJppeTDudUnr/H2+iVn jeAKcs90vcvlIJGVYFwzw== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvgedrgeeggdellecutefuodetggdotefrodftvf curfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdpuffrtefokffrpgfnqfghnecu uegrihhlohhuthemuceftddtnecusecvtfgvtghiphhivghnthhsucdlqddutddtmdenuc fjughrpefhvfevufffkfgjfhgggfgtsehtufertddttddvnecuhfhrohhmpefvhhhomhgr shcuofhonhhjrghlohhnuceothhhohhmrghssehmohhnjhgrlhhonhdrnhgvtheqnecugg ftrfgrthhtvghrnheptdejieeifeehtdffgfdvleetueeffeehueejgfeuteeftddtieek gfekudehtdfgnecuvehluhhsthgvrhfuihiivgeptdenucfrrghrrghmpehmrghilhhfrh homhepthhhohhmrghssehmohhnjhgrlhhonhdrnhgvth X-ME-Proxy: Feedback-ID: i47234305:Fastmail Received: by mail.messagingengine.com (Postfix) with ESMTPA; Tue, 15 Nov 2022 12:20:45 -0500 (EST) From: Thomas Monjalon To: David Marchand Cc: Bruce Richardson , dev@dpdk.org, omer.yamac@ceng.metu.edu.tr, Ferruh Yigit Subject: Re: [PATCH] devtools: catch empty symbol maps Date: Tue, 15 Nov 2022 18:20:44 +0100 Message-ID: <1944772.8hb0ThOEGa@thomas> In-Reply-To: <4f0df49a-c78c-b84c-fa4c-ed96f8d900c7@amd.com> References: <20221114141651.1255306-1-david.marchand@redhat.com> <4f0df49a-c78c-b84c-fa4c-ed96f8d900c7@amd.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org 14/11/2022 16:10, Ferruh Yigit: > On 11/14/2022 2:31 PM, Bruce Richardson wrote: > > On Mon, Nov 14, 2022 at 03:16:51PM +0100, David Marchand wrote: > >> version.map are now optional for drivers if no symbol is exported. > >> Having no symbol exported from a library does not make sense. > >> > >> Catch all empty maps and warn about them. > >> > >> Example: > >> $ ./devtools/check-symbol-maps.sh > >> Found empty maps: > >> drivers/crypto/uadk/version.map > >> drivers/net/gve/version.map > >> drivers/net/idpf/version.map > >> > >> Signed-off-by: David Marchand > > > > Acked-by: Bruce Richardson > > +1 to have automated checks, > Tested-by: Ferruh Yigit Applied, thanks.