From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-we0-f176.google.com (mail-we0-f176.google.com [74.125.82.176]) by dpdk.org (Postfix) with ESMTP id 6F48E678B for ; Fri, 18 Apr 2014 14:08:57 +0200 (CEST) Received: by mail-we0-f176.google.com with SMTP id x48so1480694wes.21 for ; Fri, 18 Apr 2014 05:08:58 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:from:to:cc:subject:date:message-id:organization :user-agent:in-reply-to:references:mime-version :content-transfer-encoding:content-type; bh=B9uPMPXo80pHXqi/pSckBUcn7/4I4hnxWNBMhVoDxiU=; b=GzlbtknFqyrXP/d9kFAFgrlJOhUpWaLruzXSUrqSWEdD188Cm2XrrIu24QMxJ8nEA9 CADSng5+UAOBx2kYQ+QFGxsyStiHQV34wGb5uGJZYWmBWEtrDWypkQNuXYFnh9xuzrWD ao/LJ8QbX7A36DSxaEih9e49O/3e3shukB6+dlxKNkblRNfKnMNSgsbn4WTqc/+LWaw+ Vy1sySCE6aAOIIn9/QlZvztfgydzPwP6rycECTIL2WBBCcLgDwMDbmJC9U1UCL7+m1yo tccJRiGRLyCEe4TuHY+BXIHrv+Zxq8lYsm/go+Zjek0EFSvp0Mk1DaUVg9dwtEQx4F4I npew== X-Gm-Message-State: ALoCoQkFojs99RQy2EWpWhGNREfZfJi3f45vT13exuGZLIyIjLani4P58V3IKHMXw/91z44+04JG X-Received: by 10.194.82.35 with SMTP id f3mr16393898wjy.36.1397822938279; Fri, 18 Apr 2014 05:08:58 -0700 (PDT) Received: from xps13.localnet (6wind.net2.nerim.net. [213.41.180.237]) by mx.google.com with ESMTPSA id uy4sm29460746wjc.8.2014.04.18.05.08.57 for (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Fri, 18 Apr 2014 05:08:57 -0700 (PDT) From: Thomas Monjalon To: Neil Horman Date: Fri, 18 Apr 2014 14:08:56 +0200 Message-ID: <1947585.TXBcrJqKvb@xps13> Organization: 6WIND User-Agent: KMail/4.12.4 (Linux/3.14.1-1-ARCH; KDE/4.12.4; x86_64; ; ) In-Reply-To: <20140418120409.GB2812@localhost.localdomain> References: <1397585169-14537-1-git-send-email-nhorman@tuxdriver.com> <16254493.92s6zWrT4n@xps13> <20140418120409.GB2812@localhost.localdomain> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Cc: dev@dpdk.org Subject: Re: [dpdk-dev] [PATCH 03/15] pmd: Add PMD_REGISTER_DRIVER macro X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 18 Apr 2014 12:08:57 -0000 2014-04-18 08:04, Neil Horman: > On Fri, Apr 18, 2014 at 04:42:01AM -0700, Thomas Monjalon wrote: > > 2014-04-15 14:05, Neil Horman: > > > Rather than have each driver have to remember to add a constructor to it > > > to > > > make sure its gets registered properly, wrap that process up in a macro > > > to > > > make registration a one line affair. This also sets the stage for us to > > > make registration of vdev pmds and physical pmds a uniform process > > > > > > Signed-off-by: Neil Horman > > > > > > --- /dev/null > > > +++ b/lib/librte_eal/common/include/rte_pmd.h > > > > So you are creating a new header file for PMD API, right? > > > > According to rte_ethdev.h, > > "The Ethernet Device API is composed of two parts:" > > "- The application-oriented Ethernet API" > > "- The driver-oriented Ethernet API" > > > > So we should implement this macro in rte_ethdev.h. > > But maybe you prefer to split this file in two files. If so, please send a > > separated patch for that. > > Actually I'm fine with moving the macro to another file, though if I do, I > think merging it into rte_dev.h is more appropriate, as thats where the > driver registration function lives. I'm not sure to understand what you're saying. My suggestion is to have 2 files in lib/librte_ether: 1 for application API and 1 for PMD API. -- Thomas