From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from out1-smtp.messagingengine.com (out1-smtp.messagingengine.com [66.111.4.25]) by dpdk.org (Postfix) with ESMTP id 7CFCD2BAE for ; Fri, 21 Apr 2017 10:42:36 +0200 (CEST) Received: from compute1.internal (compute1.nyi.internal [10.202.2.41]) by mailout.nyi.internal (Postfix) with ESMTP id 9E2AE20D11; Fri, 21 Apr 2017 04:42:35 -0400 (EDT) Received: from frontend2 ([10.202.2.161]) by compute1.internal (MEProxy); Fri, 21 Apr 2017 04:42:35 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to:x-me-sender :x-me-sender:x-sasl-enc:x-sasl-enc; s=mesmtp; bh=goHMxT3C9raumxq xJrJJFR5N6b6vpIwNhae0C1N3NWo=; b=mntlgD7Wmx8o8VgGsKYBiVPrStUemya DtgYDt70gRz6YVvn60PUwFx01EwUrqpE/9acHsZQRDe2WYO8m3S2p4iQfBy5Mtfz GQIKXEoWxYy2M4zeZPUN7A0vSqBq1OuJR1TCBgYY9z2x4vjRWYJRvctc02XNFJNV Paxz0DNK6TM8= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-transfer-encoding:content-type :date:from:in-reply-to:message-id:mime-version:references :subject:to:x-me-sender:x-me-sender:x-sasl-enc:x-sasl-enc; s= fm1; bh=goHMxT3C9raumxqxJrJJFR5N6b6vpIwNhae0C1N3NWo=; b=CoZ0ikdv N6qd1SzE8bHQCRWrgDm+JxijCLUtQqEzpfIgNrlgm8w81t6HOGzjutrLRc4x5LzQ T4OBkOQz+6JMnxUBh7T7dp/8ry5Fc0zJL4NR6UZRwkbGaXUU1Dgqmoe2LLRqtmNO WIryWq05eDec8xDfoU3pajX+mhNciqVozmsIzDJyvVsF/0NfZKNaQw7s7efGthrD ja6WTfHne0koIO98fr5sat+kzGcSUmFfq32RpQyCNQvhTu7mmsQz782RqljRSrmG JmXtAdTdMVpWKoQhG0xJ6gfkrY+klXvnG7rjGOYlAOjMbVzuwrwfo7cTPy70/EWH VzI57R/xELb2tQ== X-ME-Sender: X-Sasl-enc: nDzfVxui2aUQ9SotRUFQ5DU7dhGxu6QtMcAQeBx0Typ5 1492764154 Received: from xps.localnet (184.203.134.77.rev.sfr.net [77.134.203.184]) by mail.messagingengine.com (Postfix) with ESMTPA id EF4E8246CA; Fri, 21 Apr 2017 04:42:34 -0400 (EDT) From: Thomas Monjalon To: John Daley Cc: dev@dpdk.org, Adrien Mazarguil , john.mcnamara@intel.com Date: Fri, 21 Apr 2017 10:42:34 +0200 Message-ID: <1947927.qzoAqWIl4q@xps> In-Reply-To: <20170421081142.GY3790@6wind.com> References: <20170407002300.14433-1-johndale@cisco.com> <20170420184933.27450-1-johndale@cisco.com> <20170421081142.GY3790@6wind.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Subject: Re: [dpdk-dev] [PATCH v4] doc: fix flow validate comments X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 21 Apr 2017 08:42:36 -0000 21/04/2017 10:11, Adrien Mazarguil: > On Thu, Apr 20, 2017 at 11:49:33AM -0700, John Daley wrote: > > Change comments for rte_flow_validate() function to indicate that flow > > rule collision and resource validation is optional for PMDs and > > therefore the return codes may have different meanings. > > > > Fixes: b1a4b4cbc0a8 ("ethdev: introduce generic flow API") > > > > Signed-off-by: John Daley > > One last nit below (not sure if you need to send a new version). In any > case: > > Acked-by: Adrien Mazarguil Applied (with empty line removed), thanks