From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 8796741E80; Sun, 12 Mar 2023 15:05:53 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 6997440F18; Sun, 12 Mar 2023 15:05:53 +0100 (CET) Received: from wout1-smtp.messagingengine.com (wout1-smtp.messagingengine.com [64.147.123.24]) by mails.dpdk.org (Postfix) with ESMTP id 57BBB406A2 for ; Sun, 12 Mar 2023 15:05:52 +0100 (CET) Received: from compute5.internal (compute5.nyi.internal [10.202.2.45]) by mailout.west.internal (Postfix) with ESMTP id 4E74632003AC; Sun, 12 Mar 2023 10:05:48 -0400 (EDT) Received: from mailfrontend2 ([10.202.2.163]) by compute5.internal (MEProxy); Sun, 12 Mar 2023 10:05:49 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h= cc:cc:content-transfer-encoding:content-type:content-type:date :date:from:from:in-reply-to:in-reply-to:message-id:mime-version :references:reply-to:sender:subject:subject:to:to; s=fm2; t= 1678629947; x=1678716347; bh=L5j4/tH9st9B4AzNAQT8/JHqTllYNzce0lq FTDORkBw=; b=rZTrB3OlUCnWtxxtaeyPFgm0jxVbt/X56xqPBkJPxG8s7CLko2H cByO/v+vA5JcYztiG/Wsmdcl0xtsYkqvTWkvgS393dXDS/GNaTnCplMVJcKhdCd9 2MMePREa2Xqs8H0aD42hirQGgHbCESY+gLAgN5g4NTr7Zae0UwAGi+6ZmtNFHYMI Gw0DJ7kNNq+MTMvR+3dIioTYGZq6nRBU2MW6WHUylfJVzrq+ieMSSWkz9VHidaut NbP5hm8DH6UN+f+Vvt1nFg5YKWd8aOzDFyWDWHRCfCQUqbauadeCdApRqzTzKelH MnQJ8EKT19uDougHm/M+gg+8W05mH4UdiMA== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-transfer-encoding :content-type:content-type:date:date:feedback-id:feedback-id :from:from:in-reply-to:in-reply-to:message-id:mime-version :references:reply-to:sender:subject:subject:to:to:x-me-proxy :x-me-proxy:x-me-sender:x-me-sender:x-sasl-enc; s=fm2; t= 1678629947; x=1678716347; bh=L5j4/tH9st9B4AzNAQT8/JHqTllYNzce0lq FTDORkBw=; b=dYvx3B+AGAFb0uEhPP8w2wOaNpIWery557Q1WF1sx0+ulQjZVCe 6eLtU1+WLljo4U2lr1cfhlO+mVok+LGZQ4t07k5KQe38004WspZcs5wz++K2dXnc zebEEIDi2T39AFzywM2XYmJxdAmq/e8YvzrdSMu8gELaV2E7qfWcpA4UP3XIKIAX HXlhWf3imRYd7RVNmGQ6BaqNWYEO6gCECLzUvCQjCAaAClr+R4D8m2pvxdNEaBhY eKx1qQNbO7rjuXk+QhMkbbEvWf/NjpODyaCljkGKLDZUwFIGSrPgBx9tAt50VRZw 6HvIvv7uc/KcHeXzZ1Tp7etmEVbHPbcDWiA== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvhedrvddvvddgheekucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmne cujfgurhephffvvefufffkjghfggfgtgesthfuredttddtvdenucfhrhhomhepvfhhohhm rghsucfoohhnjhgrlhhonhcuoehthhhomhgrshesmhhonhhjrghlohhnrdhnvghtqeenuc ggtffrrghtthgvrhhnpedtjeeiieefhedtfffgvdelteeufeefheeujefgueetfedttdei kefgkeduhedtgfenucevlhhushhtvghrufhiiigvpedtnecurfgrrhgrmhepmhgrihhlfh hrohhmpehthhhomhgrshesmhhonhhjrghlohhnrdhnvght X-ME-Proxy: Feedback-ID: i47234305:Fastmail Received: by mail.messagingengine.com (Postfix) with ESMTPA; Sun, 12 Mar 2023 10:05:46 -0400 (EDT) From: Thomas Monjalon To: Mohammad Iqbal Ahmad Cc: dev@dpdk.org, Wisam Jaddo , Xiaoyu Min , jerinj@marvell.com, skori@marvell.com, skoteshwar@marvell.com, pbhagavatula@marvell.com, kirankumark@marvell.com, psatheesh@marvell.com, asekhar@marvell.com, anoobj@marvell.com, gakhil@marvell.com, hkalra@marvell.com, ndabilpuram@marvell.com Subject: Re: [PATCH v3 1/1] app/test-flow-perf: fix division or module by zero Date: Sun, 12 Mar 2023 15:05:44 +0100 Message-ID: <1948898.CrzyxZ31qj@thomas> In-Reply-To: <20230124103803.1924606-1-mahmad@marvell.com> References: <20221219083402.1899934-1-mahmad@marvell.com> <20230124103803.1924606-1-mahmad@marvell.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org 24/01/2023 11:38, Mohammad Iqbal Ahmad: > Fix division or module by zero reported by coverity scan. > Updated .mailmap > > Coverity issue: 373870 > Fixes: bf3688f1e816 ("app/flow-perf: add insertion rate calculation") > > Signed-off-by: Mohammad Iqbal Ahmad > --- > if (strcmp(lgopts[opt_idx].name, > "rules-batch") == 0) { > - rules_batch = atoi(optarg); > + n = atoi(optarg); > + if (n > 0) > + rules_batch = n; > + else > + rte_exit(EXIT_FAILURE, > + "flow rules_batch should be > 0\n"); The option name is rules-batch (with a hyphen). Will fix while merging. Applied, thanks.