From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id F2E2241DBC; Fri, 3 Mar 2023 02:49:21 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id D9F1A40EE3; Fri, 3 Mar 2023 02:49:21 +0100 (CET) Received: from szxga01-in.huawei.com (szxga01-in.huawei.com [45.249.212.187]) by mails.dpdk.org (Postfix) with ESMTP id D3B2D40687 for ; Fri, 3 Mar 2023 02:49:20 +0100 (CET) Received: from dggpeml500024.china.huawei.com (unknown [172.30.72.53]) by szxga01-in.huawei.com (SkyGuard) with ESMTP id 4PSW8j1PWyzrS5w; Fri, 3 Mar 2023 09:48:37 +0800 (CST) Received: from [10.67.100.224] (10.67.100.224) by dggpeml500024.china.huawei.com (7.185.36.10) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.21; Fri, 3 Mar 2023 09:49:17 +0800 Subject: Re: [PATCH 5/5] app/testpmd: add error recovery usage demo To: Konstantin Ananyev , "thomas@monjalon.net" , "ferruh.yigit@amd.com" , Aman Singh , Yuying Zhang CC: "dev@dpdk.org" References: <20230301030610.49468-1-fengchengwen@huawei.com> <20230301030610.49468-6-fengchengwen@huawei.com> <27b5e0017a304183b812a7e45858e03a@huawei.com> From: fengchengwen Message-ID: <194fd7a3-ee13-0993-255a-e75d8f256127@huawei.com> Date: Fri, 3 Mar 2023 09:49:17 +0800 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:68.0) Gecko/20100101 Thunderbird/68.11.0 MIME-Version: 1.0 In-Reply-To: <27b5e0017a304183b812a7e45858e03a@huawei.com> Content-Type: text/plain; charset="utf-8" Content-Language: en-US Content-Transfer-Encoding: 7bit X-Originating-IP: [10.67.100.224] X-ClientProxiedBy: dggems704-chm.china.huawei.com (10.3.19.181) To dggpeml500024.china.huawei.com (7.185.36.10) X-CFilter-Loop: Reflected X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On 2023/3/2 21:01, Konstantin Ananyev wrote: > > >> >> This patch adds error recovery usage demo which will: >> 1. stop packet forwarding when the RTE_ETH_EVENT_ERR_RECOVERING event >> is received. >> 2. restart packet forwarding when the RTE_ETH_EVENT_RECOVERY_SUCCESS >> event is received. >> 3. prompt the ports that fail to recovery and need to be removed when >> the RTE_ETH_EVENT_RECOVERY_FAILED event is received. >> >> In addition, a message is added to the printed information, requiring >> no command to be executed during the error recovery. >> >> Signed-off-by: Chengwen Feng >> --- >> app/test-pmd/testpmd.c | 80 ++++++++++++++++++++++++++++++++++++++++++ >> app/test-pmd/testpmd.h | 4 ++- >> 2 files changed, 83 insertions(+), 1 deletion(-) >> >> diff --git a/app/test-pmd/testpmd.c b/app/test-pmd/testpmd.c >> index 0c14325b8d..fdc3ae604b 100644 >> --- a/app/test-pmd/testpmd.c >> +++ b/app/test-pmd/testpmd.c >> @@ -3823,6 +3823,77 @@ rmv_port_callback(void *arg) >> start_packet_forwarding(0); >> } >> >> +static int need_start_when_recovery_over; >> + >> +static bool >> +has_port_in_err_recovering(void) >> +{ >> + struct rte_port *port; >> + portid_t pid; >> + >> + RTE_ETH_FOREACH_DEV(pid) { >> + port = &ports[pid]; >> + if (port->err_recovering) >> + return true; >> + } >> + >> + return false; >> +} >> + >> +static void >> +err_recovering_callback(portid_t port_id) >> +{ >> + if (!has_port_in_err_recovering()) >> + printf("Please stop executing any commands until recovery result events are received!\n"); >> + >> + ports[port_id].err_recovering = 1; >> + ports[port_id].recover_failed = 0; >> + >> + /* To simplify implementation, stop forwarding regardless of whether the port is used. */ >> + if (!test_done) { >> + printf("Stop packet forwarding because some ports are in error recovering!\n"); >> + stop_packet_forwarding(); >> + need_start_when_recovery_over = 1; >> + } >> +} > > One thought I have - should we somehow stop user to attempt restart RX/TX while recovery > in progress? > But probably it is an overkill, and just documenting what is happening is enough.... Yes, the testpmd is already complicated. In addition, considering that only a few PMDs support and are not commonly invoking. So I thinking show above such promote is enough. > Do we need to update testpmd UG with some short description? It's better to update UG, but it wasn't triggered by command, I don't know which chapter to put it in. @Ferruh could you provide some advise ? > Apart from that, LGTM: > Acked-by: Konstantin Ananyev > >> + >> +static void >> +recover_success_callback(portid_t port_id) >> +{ >> + ports[port_id].err_recovering = 0; >> + if (has_port_in_err_recovering()) >> + return; >> + >> + if (need_start_when_recovery_over) { >> + printf("Recovery success! Restart packet forwarding!\n"); >> + start_packet_forwarding(0); >> + need_start_when_recovery_over = 0; >> + } else { >> + printf("Recovery success!\n"); >> + } >> +} >> + >> +static void >> +recover_failed_callback(portid_t port_id) >> +{ >> + struct rte_port *port; >> + portid_t pid; >> + >> + ports[port_id].err_recovering = 0; >> + ports[port_id].recover_failed = 1; >> + if (has_port_in_err_recovering()) >> + return; >> + >> + need_start_when_recovery_over = 0; >> + printf("The ports:"); >> + RTE_ETH_FOREACH_DEV(pid) { >> + port = &ports[pid]; >> + if (port->recover_failed) >> + printf(" %u", pid); >> + } >> + printf(" recovery failed! Please remove them!\n"); >> +} >> + >> /* This function is used by the interrupt thread */ >> static int >> eth_event_callback(portid_t port_id, enum rte_eth_event_type type, void *param, >> @@ -3878,6 +3949,15 @@ eth_event_callback(portid_t port_id, enum rte_eth_event_type type, void *param, >> } >> break; >> } >> + case RTE_ETH_EVENT_ERR_RECOVERING: >> + err_recovering_callback(port_id); >> + break; >> + case RTE_ETH_EVENT_RECOVERY_SUCCESS: >> + recover_success_callback(port_id); >> + break; >> + case RTE_ETH_EVENT_RECOVERY_FAILED: >> + recover_failed_callback(port_id); >> + break; >> default: >> break; >> } >> diff --git a/app/test-pmd/testpmd.h b/app/test-pmd/testpmd.h >> index 329a6378a1..1bbf82a96c 100644 >> --- a/app/test-pmd/testpmd.h >> +++ b/app/test-pmd/testpmd.h >> @@ -323,7 +323,9 @@ struct rte_port { >> uint8_t slave_flag : 1, /**< bonding slave port */ >> bond_flag : 1, /**< port is bond device */ >> fwd_mac_swap : 1, /**< swap packet MAC before forward */ >> - update_conf : 1; /**< need to update bonding device configuration */ >> + update_conf : 1, /**< need to update bonding device configuration */ >> + err_recovering : 1, /**< port is in error recovering */ >> + recover_failed : 1; /**< port recover failed */ >> struct port_template *pattern_templ_list; /**< Pattern templates. */ >> struct port_template *actions_templ_list; /**< Actions templates. */ >> struct port_table *table_list; /**< Flow tables. */ >> -- >> 2.17.1 > > . >