From: Thomas Monjalon <thomas@monjalon.net>
To: Andrew Rybchenko <andrew.rybchenko@oktetlabs.ru>
Cc: Ori Kam <orika@nvidia.com>,
dev@dpdk.org, "Richardson, Bruce" <bruce.richardson@intel.com>,
"Yigit, Ferruh" <ferruh.yigit@intel.com>,
"Singh, Aman Deep" <aman.deep.singh@intel.com>,
"Li, Xiaoyun" <xiaoyun.li@intel.com>
Subject: Re: [dpdk-dev] [PATCH v3] app/testpmd: send failure logs to stderr
Date: Sat, 24 Jul 2021 15:14:06 +0200 [thread overview]
Message-ID: <1950656.rHmG9LB3RM@thomas> (raw)
In-Reply-To: <DM4PR11MB5534D4CE90DE9C1A356BA0C0990D9@DM4PR11MB5534.namprd11.prod.outlook.com>
> > Running with stdout suppressed or redirected for further processing
> > is very confusing in the case of errors. Fix it by logging errors and
> > warnings to stderr.
> >
> > Since lines with log messages are touched anyway concatenate split
> > format strings to make it easier to search using grep.
> >
> > Fix indent of format string arguments.
> >
> > Signed-off-by: Andrew Rybchenko <andrew.rybchenko@oktetlabs.ru>
>
> Acked-by: Xiaoyun Li <xiaoyun.li@intel.com>
Applied, rebased and added few more stderrs, thanks.
prev parent reply other threads:[~2021-07-24 13:13 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-05-27 16:24 [dpdk-dev] [PATCH] " Andrew Rybchenko
2021-06-11 2:06 ` Li, Xiaoyun
2021-06-11 9:19 ` Andrew Rybchenko
2021-06-11 10:35 ` Ferruh Yigit
2021-06-11 13:21 ` Bruce Richardson
2021-06-14 16:47 ` Andrew Rybchenko
2021-06-14 16:56 ` Andrew Rybchenko
2021-06-14 17:49 ` Singh, Aman Deep
2021-06-15 7:59 ` Ferruh Yigit
2021-06-15 8:14 ` Andrew Rybchenko
2021-06-15 8:52 ` Ferruh Yigit
2021-06-15 9:00 ` Andrew Rybchenko
2021-06-15 9:53 ` Ferruh Yigit
2021-06-16 16:32 ` [dpdk-dev] [PATCH v2] " Andrew Rybchenko
2021-06-17 3:29 ` Li, Xiaoyun
2021-06-17 14:21 ` Andrew Rybchenko
2021-06-17 14:20 ` [dpdk-dev] [PATCH v3] " Andrew Rybchenko
2021-06-18 8:32 ` Li, Xiaoyun
2021-06-28 11:05 ` Andrew Rybchenko
2021-07-24 13:14 ` Thomas Monjalon [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1950656.rHmG9LB3RM@thomas \
--to=thomas@monjalon.net \
--cc=aman.deep.singh@intel.com \
--cc=andrew.rybchenko@oktetlabs.ru \
--cc=bruce.richardson@intel.com \
--cc=dev@dpdk.org \
--cc=ferruh.yigit@intel.com \
--cc=orika@nvidia.com \
--cc=xiaoyun.li@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).