DPDK patches and discussions
 help / color / mirror / Atom feed
From: Thomas Monjalon <thomas.monjalon@6wind.com>
To: Chao Zhu <chaozhu@linux.vnet.ibm.com>
Cc: dev@dpdk.org
Subject: Re: [dpdk-dev] [PATCH] Fix KNI compiling issue on IBM Power
Date: Thu, 04 Dec 2014 12:59:31 +0100	[thread overview]
Message-ID: <1950672.AxEg8fkUWW@xps13> (raw)
In-Reply-To: <1417688048-23076-2-git-send-email-chaozhu@linux.vnet.ibm.com>

> Because of different cache line size, the alignment of struct
> rte_kni_mbuf in rte_kni_common.h doesn't work on IBM Power. This patch
> changed from 64 to RTE_CACHE_LINE_SIZE micro to do the alignment.
> 
> Signed-off-by: Chao Zhu <chaozhu@linux.vnet.ibm.com>

Acked-by: Thomas Monjalon <thomas.monjalon@6wind.com>

Applied

I wonder if we could try to guess the cache line size instead of
configuring it in many places.
Maybe we could use something like sysconf(_SC_LEVEL1_DCACHE_LINESIZE)?

Thanks
-- 
Thomas

  reply	other threads:[~2014-12-04 11:59 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-12-04 10:14 [dpdk-dev] [PATCH] Fix KNI compiling " Chao Zhu
2014-12-04 10:14 ` [dpdk-dev] [PATCH] Fix KNI compiling issue " Chao Zhu
2014-12-04 11:59   ` Thomas Monjalon [this message]
2014-12-04 13:29     ` Neil Horman
2014-12-04 13:47       ` Thomas Monjalon
2014-12-04 15:32         ` Neil Horman
2014-12-04 15:59           ` Thomas Monjalon
2014-12-04 20:05             ` Neil Horman
2014-12-05  9:11               ` Chao Zhu
2014-12-05 13:10               ` Thomas Monjalon
2014-12-05 14:42                 ` Neil Horman
2014-12-05 14:52                   ` Thomas Monjalon

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1950672.AxEg8fkUWW@xps13 \
    --to=thomas.monjalon@6wind.com \
    --cc=chaozhu@linux.vnet.ibm.com \
    --cc=dev@dpdk.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).