From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-wg0-f41.google.com (mail-wg0-f41.google.com [74.125.82.41]) by dpdk.org (Postfix) with ESMTP id 74FDC7E75 for ; Thu, 4 Dec 2014 12:59:56 +0100 (CET) Received: by mail-wg0-f41.google.com with SMTP id y19so22498429wgg.0 for ; Thu, 04 Dec 2014 03:59:56 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:from:to:cc:subject:date:message-id:organization :user-agent:in-reply-to:references:mime-version :content-transfer-encoding:content-type; bh=Oykw1y8ZB26UwYVtfy24c+qe7zSkNl8gASXwPX7SZd0=; b=X6FIFL/ShSWBKWlXlGy/OZEYYna02Gy+1dX7CptnSF9XVES1B7eF4iCcr6h140MnJ2 fteB7S5E6dOa9W9uoXMpHW1lq6j6MrsZafLvTecyoU8apjyvJbKiyzHzd75fTQAtvOVe /6l5QJDh/MwQz6RRoiWJV1HL0XsdGBwFxhjk3clUXbpvx8R3WUrhzddTnxC2YVBNxrWA t2pPdqzHAa4TGNg8y/ZSSDJqLZpHFq0RheTsUaY1cCN9ts0rDFTHH0EucWJMr5FtAFqy x87Qs6ifVwkwgI/PUlZ+HfLuZHGGpvKV+bYibV2zktEm2XFSWCx64Lj+BHHYCgJaijxv GCVg== X-Gm-Message-State: ALoCoQmEf+zm/pHTXCoKmf2M33Oc01u7LLAHPfr2G0mn6iUceh1UA8dUwtvRhLGQHEqyP6Mvg1ad X-Received: by 10.180.221.72 with SMTP id qc8mr109530403wic.19.1417694396331; Thu, 04 Dec 2014 03:59:56 -0800 (PST) Received: from xps13.localnet (136-92-190-109.dsl.ovh.fr. [109.190.92.136]) by mx.google.com with ESMTPSA id j2sm40223254wjs.28.2014.12.04.03.59.54 for (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Thu, 04 Dec 2014 03:59:55 -0800 (PST) From: Thomas Monjalon To: Chao Zhu Date: Thu, 04 Dec 2014 12:59:31 +0100 Message-ID: <1950672.AxEg8fkUWW@xps13> Organization: 6WIND User-Agent: KMail/4.14.3 (Linux/3.17.4-1-ARCH; KDE/4.14.3; x86_64; ; ) In-Reply-To: <1417688048-23076-2-git-send-email-chaozhu@linux.vnet.ibm.com> References: <1417688048-23076-1-git-send-email-chaozhu@linux.vnet.ibm.com> <1417688048-23076-2-git-send-email-chaozhu@linux.vnet.ibm.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Cc: dev@dpdk.org Subject: Re: [dpdk-dev] [PATCH] Fix KNI compiling issue on IBM Power X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 04 Dec 2014 11:59:56 -0000 > Because of different cache line size, the alignment of struct > rte_kni_mbuf in rte_kni_common.h doesn't work on IBM Power. This patch > changed from 64 to RTE_CACHE_LINE_SIZE micro to do the alignment. > > Signed-off-by: Chao Zhu Acked-by: Thomas Monjalon Applied I wonder if we could try to guess the cache line size instead of configuring it in many places. Maybe we could use something like sysconf(_SC_LEVEL1_DCACHE_LINESIZE)? Thanks -- Thomas